duplicate locations in the quests link

Requests, feedback, and general discussion about WoWRoster
DO NOT post topics about WoWRoster AddOns here!

duplicate locations in the quests link

Postby iradu » Tue May 01, 2007 4:10 pm

Hi,

After I uploading my profile I see duplicate locations in the quests link. How can I fix it? I have 3 rosters on the same servers and I'm using the last CharacterProfiler, but the problem occur on each roster.
Attachments
iradu
WR.net Apprentice
WR.net Apprentice
 
Posts: 9
Joined: Mon Aug 28, 2006 1:07 pm

duplicate locations in the quests link

Postby zanix » Tue May 01, 2007 4:26 pm

I believe this is an error with character profiler

Open CP.lua and check if they are duplicated in the file
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5546
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: duplicate locations in the quests link

Postby rouven » Tue May 01, 2007 8:04 pm

i have the same error. for example this is my cp.lua section for the blackrockdeeps of the player "flotterotto":


Code: Select all
["Schwarzfelstiefen"] = {
                  [15] = {
                     ["Title"] = "Das Herz des Berges",
                     ["RewardMoney"] = 8500,
                     ["Level"] = 55,
                     ["Tasks"] = {
                        {
                           ["Type"] = "item",
                           ["Note"] = "Das Herz des Berges: 0/1",
                        }, -- [1]
                     },
                     ["Tag"] = "Dungeon",
                  },
                  [14] = {
                     ["Choice"] = {
                        {
                           ["Item"] = "11865:0:0:0:0:0:0:0",
                           ["Color"] = "1eff00",
                           ["Tooltip"] = "Grollstiefel<br>Wird beim Aufheben gebunden<br>Füße   Stoff<br>47 Rüstung<br>+12 Beweglichkeit<br>+11 Intelligenz",
                           ["Icon"] = "INV_Boots_02",
                           ["Name"] = "Grollstiefel",
                        }, -- [1]
                        {
                           ["Item"] = "11963:0:0:0:0:0:0:0",
                           ["Color"] = "1eff00",
                           ["Tooltip"] = "Bußwerkschiftung<br>Wird beim Aufheben gebunden<br>Schulter   Leder<br>104 Rüstung<br>+8 Beweglichkeit<br>+11 Ausdauer<br>+7 Willenskraft",
                           ["Icon"] = "INV_Shoulder_25",
                           ["Name"] = "Bußwerkschiftung",
                        }, -- [2]
                        {
                           ["Item"] = "12049:0:0:0:0:0:0:0",
                           ["Color"] = "1eff00",
                           ["Tooltip"] = "Stahlschienenrüstung<br>Wird beim Aufheben gebunden<br>Brust   Schwere Rüstung<br>288 Rüstung<br>+12 Stärke<br>+12 Ausdauer<br>+12 Willenskraft",
                           ["Icon"] = "INV_Chest_Chain_16",
                           ["Name"] = "Stahlschienenrüstung",
                        }, -- [3]
                     },
                     ["Title"] = "Ribbly Schraubstutz",
                     ["RewardMoney"] = 6000,
                     ["Level"] = 53,
                     ["Tasks"] = {
                        {
                           ["Type"] = "item",
                           ["Note"] = "Ribblys Kopf: 0/1",
                        }, -- [1]
                     },
                     ["Tag"] = "Dungeon",
                  },
                  [16] = {
                     ["Title"] = "Feine Sachen",
                     ["Tasks"] = {
                        {
                           ["Type"] = "item",
                           ["Note"] = "Dunkeleisengürteltasche: 0/20",
                        }, -- [1]
                     },
                     ["RewardMoney"] = 8500,
                     ["Rewards"] = {
                        {
                           ["Item"] = "11883:0:0:0:0:0:0:0",
                           ["Color"] = "ffffff",
                           ["Tooltip"] = "Eine schmuddelige Gürteltasche<br>Wird beim Aufheben gebunden",
                           ["Icon"] = "INV_Misc_Bag_09_Black",
                           ["Name"] = "Eine schmuddelige Gürteltasche",
                        }, -- [1]
                     },
                     ["Level"] = 56,
                     ["Tag"] = "Dungeon",
                  },
               },


This is my output with duplicate locations: http://www.kiez-clan.de/_wow/char.php?n ... ion=quests

The database of wowroster is looking fine btw. I think it's something with the output of wowroster.
Last edited by rouven on Tue May 01, 2007 8:17 pm, edited 2 times in total.
User avatar
rouven
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 93
Joined: Fri Jan 12, 2007 4:39 am
Location: Hamburg, Germany

Re: duplicate locations in the quests link

Postby iradu » Tue May 01, 2007 8:20 pm

zanix wrote:I believe this is an error with character profiler

Open CP.lua and check if they are duplicated in the file


I have attached my Character Proflie file. Looks ok for me.
Attachments
characterprofiler.rar
(48.45 KiB) Downloaded 177 times
iradu
WR.net Apprentice
WR.net Apprentice
 
Posts: 9
Joined: Mon Aug 28, 2006 1:07 pm

Re: duplicate locations in the quests link

Postby iradu » Tue May 01, 2007 8:48 pm

in the file lib/quest.php I have changed
/*$query= "SELECT * FROM `".ROSTER_QUESTSTABLE."` WHERE `member_id` = '$member_id' ORDER BY 'quest_index' ASC";*/
(line 87)

with

$query= "SELECT * FROM `".ROSTER_QUESTSTABLE."` WHERE `member_id` = '$member_id' ORDER BY zone ASC";


and now it's looks ok. Could some1 from the dev dep confirm if it's ok?
Last edited by iradu on Tue May 01, 2007 8:49 pm, edited 1 time in total.
iradu
WR.net Apprentice
WR.net Apprentice
 
Posts: 9
Joined: Mon Aug 28, 2006 1:07 pm

duplicate locations in the quests link

Postby PleegWat » Tue May 01, 2007 9:19 pm

quest_index is the order they appear in in the quest log ingame. That's why you sometimes get a zone twice - The bug originates at blizz. Your fix works, but that means it's no longer in the ingame order, which may be confusing to ppl.

The order you put there is fine, but you probably want to add a second criterium:

ORDER BY `zone` ASC, `quest_index` ASC
ORDER BY `zone` ASC, `quest_name` ASC
ORDER BY `zone` ASC, `quest_level` DESC, `quest_name` ASC

etc. You get the drift.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: duplicate locations in the quests link

Postby iradu » Wed May 02, 2007 12:00 am

Hi again,


In fact the problem is with sql query.

If you replace ORDER BY 'quest_index' with ORDER BY quest_index, so just remove ' everything it's ok.
iradu
WR.net Apprentice
WR.net Apprentice
 
Posts: 9
Joined: Mon Aug 28, 2006 1:07 pm

duplicate locations in the quests link

Postby PleegWat » Wed May 02, 2007 1:33 am

Shouldn't matter. Either you've found a quirk in mysql or you updated your data in the meantime.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: duplicate locations in the quests link

Postby iradu » Wed May 02, 2007 2:16 pm

Hi again,

The problem is in the roster source. You should use ` not ' in sql query, so you should replace ORDER BY 'quest_index' with ORDER BY `quest_index`
iradu
WR.net Apprentice
WR.net Apprentice
 
Posts: 9
Joined: Mon Aug 28, 2006 1:07 pm

duplicate locations in the quests link

Postby PleegWat » Wed May 02, 2007 4:33 pm

ah, right. Didn't see correctly. Yeah it needs to be quoted with backticks or it won't do anything. Prolly never got noticed because you then get the order they are in the table, and they're usually inserted in order. Or noone ever complained.

Someone already fixed it for 1.8, it sorts on zone and level now.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: duplicate locations in the quests link

Postby iradu » Wed May 02, 2007 4:38 pm

lol

1.8 great. Major release. Do you have change log for this release? RC?
iradu
WR.net Apprentice
WR.net Apprentice
 
Posts: 9
Joined: Mon Aug 28, 2006 1:07 pm

duplicate locations in the quests link

Postby PleegWat » Wed May 02, 2007 5:18 pm

There's a whole lot of great stuff in 1.8. Zanix maintains a changelog in the wiki, http://www.wowroster.net/wiki/index.php ... Log#v1.8.0

We're still in the development phase, but I think we're slowly approaching the point where we might release a beta.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm


Return to General Support & Feedback

Who is online

Users browsing this forum: No registered users and 0 guests

cron