[BUG] max.resists + CharacterProfiler 1.6.3

Addon that shows the maximum statistics possible

Moderator: Exerladan

[BUG] max.resists + CharacterProfiler 1.6.3

Postby knappster » Thu Sep 28, 2006 6:19 pm

When I update my info with CharacterProfiler v1.6.3 (I didn't ever check with 1.6.2), the empty slots show as having a keyring in them. So whenever I click on a resistance for a character using that version of profiler, it shows keyrings in all of the empty slots. Is there a fix for that? I'm not 100% sure what version of max.resists I am using, but I can probably find out tonight.
knappster
WR.net Apprentice
WR.net Apprentice
 
Posts: 63
Joined: Fri Jul 21, 2006 11:12 pm

[BUG] max.resists + CharacterProfiler 1.6.3

Postby toldi » Thu Sep 28, 2006 6:48 pm

Whoa i even have this problem, and i just did debuging it atm.

What i do it:

OPEN maxres.php
Search at Line 19
Code: Select all
        $item = item_get( $this->data['member_id'], $item_name );
        if( isset($item) and $item != "" )
            $output = $item->out();
        else


REPLACE TO:
Code: Select all
   if ( $item_name != "") {
        $item = item_get( $this->data['member_id'], $item_name );
        if( isset($item) and $item != "" )
            $output = $item->out();
   }
        else


I Even have problem on line 597:
Code: Select all
       return date($phptimeformat[$roster_lang], $localtime);


I dunno where from the $phptimeformat[$roster_lang] variable, but that is Null, and the Last Updated text not showing correctly, showing nothing :) i have replaced to this:

Code: Select all
return date("Y-m-d H:i:s", $localtime);


*EDIT: i added to post my problem, and fixation.
Last edited by toldi on Thu Sep 28, 2006 6:55 pm, edited 3 times in total.
User avatar
toldi
WR.net Apprentice
WR.net Apprentice
 
Posts: 7
Joined: Wed Sep 27, 2006 4:29 pm

[BUG] max.resists + CharacterProfiler 1.6.3

Postby PleegWat » Thu Sep 28, 2006 7:19 pm

$phptimeformat is defined in the localization. It's probably not globaled for the addon call.

* checks

yup. Try $_GLOBALS['phptimeformat'][$roster_lang], that should work.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

[BUG] max.resists + CharacterProfiler 1.6.3

Postby AnthonyB » Fri Sep 29, 2006 2:22 am

Hmmm.. trying to fix the Last updated time.. replacing
Code: Select all
return date($phptimeformat[$roster_lang], $localtime);

with
Code: Select all
return date($_GLOBALS['phptimeformat'][$roster_lang], $localtime);

didn't work...
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Re: [BUG] max.resists + CharacterProfiler 1.6.3

Postby knappster » Fri Sep 29, 2006 7:35 am

Pleeg's fix didn't work for me either... but toldi's did.

I also added the line

Code: Select all
$localtimeoffset = -5


so that it would put my time in CST.
knappster
WR.net Apprentice
WR.net Apprentice
 
Posts: 63
Joined: Fri Jul 21, 2006 11:12 pm

Re: [BUG] max.resists + CharacterProfiler 1.6.3

Postby Diska » Fri Sep 29, 2006 2:58 pm

Thanks for reporting the bugs, but I'm afraid the fixes aren't okay.
The correct fixes are as following:

Replace:
Code: Select all
        global $img_url; // Added this global variable to use in the image link
        $item = item_get( $this->data['member_id'], $item_name );


with:

Code: Select all
        global $img_url; // Added this global variable to use in the image link
        if ( $item_name != "" )
                $item = item_get( $this->data['member_id'], $item_name );


and at line 596 replace:

Code: Select all
        $localtime = mktime($hour+$localtimeoffset,$minute, $second, $month, $day, $year, -1);
        return date($phptimeformat[$roster_lang], $localtime);


with

Code: Select all
        $localtime = mktime($hour+$roster_conf['localtimeoffset'] ,$minute, $second, $month, $day, $year, -1);
        return date($phptimeformat[$roster_conf['roster_lang']], $localtime);
Last edited by Diska on Fri Sep 29, 2006 3:04 pm, edited 1 time in total.
User avatar
Diska
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 179
Joined: Tue Jul 04, 2006 2:05 pm

Re: [BUG] max.resists + CharacterProfiler 1.6.3

Postby knappster » Fri Sep 29, 2006 10:07 pm

So the newest version available for download has all of these changes?
knappster
WR.net Apprentice
WR.net Apprentice
 
Posts: 63
Joined: Fri Jul 21, 2006 11:12 pm

[BUG] max.resists + CharacterProfiler 1.6.3

Postby Diska » Sat Sep 30, 2006 12:39 am

yes, it does
User avatar
Diska
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 179
Joined: Tue Jul 04, 2006 2:05 pm

[BUG] max.resists + CharacterProfiler 1.6.3

Postby AnthonyB » Sat Sep 30, 2006 8:50 am

Hi Diska,

While you're fixing and posting, could you make the following change which fixes issues in the current Roster betas where the trigger fails on some platforms:

trigger.php, line 31, replace

Code: Select all
require_once('../lib/item.php');


with

Code: Select all
require_once(ROSTER_LIB.'item.php');
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Re: [BUG] max.resists + CharacterProfiler 1.6.3

Postby Diska » Sat Sep 30, 2006 4:46 pm

AnthonyB wrote:While you're fixing and posting, could you make the following change which fixes issues in the current Roster betas where the trigger fails on some platforms:


Thanks! Fixed now and incorperated in 3.10
User avatar
Diska
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 179
Joined: Tue Jul 04, 2006 2:05 pm

Re: [BUG] max.resists + CharacterProfiler 1.6.3

Postby Speedtorch » Sun Oct 01, 2006 6:22 pm

I downloaded MaxResists 3.10 and I get the following error:

Warning: main(ROSTER_LIBitem.php) [function.main]: failed to open stream: No such file or directory in /homepages/24/d174628148/htdocs/_shadowguard/roster/addons/maxres/trigger.php on line 31

Fatal error: main() [function.require]: Failed opening required 'ROSTER_LIBitem.php' (include_path='.:/usr/local/lib/php') in /homepages/24/d174628148/htdocs/_shadowguard/roster/addons/maxres/trigger.php on line 31


So, I changed line 31 back to:

Code: Select all
require_once('../lib/item.php');


And all works fine. So, where is ROSTER_LIB being defined? I don't see it...
Speedtorch
WR.net Apprentice
WR.net Apprentice
 
Posts: 12
Joined: Wed Jul 12, 2006 3:08 am

[BUG] max.resists + CharacterProfiler 1.6.3

Postby PleegWat » Sun Oct 01, 2006 9:31 pm

In settings.php, starting 1.7.1
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

[BUG] max.resists + CharacterProfiler 1.6.3

Postby Subxero » Wed Oct 04, 2006 3:05 am

when can try these 1.7.1 ? arff arfff
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

[BUG] max.resists + CharacterProfiler 1.6.3

Postby PleegWat » Wed Oct 04, 2006 9:47 pm

You can't. It's in one of the last phases of beta testing, and the latest beta has been pushed to beta testers but also to addon developers. I suspect Diska forgot to test on 1.7.0 for this release.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

[BUG] max.resists + CharacterProfiler 1.6.3

Postby Nomad_Wanderer » Sat Oct 07, 2006 7:00 pm

Pleeg, you just broke this addon for everyone then
If I can't get 1.7.1, why make a change to max resists that requires 1.7.1?

require_once('../lib/item.php');

on line 31
is required in trigger.php to get this addon to work if you are running 1.7.0
Last edited by Nomad_Wanderer on Sat Oct 07, 2006 7:02 pm, edited 1 time in total.
Nomad_Wanderer
WR.net Apprentice
WR.net Apprentice
 
Posts: 7
Joined: Mon Jul 24, 2006 8:23 pm

Next

Return to Max Stats

Who is online

Users browsing this forum: No registered users and 1 guest

cron