Character Not Found after 1.7.0 -> 1.7.1

Requests, feedback, and general discussion about WoWRoster
DO NOT post topics about WoWRoster AddOns here!

Character Not Found after 1.7.0 -> 1.7.1

Postby RainRider » Thu Oct 26, 2006 7:16 am

Zanix, it doesn't work with or without changing the realmname back and forth.
RainRider
WR.net Apprentice
WR.net Apprentice
 
Posts: 50
Joined: Thu Jul 20, 2006 11:47 pm

Character Not Found after 1.7.0 -> 1.7.1

Postby RainRider » Thu Oct 26, 2006 7:53 am

Zanix you were right, it is because of magic_quotes_gpc being turned off. Turning only this on does the trick for me :)

I just wonder why it functioned without magic_quotes_gpc before

So the solution is:
1. Create a text file wiht the name htaccess.
2. Write the following line in it:
Code: Select all
php_flag magic_quotes_gpc on

3. Copy the file to the /roster-directory on your server
4. Rename the file to .htaccess

If you have access to php.ini set the flag there (no need for .htaccess in this case)

Zanix, thank you very much for this.
RainRider
WR.net Apprentice
WR.net Apprentice
 
Posts: 50
Joined: Thu Jul 20, 2006 11:47 pm

Character Not Found after 1.7.0 -> 1.7.1

Postby PleegWat » Thu Oct 26, 2006 2:48 pm

OK I've done a bit of checking, and I've got a possible fix. Locate this block in memberdetails.php:

Code: Select all
// Slash char name and server name
if( get_magic_quotes_gpc() )
{
    
$name stripslashes$name );
    
$server stripslashes$server_name_escape );


And remove the IF structure:

Code: Select all
    $name stripslashes$name );
    
$server stripslashes$server_name_escape ); 


<technobabble> There was a change in this version, the Settings.php now escapes all incoming variables if magic quotes if off. Char.php works with the stripped versions, so it strips it only if it's on. That means if magic quotes is on, the problem won't show up, but if it's off, the slashes aren't getting stripped and you get that error. </technobabble>
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Character Not Found after 1.7.0 -> 1.7.1

Postby silverscout » Thu Oct 26, 2006 4:38 pm

pleeg

// Slash char name and server name
$name = stripslashes($name);
$server = stripslashes($server_name_escape);

did the trick. Thanks
silverscout
WR.net Apprentice
WR.net Apprentice
 
Posts: 47
Joined: Tue Jul 04, 2006 2:47 pm

Character Not Found after 1.7.0 -> 1.7.1

Postby Snykx » Tue Oct 31, 2006 7:04 pm

So, whats the final verdict on this? Will that fix be released as a patch?
User avatar
Snykx
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 29
Joined: Wed Oct 18, 2006 10:09 am

Re: Character Not Found after 1.7.0 -> 1.7.1

Postby PleegWat » Tue Oct 31, 2006 9:24 pm

The fix works. I've attached a fixed file.

Zanix, if you read this, can you put the fix in the autopatcher?

EDIT: Whoops, .php doesn't work. Zipped it.
Attachments
memberdetails.zip
(2.4 KiB) Downloaded 52 times
Last edited by PleegWat on Tue Oct 31, 2006 9:25 pm, edited 1 time in total.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Character Not Found after 1.7.0 -> 1.7.1

Postby Snykx » Wed Nov 01, 2006 9:02 am

Nice find PleegWat. Thanks for that!
User avatar
Snykx
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 29
Joined: Wed Oct 18, 2006 10:09 am

Previous

Return to General Support & Feedback

Who is online

Users browsing this forum: No registered users and 0 guests

cron