Roster V1.7.2 beta items with +FR enchant not captured

by **ambisset** » Tue Dec 12, 2006 11:40 am

With Blizzard changing the way enchant tooltips are presented I have noted that max.resists is not correctly parsing the new tooltip.

eg:

["Tooltip"] = "Circlet of Prophecy Soulbound Head Cloth 94 Armor +17 Stamina +27 Intellect +20 Spirit +10 Fire Resistance |cffffffff+20 Fire Resistance|r Durability 59 / 60 Classes: Priest Requires Level 60 Equip: Increases damage and healing done by magical spells and effects by up to 12. Vestments of Prophecy (6/8) Boots of Prophecy Circlet of Prophecy Girdle of Prophecy Gloves of Prophecy Pants of Prophecy Mantle of Prophecy Robes of Prophecy Vambraces of Prophecy Set: -0.1 sec to the casting time of your Flash Heal spell. Set: Improves your spell critical strike rating by 28. (8) Set: Increases your chance of a critical hit with Prayer of Healing by 25%.",

note the |cffffffff+20 Fire Resistance|r 

In patch 1.12.2 the tooltip was captured as

["Tooltip"] = "Circlet of Prophecy Soulbound Head Cloth 83 Armor +17 Stamina +27 Intellect +20 Spirit +10 Fire Resistance +20 Fire Resistance Durability 60 / 60 Classes: Priest Requires Level 60 Equip: Increases damage and healing done by magical spells and effects by up to 12. Vestments of Prophecy (5/8) Boots of Prophecy Circlet of Prophecy Girdle of Prophecy Gloves of Prophecy Pants of Prophecy Mantle of Prophecy Robes of Prophecy Vambraces of Prophecy Set: -0.1 sec to the casting time of your Flash Heal spell. Set: Improves your chance to get a critical strike with Holy spells by 2%. (8) Set: Increases your chance of a critical hit with Prayer of Healing by 25%.",

note that this time its a plain +20 Fire Resistance 

I suspect this needs a change to the 4 lines starting CONVERT approx lines 372-375 in maxres.php

by **Exerladan** » Tue Dec 12, 2006 11:52 am

Try these modifications.

In fact I think it's due to "\n" (new line character) present in the original AddOn.

Theses modifications don't solve all problems, but I'm working on

by **ambisset** » Tue Dec 12, 2006 11:59 am

That has fixed the issue thanks. Thanks also for the very speedy reply.

A very minor point that you might wish to tidy up :

max.Fire Resistance Main Enchant Total
Circlet of Prophecy 10 20 30
Shroud of Infinite Wisdom 15 0 15

As you can see my head piece is now working fine. The back piece however shows 15 as main not as enchant (I did say it was a very minor point :-)

The tooltip captured was :

["Tooltip"] = "Shroud of Infinite Wisdom Soulbound Back 59 Armor +12 Stamina +14 Intellect +11 Spirit |cffffffff+15 Fire Resistance|r Classes: Priest Requires Level 60 Equip: Increases healing done by spells and effects by up to 24. Finery of Infinite Wisdom (2/3) Gavel of Infinite Wisdom Ring of Infinite Wisdom Shroud of Infinite Wisdom (3) Set: Increases the damage of your Shadow Word: Pain spell by 5%.",

by **Exerladan** » Tue Dec 12, 2006 12:10 pm

Yep I'm aware of this "little" problem :

The FR is parse only from the string and don't detect if it's an enchant or not

I have to find a way to detect if it's an enchant or not. May be with this captured value :
["Item"] = "item_number:enchant_number:0:0"

Anyway, I'm working on

by **ambisset** » Tue Dec 12, 2006 1:29 pm

Perhaps the new |cffffffffEnchant Details|r 

gives a way into this in that you have a fixed search string to search for that bounds the Enchant details.