frFR : pvp log sql update -> crash

Translation help and language issues

frFR : pvp log sql update -> crash

Postby aniodon » Tue Jan 02, 2007 10:16 pm

Hi,

I got this in my pvplog :


[5148] = {
["guild"] = "Clair de Lune",
["zone"] = "Vallée d'Alterac",
["subzone"] = "Donjon Loup-de-givre",
["enemy"] = 1,
["date"] = "12/28/06 02:23:38",
["name"] = "Elémentaire d'eau",
["lvlDiff"] = 0,
["honor"] = 0,
["win"] = 1,
["bg"] = 1,
["rank"] = "Sergent-chef",
}

The name Elémentaire d'eau made the update impossible (because of the "'".

Aniodon.
aniodon
WR.net Journeyman
WR.net Journeyman
 
Posts: 108
Joined: Mon Dec 18, 2006 8:09 pm

frFR : pvp log sql update -> crash

Postby zanix » Tue Jan 02, 2007 11:39 pm

Data is escaped on insertion into the database so this should not be a problem

Please give the exact error that occurs
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

frFR : pvp log sql update -> crash

Postby aniodon » Wed Jan 03, 2007 4:49 pm

It seems to be parsed ^^

I get :
Code: Select all
 PvPLog cannot update
1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'eau' AND `date` = '2006-12-28 2:23:38'' at line 1
 


PS : deleting the "'" character in the name field gives no error, update success.
aniodon
WR.net Journeyman
WR.net Journeyman
 
Posts: 108
Joined: Mon Dec 18, 2006 8:09 pm

frFR : pvp log sql update -> crash

Postby aniodon » Wed Jan 03, 2007 4:51 pm

Code: Select all
SELECT `guild` FROM `roster_pvp2` WHERE `index` = '5148' AND `member_id` = '82' AND `name` = 'Elémentaire d'eau' AND `date` = '2006-12-28 2:23:38'


in the sql query
aniodon
WR.net Journeyman
WR.net Journeyman
 
Posts: 108
Joined: Mon Dec 18, 2006 8:09 pm

frFR : pvp log sql update -> crash

Postby aniodon » Fri Jan 05, 2007 8:06 am

No idea ? :(

3 more guild mates cannot update because of this, /cry.
aniodon
WR.net Journeyman
WR.net Journeyman
 
Posts: 108
Joined: Mon Dec 18, 2006 8:09 pm

frFR : pvp log sql update -> crash

Postby Averen » Fri Jan 05, 2007 12:23 pm

In lib/wowdb.php in line 2058, change:

Code: Select all
            $playerName $playerInfo['name']; 


to

Code: Select all
            $playerName $this->escape($playerInfo['name']); 
Last edited by Averen on Fri Jan 05, 2007 12:24 pm, edited 1 time in total.
User avatar
Averen
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 152
Joined: Thu Jul 20, 2006 5:18 am

frFR : pvp log sql update -> crash

Postby aniodon » Fri Jan 05, 2007 12:29 pm

Thank you very much, will try it tonight
aniodon
WR.net Journeyman
WR.net Journeyman
 
Posts: 108
Joined: Mon Dec 18, 2006 8:09 pm

frFR : pvp log sql update -> crash

Postby aniodon » Fri Jan 05, 2007 2:43 pm

Works fine, thanks again.

Will this be fixed in next releases ? this may happen often on french server/localisation
aniodon
WR.net Journeyman
WR.net Journeyman
 
Posts: 108
Joined: Mon Dec 18, 2006 8:09 pm


Return to Languages / Localization

Who is online

Users browsing this forum: No registered users and 0 guests

cron