Bugs with patch 2.0.3

Categorizes items in your guildbank(s)

Moderator: Mathos

Bugs with patch 2.0.3

Postby trell » Sun Jan 14, 2007 4:19 pm

got a link to the roster page showing the problem?

-trell
trell
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 19
Joined: Wed Dec 06, 2006 4:11 pm
Location: UK

Re: Bugs with patch 2.0.3

Postby tholoc » Fri Jan 19, 2007 6:57 pm

trell wrote:got a link to the roster page showing the problem?

-trell


the link is here.

http://www.crematoria-gilde.de/pages/ht ... =guildbank

i think you can simulate the problem when you remove the "item=..."
line from one or two items in your characterprofiler.lua.

after upload you will have items with length(itemid) = 0
Last edited by tholoc on Fri Jan 19, 2007 7:00 pm, edited 1 time in total.
tholoc
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Sat Jan 13, 2007 8:28 pm

Re: Bugs with patch 2.0.3

Postby crazyinsane » Sat Jan 20, 2007 3:55 pm

Using latest CP and GP.

Wowroster fresh downloaded today, and patched via the file updates mentioned in previous links ... Roster Diag shows no files to update.

Using Catergorized Guild Bank , and receive the already mentioned :
Notice: Undefined offset: 1 in ....


Have checked the already mentioned SQL queries and see nothing that was mentioned ...

Catorized Guild Bank thread , says to check here , and the last page on that thread says to Check these forums ...

So Anyone actually have a valid working fix for this ?
crazyinsane
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Sat Jul 29, 2006 2:42 am

Bugs with patch 2.0.3

Postby crazyinsane » Sat Jan 20, 2007 4:18 pm

Temporarily fixed by deleting:

.':'.$itemid_array[1].':'.$itemid_array[2]

from gbank.php .

However, I found this fix in the http://www.wowroster.net/Forums/viewtopic/t=2289.html thread from someone stating the exact same thing that I'm about to, in that I am not sure that this is a valid fix for this issue.

It removes the symptom and everything appears to be working , but I don't code so I would still like to have this looked into if possible for a more proper fix if there is one .
crazyinsane
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Sat Jul 29, 2006 2:42 am

Bugs with patch 2.0.3

Postby trell » Sun Jan 21, 2007 12:18 am

Hi,
I've only done some quick testing of this, but the fix above leaves some broken links within the roster page itself, but does supress the error.

I think a better solution would be to skip that row in the database if it doesn't have a valid item id. I quickly tried this and it seems to work cleanly for me (I have even tested it and it seems ok).

On lines 246-247 of gbank.php you'll see the following:

Code: Select all

$itemid_array 
explode(':'$itemArrayRow['item_id']);
$real_itemid $itemid_array[0].':'.$itemid_array[1].':'.$itemid_array[2];
 


In between those lines add the following:

Code: Select all
if (! isset($itemid_array[2])) { continue; }
 


Thus, the code will now look like:

Code: Select all

$itemid_array 
explode(':'$itemArrayRow['item_id']);
if (! isset(
$itemid_array[2])) { continue; }
$real_itemid $itemid_array[0].':'.$itemid_array[1].':'.$itemid_array[2];
 


All this does is check to see if the 2nd array offset is valid (which it will be in a normal item id, and won't be if some corrupt data is in the database) and then skip the rest of the code that puts it into the various categories.

I've done rudimentary testing and it works fine here. G'luck.

-trell
trell
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 19
Joined: Wed Dec 06, 2006 4:11 pm
Location: UK

Previous

Return to Categorized Guild Bank

Who is online

Users browsing this forum: No registered users and 0 guests

cron