MadeBy version 1.7.3 Beta 3

Guild listing of known recipes

Moderator: ds

MadeBy version 1.7.3 Beta 3

Postby ds » Fri Mar 16, 2007 5:48 am

Hello,

Here is the first beta of MadeBy v1.7.3 *YAY*

Changes in this beta:
Version 1.7.3 Beta 1
Thursday March 15th 2007 9pm by ds
[ADDED] Multilanguage support
[ADDED] A "Language Bar" -- Can change the Language MadeBy displays in per user. (Will store in a session)
[ADDED] The administator can choose what languages to support!
[CHANGED] The configuration button will be hidden unless logged in as Admin (Login at the Main Roster Configuration)
[ADDED] MadeBy is now compatable with WoWRosterDF!
[NEW] MadeBy need to run on WoW Roster v1.7.3+ (or WoW RosterDF v1.7.3+) to work correctly!


Version 1.7.3 Beta 2
Friday March 16th 2007 by ds
[FIXED]Links and Forms for DF functions


Version 1.7.3 Beta 3
Friday March 16th 2007 by ds
[FIXED] Anchor links for DF


I do not run WoWRosterDF so I really need someone to test this out for me. It should work but testing is always good! :)

Give me your thoughts on the multi language support. This is my first thought for this type of support so I could very well change before release, depends on your feedback. :)

Also coming up soon is a revamped Sorting. Right now it sucks and I know this. :mrgreen:
Last edited by ds on Sat Mar 17, 2007 11:05 pm, edited 7 times in total.
Image
ds
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 297
Joined: Sat Jul 08, 2006 9:58 am

MadeBy version 1.7.3 Beta 1

Postby zanix » Fri Mar 16, 2007 8:02 am

Here are my tests on WoWRosterDF in DragonFly
LEO linking is on
http://www.drkalliance.com/wowrosterdf/ ... adeby.html

The install button doesn't point to the right url
Code: Select all
http://www.drkalliance.com/?roster_addon_name=madeby&action=install

Probably should be this
Code: Select all
http://www.drkalliance.com/wowrosterdf/addon/roster_addon_name=madeby/action=install.html



File: index.php
Line 88
Replace
Code: Select all
<a href="?roster_addon_name='.$_GET['roster_addon_name'].'&amp;action=install">Install</a>

With
Code: Select all
'.make_link('','Install',array('action'=>'install')).'



There are other places where this needs to be fixed as well
Since they are not used, it doesn't matter ATM
Line 93
Replace
Code: Select all
<a href="?roster_addon_name='.$_GET['roster_addon_name'].'&amp;action=upgrade">Update</a>

With
Code: Select all
'.make_link('','Upgrade',array('action'=>'upgrade')).'


Line 99
Replace
Code: Select all
<a href="?roster_addon_name='.$_GET['roster_addon_name'].'&amp;action=install">Reinstall</a>

With
Code: Select all
'.make_link('','Reinstall',array('action'=>'install')).'




Installation seems to work ok except the link to go to the config page

File: install.php
Line: 79
Replace
Code: Select all
"<a href='?roster_addon_name=madeby&action=config'>".$wordings[$roster_conf['roster_lang']]['MadeBy_Configure_txt']."</a>".

With
Code: Select all
make_link('',$wordings[$roster_conf['roster_lang']]['MadeBy_Configure_txt'],array('action'=>'config')).




Using the selection box also uses the wrong url
Code: Select all
http://www.drkalliance.com/addon.php?roster_addon_name=madeby&proffilter=Cooking&filterbox=


Code: Select all
<form action="addon.php"

Needs to be set correctly, I don't have any ideas for this one



All the character links are bad as well
Code: Select all
http://www.drkalliance.com/wowrosterdf/char.php/name=Zaryn/server=Doomhammer/action=recipes.html

The correct link would be
Code: Select all
http://www.drkalliance.com/wowrosterdf/char/cname=Zaryn/server=Doomhammer/action=recipes.html

I don't have any ideas for this either
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: MadeBy version 1.7.3 Beta 1

Postby ds » Fri Mar 16, 2007 9:20 am

What exactly does DF's getlink(); function do? Does it make the substitutions to make LEO links (ie, does it tack the .html at the end?). Maybe I should go and Install WoWRosterDF and check out the function. It would appear its more involved then I thought.

Thanks for the report. :)
Image
ds
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 297
Joined: Sat Jul 08, 2006 9:58 am

Re: MadeBy version 1.7.3 Beta 1

Postby ds » Sat Mar 17, 2007 3:02 am

Uploaded Beta 2 at the top of this thread. I fixed (I hope) the DF compatibility.




Version 1.7.3 Beta 2
Friday March 16th 2007 by ds
[FIXED]Links and Forms for DF functions
Image
ds
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 297
Joined: Sat Jul 08, 2006 9:58 am

MadeBy version 1.7.3 Beta 2

Postby zanix » Sat Mar 17, 2007 3:40 am

Code: Select all
function getlink($url=''$UseLEO=true$full=false)
{
    global 
$module_name$mainindex$MAIN_CFG$BASEHREF;
    if (empty(
$url) || $url[0] == '&'$url $module_name.$url;
    if (
$MAIN_CFG['global']['GoogleTap'] && $UseLEO) {
        
$url ereg_replace('&''/'$url);
        
$url ereg_replace('&''/'$url);
        
$url str_replace('?''/'$url);
        if (
ereg('/file='$url)) {
            
$url ereg_replace('/file=''/'$url);
        }
        if (
ereg('#'$url)) {
            
$url ereg_replace('#''.html#'$url);
        } else 
$url .= '.html';
    } else {
        
$url "$mainindex?name=".$url;
    }
    if (
$full$url $BASEHREF.$url;
    return 
$url;
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

MadeBy version 1.7.3 Beta 2

Postby jlaplaca » Sat Mar 17, 2007 6:21 am

The sub-catagorys need to be fix. For Each Profession.

In RecipeList.php
Lines 200-2003

Code: Select all
      
foreach($recipe_types as $type)
{
   $content .=  '<a href="#'.$type.'">'.$type.'</a> - '."\n";
}


But Nice.

I love that the developers are coding with cms in mind.
Last edited by jlaplaca on Sat Mar 17, 2007 6:22 am, edited 1 time in total.
Image
User avatar
jlaplaca
WR.net Apprentice
WR.net Apprentice
 
Posts: 18
Joined: Sun Feb 18, 2007 6:03 am
Location: Rocheser,NY

MadeBy version 1.7.3 Beta 3

Postby ds » Sat Mar 17, 2007 8:17 am

Thanks for the report Jlaplaca. I fixed the issue (i hope) in Beta 3. It is posted at the top of this thread.
Image
ds
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 297
Joined: Sat Jul 08, 2006 9:58 am

MadeBy version 1.7.3 Beta 3

Postby jlaplaca » Sat Mar 17, 2007 9:25 pm

I moved all problems to the Debug Posting, Please Sticky It

Thanks
Jlaplaca
Last edited by jlaplaca on Sat Mar 17, 2007 9:48 pm, edited 1 time in total.
Image
User avatar
jlaplaca
WR.net Apprentice
WR.net Apprentice
 
Posts: 18
Joined: Sun Feb 18, 2007 6:03 am
Location: Rocheser,NY


Return to Made By

Who is online

Users browsing this forum: No registered users and 0 guests

cron