niagairt wrote:

Kristoff22 wrote:

niagairt wrote:I guess my question would be, will this work woth WowRosterDF?

Not quite sure what WoWRosterDF is... link?

Its the version of WowRoster that works with the Dragonfly CMS.........

You can find it

here------http://www.wowroster.net/
here------http://www.wowroster.net/Downloads/c=9.html\

I want to aplogize for the lack of Signature.....my host is having a problem

Ahh ok, well I am just speculating here, because I have not worked with DF before, but you shouldn't have a problem with the addon in its current state. You may have a problem with the UI once I build a frontend to it, but we could certainly make a version for any CMS. But the meat of it should work just fine in theory.

Kristoff22 wrote:...........in theory.

Thats the part that ALWAYS gets me worried....LOL......as soon as my host gets my site back alive, I'll give it a shot and let you knpw

Just been trying it out a bit, but i've also got the error

Code: Select all

Fatal error: Call to a member function on a non-object in C:\Inetpub\vhosts\thesmoulderingforge.com\subdomains\roster\httpdocs\addons\ArmorySynch\functions.parsing.php on line 3

After printing around i think it might be because there's a space in our guildname, on armory there's a + instead of it.
I also had to change it to the armory to the one of europe

So just tested it out by replacing the space by a +, worked like a charm, but i think i messed up somewhere when updating guild as it was giving no xml root error.
Also noticed that players updated from armory their tier gear tooltips are messed up, or any item within a set, can see here

What i'd like to suggest also is, even while it's still beta, to add password thingy, so not every1 can click on the damn thing

You are correct PoloDude. I'm now urlencoding the realm name and the guild name. I'll be uploading an update after I run a final test.

I don't have password protection yet, but I did something just as effective... in a very hacktastic sort of way. When you go to the addon, simply append &Activate=true to your browsers URL bar. i.e. http://www.domainname.com/roster/addon. ... ivate=true

While that is hardly secure, it will keep the average user from poking around and crashing your web server...

So how would we go about getting it to convert the guild name to have an +?

str_replace would work

Use rawurlencode http://www.php.net/rawurlencode
Not on the whole url, just the guildname part

great code, works like a charm. I had a go with it yesterday and changed/added some things that might be useful for other people too (didn't post last night, page was in maintenence mode):

• urlencode of realm, guildname und charname, and armory.wow-europe.com (already mentioned, possibly add a config file that asks if the realm is US or EU, didnt get around to that yet).

• password protection: I just shamelessly copy&pasted the password protection from siggen since it asks for the admin password.

• optionally updating a single player:

Added following code into the index.php:

Code: Select all

if (isset($_REQUEST['syncplayer'])) {
  synchPlayer(null, $_REQUEST['syncplayer']);    
} else {
 ... password protection ...
 ... guild update ...
}
 

then added a icon before the player name like in this thread that points to addon.php?roster_addon_name=ArmorySynch&syncplayer=Playername Now players can sync single chars by themself, or I can sync the whole guild (Syncing single chars is preferred since guild snycing overwrites charprofiler uploaded data).

• Since we have around 280 members, grabbing the iteminfo for each char was resulting in a major performance hit. I replaced the second "getArmoryContent" call in the function "parseEquipment" with following code. It's of course not as nice as a real tooltip, but it's pretty close, and it saves you one http request per item. (if a member complains, he can always use charprofiler :p

Original Code
functions.parsing.php - around line 87

Code: Select all


    $item["Tooltip"] = getArmoryContent("item-tooltip.xml", "i=" . $equipmentItem->id . "&r=" . $player["Server"] . "&n=". $player["Name"] ."&lang=" . $player["Locale"], "table", false);
    $item["Tooltip"] = trim(str_replace("\n\n", "\n", str_replace("<br />", "\n", strip_tags(nl2br($item["Tooltip"]), "<br>"))));
 

Modified Code

Code: Select all


    //$item["Tooltip"] = getArmoryContent("item-tooltip.xml", "i=" . $equipmentItem->id . "&r=" . $player["Server"] . "&n=". $player["Name"] ."&lang=" . $player["Locale"], "table", false);
    //$item["Tooltip"] = trim(str_replace("\n\n", "\n", str_replace("<br />", "\n", strip_tags(nl2br($item["Tooltip"]), "<br>"))));
    $item["Tooltip"] = $item["Name"]."<br />\n";
    $spelltrigger[0]='Use: ';
    $spelltrigger[1]='Equip: ';
    $spelltrigger[2]='Chance on hit: ';
    foreach ($armoryItem->itemTooltip->properties as $key => $value) {
      if ($key > 7 ) {
        switch ($value) {
          case 'equipData':
            $tmpdata = $armoryItem->itemTooltip->$value->subclassName->_CDATA;
            if (trim($tmpdata) != '') $item["Tooltip"] .= ucfirst(strtolower($tmpdata))."<br />";
            break;
          case 'requiredLevel':
            $tmpdata = $armoryItem->itemTooltip->$value->_CDATA;
            if (trim($tmpdata) != '') $item["Tooltip"] .= 'Requires Level '.$tmpdata."<br />";
            break;
          case 'spellData':
            if (is_array($armoryItem->itemTooltip->spellData->spell)) {
              foreach ($armoryItem->itemTooltip->spellData->spell as $value) {                        
                $tmpdata = $value->desc->_CDATA;
                if (trim($tmpdata) != '') $item["Tooltip"] .= $spelltrigger[$value->trigger->_CDATA].$tmpdata."<br />";  
              }
            } else {
              $tmpdata = $armoryItem->itemTooltip->spellData->spell->desc->_CDATA;
              if (trim($tmpdata) != '') $item["Tooltip"] .= $spelltrigger[$armoryItem->itemTooltip->spellData->spell->trigger->_CDATA].$tmpdata."<br />";
            }
          break;              
          default:
            $tmpdata = $armoryItem->itemTooltip->$value->_CDATA;
            if (trim($tmpdata) != '') {
              if (strstr($value,'bonus')) { 
                $value = substr($value, 5);
              }
              if (trim($tmpdata) != '') $item["Tooltip"] .= '+'.$tmpdata.' '.  ucfirst(strtolower($value))."<br />";
            }
        }
      }
    }
 

It just takes the info and tries to make a nice tooltip out of it, would be shorter if the spelldata wasn't such a pain.

TODO: Enchants appear with two "+" as a prefix in the tooltips, didnt' get around to fixing that before I went to bed, can be easily checked and fixedwith a strstr()

Hope the posting was useful for someone. If anyone wants to have a look: http://www.sun-tzu.info/roster/

Edit: fixed indents in php code

Finally updated the codebase, sorry for the delay! The major changes are:

1. Instead of synching the guild list with Armory, which is out of date anyway, by default it grabs all of the names of the members in Roster and synchs them. This seems to work a lot smoother and less buggy.

2. Added urlencode to realm/guild name's when making callout to Armory.

3. Added very temporary authentication. Simply add &Activate=true to your URL. Directions and examples are in index.php.

Thanks to all who have helped!

Also DopeFish, thanks very much for the code snippets, I'll try to add them ASAP.

I'm not sure how exactly this could be implemented, but maybe it's an idea to send the armory requests earlier. EG send the request for items 1 and 2, process item 1 once it comes in, send request for item 3 when done with item 1, send request for item 4 when done with item 2, etc. This may decrease the runtime, since currently it's waiting for the armory response each time a page is requested.

DopeFish wrote:[*] password protection: I just shamelessly copy&pasted the password protection from siggen since it asks for the admin password.

Doing this will cause it to not work with WoWRosterDF........unless I am missing something

Siggen uses the roster login class for auth. That class is modified in the DF version to use DF auth instead. So it should work fine. Anyway siggen is compatible with DF unmodded, so the auth should be fine there anyway.

PleegWat wrote:Siggen uses the roster login class for auth. That class is modified in the DF version to use DF auth instead. So it should work fine. Anyway siggen is compatible with DF unmodded, so the auth should be fine there anyway.

I was having flashbacks when everyone was having the Password Issues......lol

OK, I installed this with WoWRosterDF.....worked ALMOST like a charm, but not quite......

While syncing, Internet Explorer timed out and I had to completly close IE and restart it before I could even get back to my main site.......(Honestly, I am not sure if this is and addon problem or an Internet Explorer problem)

I'll keep trying and see if I can trace the issue