Zul Gurub enchants dont count =/

Requests, feedback, and general discussion about WoWRoster
DO NOT post topics about WoWRoster AddOns here!

Zul Gurub enchants dont count =/

Postby Knuspar » Fri Jul 21, 2006 1:42 pm

When view the CHar Stats page, they ZG enchants arent counted anywhere.

IE, look at this :

http://www.ascendancy-guild.com/roster/ ... =character

You will notice, that i have a ZG enchant ( warlock noe +18 spell dmg +10 sta) on both legs/helm.

If you do a mouseover on "Equip: Increases damage and healing done by magical spells and effects by up to 331." in the bottom of the page, where i calcultes "Bonuses For Equipped Items" its not mentioned anywhere, neitehr is it listed as a seperate bonus, like the +30 Spell damage enchant is (Spell Damage +30).

I searched this forum, and dident find anyone else reporting this :/

Is this something you have planned on fixing, or did no one mention it yet? :)
Last edited by Knuspar on Fri Jul 21, 2006 1:44 pm, edited 1 time in total.
[url=http://wow.allakhazam.com/profile.html?1093422]Image
Click signature image for my Allakhazam profile[/url]
Or click here for my Roster profile
Knuspar
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Thu Jul 20, 2006 12:20 pm
Location: Denmark

Zul Gurub enchants dont count =/

Postby AnthonyB » Fri Jul 21, 2006 4:45 pm

Yes, you are right.

Unfortunately the way that tooltip is constructed, and in particular the line "Healing and Spell Damage +18/Stamina +10" is different to all others and breaks all the existing parsing rules...

It's going to take someone with better regex skills that I to fix.

If someone wants to take a shot the relevant code can be found in /lib/char.php (function sortOutTooltip) and the search strings are in the localization files (/localization/enUS.php) under the header "// Definition for item tooltip coloring"
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Re: Zul Gurub enchants dont count =/

Postby Knuspar » Fri Jul 21, 2006 4:53 pm

Im assuming this means that my +10 stamina from each ZG enchat arent calculated as well?
Last edited by Knuspar on Fri Jul 21, 2006 4:53 pm, edited 1 time in total.
[url=http://wow.allakhazam.com/profile.html?1093422]Image
Click signature image for my Allakhazam profile[/url]
Or click here for my Roster profile
Knuspar
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Thu Jul 20, 2006 12:20 pm
Location: Denmark

Re: Zul Gurub enchants dont count =/

Postby AnthonyB » Fri Jul 21, 2006 4:57 pm

Knuspar wrote:Im assuming this means that my +10 stamina from each ZG enchat arent calculated as well?


Yes... and no. We don't calc base skill (stam, int, spi, ag, etc.) bonuses anyway.
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Zul Gurub enchants dont count =/

Postby truehorn » Fri Jul 21, 2006 10:38 pm

+ healing to gloves and + healing to bracers don't seem to work either.
truehorn
WR.net Apprentice
WR.net Apprentice
 
Posts: 1
Joined: Fri Jul 21, 2006 9:00 pm

Zul Gurub enchants dont count =/

Postby lechef » Thu Aug 10, 2006 5:21 pm

Yep, same problem here.

As you can see, Spellpower-Enchantments to Gloves (whereas it works on the weapon) and the ZG-Enchants aren't counted:
http://gol.flausse.de/char.php?name=Raya&server=Lothar
lechef
WR.net Apprentice
WR.net Apprentice
 
Posts: 1
Joined: Mon Aug 07, 2006 7:50 pm

Zul Gurub enchants dont count =/

Postby Cappadozius » Tue Sep 12, 2006 8:12 pm

It all adds up a bit to this topic what I checked today.

Indeed with the current CharProfiler version I get the entry for the ZG enchantment on my T2 helmet. However what I found out is that the following are for whatever reasons not taken into consideration:

- ZG shoulder enchantment
- +30 Spelldamage on a weapon
Cappadozius
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Mon Jul 31, 2006 9:10 pm

Re: Zul Gurub enchants dont count =/

Postby sturmy » Tue Sep 12, 2006 8:42 pm

Having ventured in that part of the code for the sake of the FR translation, here's my understanding. The "rules" for adding is that it must match "equip: TEXT", as such, the ZG enchants and all the other reported lines are indeed not adding up as they use a different wording.

I assume that a "minor" fix can take care of that, by looking for the "ZG pattern" in the parsing and adding to the normal one. An ugly hack, but the result would be there.

There is indeed no parsing made to check on stats addition in the Bonus Scanner part.

Hope this helps...
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm


Return to General Support & Feedback

Who is online

Users browsing this forum: No registered users and 1 guest

cron