Colored Tooltip in Instance Keys - and another issues

Posts from previous Beta sessions

Colored Tooltip in Instance Keys - and another issues

Postby tuigii » Mon Aug 27, 2007 2:07 am

File : addons/keys/guild/index.php

The tooltip won't show the green (finished) - yellow (actual) - red (unfinished) colored tooltips lines.
Al the lines are grey.

Search for the sequence color:#
Replac by color:

Why : the # sign is already included in the
$addon['config']['colorcmp']
$addon['config']['colorcur']
$addon['config']['colorno']
values.

Result : http://www.papy-team.fr/roster_20b1/ind ... ys&guild=1 : now it works.

Rest to do (look on the same page) : the character Nowwhat has completed the first 3 steps for it's acces UBRS.
As shown here in the 1.7.3 Roster : http://www.papy-team.fr/roster/indexinst.php (same Guild - fed with the same CP.lua).
Or : nothing shows up in the beta roster (I'm at step/item 3 - need to get the final, third gemme yet;-)).
Note that my FRfr.lua file (the UBRS part) is the same as one used in the 1.7.3 roster.

[edit]

I changed this 'new' line (in compared to memberinst.php = 1.7.3)
line 262 (appr.)
Code: Select all
  if( !isset($items[$key]) ) { continue; }
  list($junk,$milestone) = explode('|',$items[$key][$step]);


UBRS show up well now when a player hasn't finished all the steps.

[post edited and corrected - after findings on next posts here after]
Last edited by tuigii on Tue Aug 28, 2007 2:13 am, edited 4 times in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Colored Tooltip in Instance Keys - and another issues

Postby zanix » Mon Aug 27, 2007 3:30 am

It was to eliminate a notice error I think
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5546
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Colored Tooltip in Instance Keys - and another issues

Postby Byrillicus » Mon Aug 27, 2007 11:11 pm

Well, taking that one line out did nothing but add more errors to the long list of them I have on the keys page, so I added it back in. I see at the bottom of tuigii's page, he now has the errors I once had. When I take that line out, I get the same errors added to the bottom of the list I have now. Also, I have no colors on the key quests with or without the line.

Keys
Byrillicus
WR.net Apprentice
WR.net Apprentice
 
Posts: 32
Joined: Wed Jul 26, 2006 12:36 am
Location: Atlanta, GA

Colored Tooltip in Instance Keys - and another issues

Postby zanix » Mon Aug 27, 2007 11:55 pm

Maybe we should just replace this with Keys_BC :)
Except that we add the keys from the base version into it
(Maybe a tab interface to switch from Azeroth to Outlands?)
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5546
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Colored Tooltip in Instance Keys - and another issues

Postby tuigii » Tue Aug 28, 2007 1:13 am

Byrillicus wrote:Well, taking that one line out did nothing but add more errors to the long list of them I have on the keys page, so I added it back in. I see at the bottom of tuigii's page, he now has the errors I once had. When I take that line out, I get the same errors added to the bottom of the list I have now.

What you show here : Keys, I don't have that at my roster : Papy team => Keys BC

I'll have a look at these 'line 263' errors.
[edit]
This
Code: Select all

    
if( !isset($items[$key]) ) { continue; }
    list(
$junk,$milestone) = explode('|',$items[$key][$step]); 

gives NO errors, and everythings shows up now.
the isset logic is inverted with a '|'.
Next, one '|' is removed in the next line, because there is only one present in $items[$key][$step].

It works well now. Line 263 errors are dead.

Byrillicus wrote:Also, I have no colors on the key quests with or without the line.

The last 'line issue' has nothing to to with the missing colors.
Reread this
tuigii wrote:Search for the sequence color:#
Replac by color:

Five times.
Colors came up afterwards.
Last edited by tuigii on Tue Aug 28, 2007 1:59 am, edited 4 times in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Colored Tooltip in Instance Keys - and another issues

Postby zanix » Tue Aug 28, 2007 2:11 am

I added these fixes to the svn
Thanks for investigating it

Fixed svn[1290]
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5546
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Colored Tooltip in Instance Keys - and another issues

Postby Byrillicus » Tue Aug 28, 2007 2:05 pm

Geez.. sorry about that. I totally missed that you said to replace those color:#

However, I'm still getting those Notice Line errors.
Byrillicus
WR.net Apprentice
WR.net Apprentice
 
Posts: 32
Joined: Wed Jul 26, 2006 12:36 am
Location: Atlanta, GA

Re: Colored Tooltip in Instance Keys - and another issues

Postby Wyren » Sat Sep 01, 2007 11:41 pm

zanix wrote:Maybe we should just replace this with Keys_BC :)
Except that we add the keys from the base version into it
(Maybe a tab interface to switch from Azeroth to Outlands?)


Just a drop-down menu to select between Azeroth and Outland keys would be sufficient imho. Saw someone had done that on 1.7.3, but damned if I can remember who that was :)
Wyren
WR.net Journeyman
WR.net Journeyman
 
Posts: 81
Joined: Wed Jul 26, 2006 3:07 pm

Re: Colored Tooltip in Instance Keys - and another issues

Postby tuigii » Sun Sep 02, 2007 2:49 am

Wyren wrote:...
Saw someone had done that on 1.7.3, but damned if I can remember who that was :)

Don't bother.
Even if you locate him, he has to be brain washed first to adapt this 'patch' to V2... because the underlying interface for Add On country changed completely.

Prepare yourself seeing a third button when King Wrath comes out :wink:
Last edited by tuigii on Sun Sep 02, 2007 2:51 am, edited 1 time in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Colored Tooltip in Instance Keys - and another issues

Postby PleegWat » Sun Sep 02, 2007 4:14 am

There is enough underlying support to create an addon-specific toolbar. You'd have to add the entry in the roster_menu table manually, then add buttons to it (which could be done with the special function for it).
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm


Return to Archived

Who is online

Users browsing this forum: No registered users and 1 guest

cron