Cannot seem to sort the Member Log properly.

I am getting PHP errors. As seen.

Roster 2 - Memberlog

Any Ideas?


Edit: Seems to be a problem in sorting various areas. Character list as well. Maybe others.

Might be an upload error
That missing index is member id and that should never happen

Nope, it's a bug alright. I caused it when I fixed sorting on pages with mixed mains/alts. Fixed in 1333.

PleegWat wrote:Nope, it's a bug alright. I caused it when I fixed sorting on pages with mixed mains/alts. Fixed in 1333.

Hmm, That would probably be it. I was getting a little worried. Thought I might have to wipe the database.

One of the main disadvantages about using this type of Beta. But we knew that before going into it. Keep up the good work.

shaun.voysey wrote:

PleegWat wrote:Hmm, That would probably be it. I was getting a little worried. Thought I might have to wipe the database.

You can just empty it. This table is related to any other one.
You just lose the "who came in when and left when" history.

It isn't specifically related to the memberlog table. It also affects /realm/memberslist/guild.html. It's an engine bug.

You're talking sorting the tables 'by hand' ?

True is that's more logic to keep the latest that came in and went out up on top of the list. Never managed to make that work.

The sort-option : does it work ? I'm using IE7 or Firefox : no results when I click the Go button.
Sorting by server isn't logic here - this table should gave it's own setting, in stead of depending on the main memberlist views.
Having it sorted by hand every time when one view this list isn't logic neither.

True is, this table is more for the guild managers - and maybe not visited often.

The memberlog in Roster2 is based on the same table display/sorting engine as the memberslist. There's just a different data query behind it.

The problem with IE (and opera) was noticed by someone else too (in a very unclear post). It was caused by me using a java function that is only supported in firefox, without noticing.

This bug was fixed in 1330

PleegWat wrote:This bug was fixed in 1330

I stand corrected... With Firefox, sorting IS already done well right now.

I'm using 1329 - so, soon, server (client ?) sorting will work fine for "other browsers" as well.

I decided to play with the $lang['timeformat'] (line 151 in localization/frFR.php)

Assigning something like this:

Code: Select all

$lang['timeformat'] = '%W, %d %M %Y, %l:%i'; 

did yield me English names for months and days, like Saturday, 25 August 2007, 12:36
This is normal, because when I asked my mySQL directly what language it speaks natively:

Code: Select all

SELECT @@lc_time_names;

It responded:

Code: Select all

en_US

This is nasty.
mySQL isn't informed that in France everything should be in French, otherwise yet another 'USA' debate will be started

The language has to be set after logging in and before selecting the data base, so, I went straight to lib/dbal/mysql.php, line 102, and after this:

Code: Select all

        mysql_query("SET NAMES 'utf8'");
        mysql_query("SET CHARACTER SET 'utf8'"); 

I put this

Code: Select all

        mysql_query("SET lc_time_names = 'fr_FR'"); 

Now, my dates and time stuff is all French, like this:
samedi, 25 août 2007, 12:36 - respecting the timeformat to the letter.

I know, this is a hard coded patch, deep down in the constructor where db access is made. Languages things aren't know there.

I understand also that a mere 25/08/2007, 12:36 (as it is right now) is more easily, but maybe I just didn't saw a cleaner possibility of implementing this. (but I doubt).
Going from esES to es_ES, frFR to fr_FR, usUS to us_US and deDE to de_DE should be one big 'if select case' somewhere.

Surely, this is not a hot item, and more a feature. But hey, were in beta time, everything should be mentioned and discussed

PS : I just asked the guy that ‘knows about this stuff’ at my hoster (www.ovh.com – quit a big guy in this business).
He said: “for compatibility reasons – its better for us when defaulting to us_US – all good soft is English (SQL) speaking anyway (…..). Otherwise all hell breaks loose when we make to much stuff ‘local’….)
Translated: do it yourself! As stated above.

I'll take a dive in. From the back of my head, I'm not sure if the locale files are loaded yet at that point. If they are, we could just have an init_sql section in there or something.

Svn[1337]

Member log still does not sort properly when selecting Level and Date from the Header titles.

Roster 2 - Memberlog

Though the default sort seems to work when calling the page. Could it be an SQL call problem?

Was about to say : Yippie : it works !!
Papy team - roster - V2
When called, the default memberlist sort (mine is by Title) is used.
Complely non-logic, so, when I click Client Sorting (the button changes to Server Sorting) (and, oh, my dear, I'm using IE7 here ) - I click twice sur the Date colum, then .....
YES : sorted on date, latest incoming/outgoing Guildies are on top !! YES !

Thanks, Pleegwat, well done !!

Please note that "Server sorting" has be shown, otherwise clicking on the colums yields some kind of 'random sorting' ...... I really can find out on what it sorts - whatever colum I use.
Is this what you mean, shaun.voysey ?

One note, if "server sorting" is shown, we are in client sorting mode, and the other way around. Maybe it is clearer if I always show both, and show the inactive one as a link.

Only client sorting has configurable multisorting and filtering. Server sorting only sorts on the column you click and some default sortings.

tuigii wrote:Please note that "Server sorting" has be shown, otherwise clicking on the colums yields some kind of 'random sorting' ...... I really can find out on what it sorts - whatever colum I use.
Is this what you mean, shaun.voysey ?

I'm using the Server sorting, So Client sorting is shown. The other coulmns seem to work fine,. Just Date and Level are the culprits.

Client sorting Works ok.

Confirmed for the level, and fixed. I'm not sure what was wrong with the date, but I changed it a bit and it should be fixed too. SVN 1343.