ArmorySync 2.6 beta svn[234] for Roster 2.0 Beta

Sync Blizzards' Armory data with WoWRoster (addon depreciated no longer works see ApiSync)

Moderators: Ulminia, poetter

ArmorySync 2.6 beta svn[234] for Roster 2.0 Beta

Postby poetter » Sun Sep 16, 2007 7:09 am

ArmorySync 2.6 beta svn[234] for Roster 2.0 Beta


Hi all,

attached you find the new Version of ArmorySync for Roster 2.0 Beta >= svn[1329].

After a long code rewrite an adding feature to it, i now need your help in translating and testing it.

Some words about ArmorySync:

What does it?

- It still syncs your characters with Blizzards Armory. It will do that for single chars, for the whole guild and for all chars on the same realm.
- It syncronises your guild memberlist.
- As of that you will find four buttons in the menu. First in the character menu, second and third in the guild menu and last but not least the fourth in the realm menu.

What you need to know?

- It only works with Roster 2.0 beta.
- Right now it needs a version of armory.class.php that is not downloadable yet ( i put it in the archive ). Not needed anymore
- Translations for ES and FR need to be done. This ist not optional! ArmorySync will not function without doing this translations. The terms for bindings, RepStanding, Skills, Classes and Talenttrees need to be replaced with the exact spelling of the armory to work.

What are known issues?

- ArmorySync right now does not work well with the itemparser. As of that some lines in all items are not parsed correctly. ( hope ds will help on that ). If you are botherd of the debug messages, go and find the switch to turn it off ;-)

What was tested yet?

- German locales, of cause with two guilds and about 160 characters.
- English locales with a british guild with about 105 characters.

What needs to be tested?

- French and spanish locales.
- English locales with an US server.
- Overall functionality

So please help testing. Post you locales, bugs, experience or just praise me :oops:

cu
poetter

Changes:
svn[234]
- fixed typo with false in armorysync.class.php line 727
- added cleanup for aborted jobs older than 3 hours
- fixed whitespaces and "Undead" in raceEN
- added frFR locales - thx again to tuigii

svn[233]
- added different locales to enUS frFR and esES

svn[232]
- added more _checkContent
- added credits to enUS, esES and frFR
- brought all code logic from index.php's, memberlist.php and guildadd.php back to armorysyncjob.class.php
- fixed unurldecoded strings in guildadd
- added config options for diffrent access levels
- added start page before syncing
- added pugro to credits

svn[230]
- added armory fetch timeout to config
- added credits to footer

svn[228]
- fixed makelink again
- implemented content check
- switched output to template based
- changed log of memberlist update to overlib

svn[226]
- fixed makelink problem

svn[225]
- fixed max value of class skills poison and lockpicking
- replaced all url's with a makelink() created one
- replaced mb_convert_encoding with a more compatible workaround
- Added ClassEn, RaceEn and Power to CharacterInfos
- changed to use faction reputation from the base locales
- played more with templates. started to code armporysyncjob.show_status with templates (not activated yet)

svn[224]
- changed function _getLocalisedTime to not use DateTime / thx to Subxero@wowroster.net
- replaced all $_REQUEST with $roster->data where possible and $_GET where not

svn[223]
- added urldecode to $_POST variables / thx to Subxero@wowroster.net
- added frensh locales / thx to tuigii@wowroster.net
- added standard rank texts to guild sync
- fetch guild_rank and guild_title from db as workaround for memberlist update hook
- started playing with templates and added a simple footer
- fixed shaman_talenticons.php / thx to tuigii@wowroster.net

svn[222]
- Added new feature for adding a new guild and sync memberlist in util section

svn[221]
- fixed realm syncing

svn[220]
- changed case of all files to lowercase
- fixed some enUS locales

svn[207]
- fixed error in sql statement line 511 ArmorySyncJob.class.php

svn[206]
- moved repository to wowroster.net/svn/rost...armorysync new revision

svn[716]
- added meberlist.php to archive

svn[714]
- fixed case problem in ArmorySync.class.php
Last edited by poetter on Wed Oct 24, 2007 7:00 am, edited 16 times in total.
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

ArmorySync 2.6 beta svn[713] for Roster 2.0 Beta

Postby zanix » Sun Sep 16, 2007 8:09 am

Good work
This will surely be given a full workout by myself soon

I also have to ask, can it populate a guild list if it hasn't been uploaded by CP.lua yet? I know this feature was missing in the 1.7.x version of Armory Sync

Also, we do have an svn here on wowroster.net you can use
Check the info out here - http://www.wowroster.net/SVNergy.html
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: ArmorySync 2.6 beta svn[713] for Roster 2.0 Beta

Postby poetter » Sun Sep 16, 2007 8:17 am

Inserting a new guild without cp.lua should't be a problem. You only need guildname, and locale and server to add it. need just to build an form to initialy add it. this method will lack some nice infos you get from cp.lua.

i was asking ds in which repository i should put armorysync? As you use roster1 for 2 beta, he was unsure about the addon rep. 1 or 2?

And yes, go ahead, take a look. your from idaho? nice. my first US tester :D
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

ArmorySync 2.6 beta svn[713] for Roster 2.0 Beta

Postby boyo » Sun Sep 16, 2007 8:42 am

I installed this on a linux server, and the reason I mention it as linux is this problem isnt related to windows, but when I ran the first option, I get
Code: Select all

Fatal error: ArmorySync::require_once() [function.require]: Failed opening required 'SNIP/addons/armorysync/inc/talentIcons_Rogue.php'
 (include_path='.:/usr/lib/php:/usr/local/lib/php') in
SNIP/addons/armorysync/inc/ArmorySync.class.php on line 623


I had to go in and rename every file in /inc/ that starts with talentIcons_*.php to make it case sensitive, ex: talentIcons_Rogue.php.
I may be mistaken, but I believe the coding standards said to use all lowercase file names. However, and I'm just assuming here because I havent torn deep into the code, but I'm assuming that your getting the class name from somewhere that is coded as "Rogue" and not "rogue".

Simple fix would be to convert it to lowercase before returning it.
I tried to do this in ArmorySyncTalents.class.php on line 73
Code: Select all
$content = str_replace('talentPath', '$talentPath', strtolower($content) );

however, it failed with an eval() error.

Edit to add:
After having this running for a second, I really like how it just keeps reloading to process more.

I am however recieving
PHP Errorsaddons/armorysync/inc/ArmorySync.class.php
Notice line 642: Undefined index:
Notice line 642: Undefined index:

over and over again on every load.
Last edited by boyo on Sun Sep 16, 2007 8:46 am, edited 2 times in total.
boyo
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 103
Joined: Wed Jan 24, 2007 7:37 am

ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby poetter » Sun Sep 16, 2007 9:02 am

Yes you are right. There was a case problem in ArmorySync.class.php. I fixed that(see first post).

And no, please leave ArmorySyncTalents.class.php untouched. Your changes lead to that eval() error. There I grab some javascript from blizz servers and str_replace it to php code, so that i can eval it.

if you still got eval errors with svn[714] i'm interrested in your cp.lua. Would you pm me?
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Re: ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby joehail » Sun Sep 16, 2007 9:12 am

US Server
this is the error I get
Code: Select all
Fatal error: Cannot instantiate non-existent class: datetime in /home/www/ecs-guild.com/roster2/addons/armorysync/inc/ArmorySyncJob.class.php on line 411


hope this helps.
Image
User avatar
joehail
WR.net Journeyman
WR.net Journeyman
 
Posts: 103
Joined: Tue Jul 04, 2006 4:54 pm
Location: Cincinnati, Ohio USA

ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby zanix » Sun Sep 16, 2007 9:16 am

Use the roster1_addons repository as no-one but the devs has access to roster2_addons, and will probably be renamed someday

Yes, my location is correct. Pocatello ID USA

boyo is right, the coding standards specify that all filenames should be lowercase

But if that is un-avoidable, then I suppose it's ok
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby boyo » Sun Sep 16, 2007 9:21 am

poetter wrote:Yes you are right. There was a case problem in ArmorySync.class.php. I fixed that(see first post).

And no, please leave ArmorySyncTalents.class.php untouched. Your changes lead to that eval() error. There I grab some javascript from blizz servers and str_replace it to php code, so that i can eval it.

if you still got eval errors with svn[714] i'm interrested in your cp.lua. Would you pm me?


Ok, I guess I should have specified that I was using svn713 at the time. We must have just crossed paths when I got the error, going to upload 714 and see what I get.
boyo
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 103
Joined: Wed Jan 24, 2007 7:37 am

Re: ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby poetter » Sun Sep 16, 2007 9:22 am

joehail wrote:US Server
this is the error I get
Code: Select all
Fatal error: Cannot instantiate non-existent class: datetime in /home/www/ecs-guild.com/roster2/addons/armorysync/inc/ArmorySyncJob.class.php on line 411


hope this helps.


Your php seems to be old. DateTime was introduced with 5.1.0.

That what i need to do:
Code: Select all
    function _getLocalisedTime ( $time = false ) {
        global $roster;
       
        $offset = $roster->config['localtimeoffset'];
        $date = new DateTime($time);
        $date->modify("+". $offset. " hour");
        $ret = $date->format("d.m H:i:s");
        return $ret;
    }


If someone knows another method working with older php versions i will change that.
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Re: ArmorySync 2.6 beta svn[713] for Roster 2.0 Beta

Postby tuigii » Sun Sep 16, 2007 9:23 am

boyo wrote:I installed this on a linux server, and the reason I mention it as linux is this problem isnt related to windows, but when I ran the first option, I get
Code: Select all

Fatal error: ArmorySync::require_once() [function.require]: Failed opening required 'SNIP/addons/armorysync/inc/talentIcons_Rogue.php'
 (include_path='.:/usr/lib/php:/usr/local/lib/php') in
SNIP/addons/armorysync/inc/ArmorySync.class.php on line 623


I had to go in and rename every file in /inc/ that starts with talentIcons_*.php to make it case sensitive, ex: talentIcons_Rogue.php.
...


Your guys are fast.

Just downloaded it a couple of minutes ago, and, of course, saw the same error.

I didn't rename the file.
Just have a look over here : ArmorySync.class.php - line 615:
Code: Select all
            $dl_class = $this->_getDelocalisedClass($this->data["Class"]);
            $class = strtolower($dl_class);
            $locale = $roster->config['locale'];
           
            require_once ($addon['dir'] . 'inc/ArmorySyncTalents.class.php');
            $ast = new ArmorySyncTalents();
            $talents = $ast->getTalents(  $class );

            require_once ($addon['dir'] . 'inc/talentIcons_'. $class. '.php');

The second line gives the answer : instead of using $dl_class, you should use $class in the last line - function call require_once(.....
So:
Code: Select all
require_once ($addon['dir'] . 'inc/talentIcons_'$dl_class'.php'); 

becomes
Code: Select all
require_once ($addon['dir'] . 'inc/talentIcons_'$class'.php'); 

Amazing, I use a French roster - and it started parsing right away after that :D GG !! :D

After parsing : WTF : look at my roster 'V2' : it's loaded - al updated : mega lol ! Papy team

I'll dive into french translation.

BTW : while parsing, have php errors about ranking : function :: function char_post($chars) in update_hook.php about 'Rank' not being defined.
This might as well being a language thing.

And yes, the item parser goes wacko afterwards... :wink:
Last edited by tuigii on Sun Sep 16, 2007 9:38 am, edited 1 time in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby poetter » Sun Sep 16, 2007 9:25 am

zanix wrote:Use the roster1_addons repository as no-one but the devs has access to roster2_addons, and will probably be renamed someday

Yes, my location is correct. Pocatello ID USA

boyo is right, the coding standards specify that all filenames should be lowercase

But if that is un-avoidable, then I suppose it's ok


no problem. i will change all files to lowercase and up a new version.
rep is fine. i will add a new dir there
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby boyo » Sun Sep 16, 2007 9:30 am

Ok, at first I uploaded 714 and it did the same thing to me, so before I said something, I completely deleted the addons/armorysync folder and reuploaded it. That fixed it, might have been cached or something, I'm not sure, but it's running now.

One other small note, in /armorysync/locale/enUS.php line 106 should read
$lang['finished'] = "finished";
instead of
$lang['finished'] = "finnished";

Edit: After taking a second look at the file, I noticed a couple small things in it. I can correct them and send you the updated file if you wish.

Also, I am having a problem accessing Armory Memberlist Sync. It says,
Code: Select all
Roster Error
The module [guild-armorysync-memberlist] does not exist
Last edited by boyo on Sun Sep 16, 2007 9:33 am, edited 1 time in total.
boyo
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 103
Joined: Wed Jan 24, 2007 7:37 am

ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby zanix » Sun Sep 16, 2007 9:34 am

Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: ArmorySync 2.6 beta svn[713] for Roster 2.0 Beta

Postby tuigii » Sun Sep 16, 2007 9:34 am

tuigii wrote:
boyo wrote:I installed this on a linux server, and the reason I mention it as linux is this problem isnt related to windows, but when I ran the first option, I get
Code: Select all

Fatal error: ArmorySync::require_once() [function.require]: Failed opening required 'SNIP/addons/armorysync/inc/talentIcons_Rogue.php'
 (include_path='.:/usr/lib/php:/usr/local/lib/php') in
SNIP/addons/armorysync/inc/ArmorySync.class.php on line 623


I had to go in and rename every file in /inc/ that starts with talentIcons_*.php to make it case sensitive, ex: talentIcons_Rogue.php.
...


Your guys are fast.

Just downloaded it a couple of minutes ago, and, of course, saw the same error.

I didn't rename the file.
Just have a look over here : ArmorySync.class.php - line 615:
Code: Select all
$dl_class $this->_getDelocalisedClass($this->data['Class']);
$class strtolower($dl_class);
$locale $roster->config['locale'];
require_once (
$addon['dir'] . 'inc/ArmorySyncTalents.class.php');
$ast = new ArmorySyncTalents();
$talents $ast->getTalents(  $class );
... 

The second line gives the answer : instead of using $dl_class, you should use $class in the last line - function call require_once(.....
So:
Code: Select all
require_once ($addon['dir'] . 'inc/talentIcons_'$dl_class'.php'); 

becomes
Code: Select all
require_once ($addon['dir'] . 'inc/talentIcons_'$class'.php');
 

Amazing, I use a French roster - and it started parsing right away after that :D GG !! :D

After parsing : WTF : look at my roster 'V2' : it's loaded - al updated : mega lol ! Papy team

I'll dive into french translation.

BTW : while parsing, have php errors about ranking : function :: function char_post($chars) in update_hook.php about 'Rank' not being defined.
This might as well being a language thing.

And yes, the item parser goes wacko afterwards... :wink:
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

ArmorySync 2.6 beta svn[714] for Roster 2.0 Beta

Postby poetter » Sun Sep 16, 2007 9:34 am

@tuigii

youre right with the code change. allready fixed that in svn[714]. Cant wait to here if its working in french to. need more infos for that rank error.

i can't realy debug without french locales. so i be patient till your finnished.
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Next

Return to ArmorySync - Depreciated

Who is online

Users browsing this forum: No registered users and 1 guest

cron