Aldor / Scryer v0.5.4 [Roster 2.0 addon]

Aldor / Scryer reputation comparison

Moderator: titan99

Aldor / Scryer v0.5.4 [Roster 2.0 addon]

Postby Subxero » Fri Sep 28, 2007 6:41 am

Here is a quick conversion of these great addon to roster 2.0!

I change a little the look & feel.

I need test multilingual part (DE,FR,ES languages) and rosters with different players locales, DF port?.

To do:
-Create realm scope
-Create templates
-Create search functions
-Reduce SQL interactions
-Make options & configurable by Admin menu.

Suggestions ?

------- version 0.5.4 -------
cosmetic changes on installer working with roster2 SVN 1500

------- version 0.5.3 -------
first try to delocalize addon, now you get ALL members information in locale from roster! from whatever upload member information locale used.
added % and xp to exalted on shattrath tooltips

------- version 0.5.2 -------
added flask from Shattrath ( exalted with reputations aldor or scryer, plus cenarion expedition and sha'tar)
fixed french localization

------- version 0.5.1 -------
fixed german localization
quick fix to undefined index

------- version 0.5 -------
adaptation to wowroster 2.0
add spanish localization
new look bars and style

------- version 0.4 -------
modify french title

------- version 0.3 -------
fixed german localization
add language variable
modify the visualization of neutral people
link the name to the profile
add professions selected

------- version 0.2 -------
fixed english localization
In neutre.php change m.member to m.name

Time to test and search problems!

Best Regards Subxero.-
Attachments
aldor_scryer_v0.5.4.zip
Aldor / Scryer v 0.5.4
(23.49 KiB) Downloaded 485 times
Last edited by Subxero on Fri Dec 07, 2007 10:20 pm, edited 5 times in total.
Subxero - Priest 70 Holy - Asphelt Knight Officer - Zul'jin Horde.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Re: Aldor / Scryer v0.5 [Roster 2.0 addon]

Postby poetter » Fri Sep 28, 2007 7:54 am

Hey man,

nice one.
You get rid of these notices if you define the array key before appending to it. So do a $rep[$row['standing']] = '' before $rep[$row['standing']] .= 'whatever'. And so on.

Attached are the german locales:
Code: Select all
$lang['Aldor_Scryer_menu'] = 'Aldor & Seher|Anzeige wer Aldor oder Seher ist';
$lang['Aldor_Scryer_title_addon'] = 'Aldor / Seher';

$lang['Scryer']= 'Die Seher';
$lang['Aldor'] = 'Die Aldor';
$lang['Professions'] = 'Berufe';
$lang['rep_name'] = 'Name';
$lang['rep_group'] = 'Gruppe';
$lang['rep_faction'] = 'Fraktion';
$lang['rep_status'] = 'Ansehen';
$lang['rep_value'] = 'Wert';
$lang['rep_max'] = 'Max-Wert';
$lang['AS_Select_Professions']= 'Wähle Berufe...';


cu poetter
Last edited by poetter on Fri Sep 28, 2007 7:55 am, edited 1 time in total.
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Aldor / Scryer v0.5.1 [Roster 2.0 addon]

Postby Subxero » Fri Sep 28, 2007 7:28 pm

Thanks poetter for the translation ^^

And yes poetter, I known the dirty solution .. but if you have people with different locales uploaded on roster? sure there another form that create 8x4=32 arrays, I think its better change the "system" to take care of all possibilities.
Subxero - Priest 70 Holy - Asphelt Knight Officer - Zul'jin Horde.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Aldor / Scryer v0.5.1 [Roster 2.0 addon]

Postby Blueleaf » Mon Oct 01, 2007 11:01 pm

Great work Thank you
User avatar
Blueleaf
WR.net Apprentice
WR.net Apprentice
 
Posts: 50
Joined: Thu Apr 26, 2007 12:06 am
Location: Minot, ND

Re: Aldor / Scryer v0.5.1 [Roster 2.0 addon]

Postby tuigii » Wed Oct 10, 2007 7:32 am

Subxero wrote:And yes poetter, I known the dirty solution .. but if you have people with different locales uploaded on roster? sure there another form that create 8x4=32 arrays, I think its better change the "system" to take care of all possibilities.

Was there, seen that :wink:
Have a look at this addon : FactReputation.
You'll see how I dealt with this matter of ' .= ' assigning to empty array indexes - and multi language issues.

Btw :
frFR.php (I removed the $wordings['frFR'] - it was still in there - et quelques autres bricoles :wink: ) :
Code: Select all
$lang['Aldor_Scryer_menu'] = 'Aldor & Clairvoyants.|Montre qui est coté Aldor ou Clairvoyant.';
$lang['Aldor_Scryer_title_addon'] = 'Aldor / Clair.';
 
$lang['Scryer']= 'Les Clairvoyants';
$lang['Aldor'] = "Les Aldor";
$lang['Professions'] = 'Métiers';
$lang['rep_name'] = 'Nom';
$lang['rep_faction'] = 'Faction';
$lang['rep_status'] = 'Réputation';
$lang['rep_value'] = 'Valeur';
$lang['rep_max'] = 'Max';
$lang['AS_Select_Professions']= 'Choisir un métier...';  
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Aldor / Scryer v0.5.2 [Roster 2.0 addon]

Postby Subxero » Sun Oct 28, 2007 12:30 am

Hi again!

thanx tuigii for french revision ^^

I added a new column to addon "shattrath's flask! showing the people that can use the illidari marks to get flask ;)

http://www.wowhead.com/?search=flask+of+shattrath

And what reputation fail to get it! :)
Subxero - Priest 70 Holy - Asphelt Knight Officer - Zul'jin Horde.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Re: Aldor / Scryer v0.5.2 [Roster 2.0 addon]

Postby tuigii » Sun Oct 28, 2007 3:45 am

Please change frFR.php line 20
Code: Select all
$lang['Aldor'] = 'Les Aldor';

for
Code: Select all
$lang['Aldor'] = "L'Aldor";


Line 32+
Code: Select all
$lang['Cenarion_Expedition'] = 'Expédition Cénarienne';
$lang['Shatar'] = 'Des Sha\\\'tar';

$lang['rep_to_en'] = array(
    "Des Sha'tar" => "The Sha'tar",
    "Expédition Cénarienne" => "Cenarion Expedition",
);
for
Code: Select all
$lang['Cenarion_Expedition'] = 'Expédition cénarienne';
$lang['Shatar'] = "Les Sha'tar";

$lang['rep_to_en'] = array(
    "Les Sha'tar" => "The Sha'tar",
    "Expédition cénarienne" => "Cenarion Expedition",
);


and I propose this for inc/faction.php on line 87
Code: Select all
} else
   $cell_value3 = '<img src="'.$roster->config['img_url'].'pixel.gif" height="14" width="1" alt="" />';

To fill in the empty column with a 'nothing' (and to close the previous column).

Check it over here : (French) : http://www.papy-team.fr/roster/index.ph ... er&guild=1

:D

Btw : The "Can_use_SF" case is never true [ line87 : if ($roster->db->num_rows($result3) == 0 ) { ] - how come ?
My guild hasn't any members that fill in this case ? Or error somewhere ?
Last edited by tuigii on Sun Oct 28, 2007 3:48 am, edited 1 time in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: Aldor / Scryer v0.5.2 [Roster 2.0 addon]

Postby Subxero » Sun Oct 28, 2007 4:28 am

tuigii wrote:Line 32+
Code: Select all
$lang['Cenarion_Expedition'] = 'Expédition Cénarienne';
$lang['Shatar'] = 'Des Sha\\\'tar';

$lang['rep_to_en'] = array(
    "Des Sha'tar" => "The Sha'tar",
    "Expédition Cénarienne" => "Cenarion Expedition",
);


Sure don't get error on mysql ? because need the \ before ' on Sha\'tar

tuigii wrote:and I propose this for inc/faction.php on line 87
Code: Select all
} else
   $cell_value3 = '<img src="'.$roster->config['img_url'].'pixel.gif" height="14" width="1" alt="" />';

To fill in the empty column with a 'nothing' (and to close the previous column).

Good catch! ;)

tuigii wrote:Check it over here : (French) : http://www.papy-team.fr/roster/index.ph ... er&guild=1

:D

Btw : The "Can_use_SF" case is never true [ line87 : if ($roster->db->num_rows($result3) == 0 ) { ] - how come ?
My guild hasn't any members that fill in this case ? Or error somewhere ?


You need EXALTED with Cenarion Expedition + Sha'tar + (Aldor or Scryer)

http://www.papy-team.fr/roster/index.ph ... ne&guild=1
http://www.papy-team.fr/roster/index.ph ... ar&guild=1

Belooki & Dinaya have C.E.+Sha'tar but not aldor or scryer
Beverley,Cyris,Dbmage have Sha'tar+Aldor but not C.E.
Aihla have Sha'tar+Scryer but not C.E.

No body on your guild can use "Mark of the Illidari" dropped at Serpenstrine Caverns/The Eye or Black Temple to get Flasks.

Look at my guild:
Image

I can add a option to show or not these new addition ...
Last edited by Subxero on Sun Oct 28, 2007 4:29 am, edited 1 time in total.
Subxero - Priest 70 Holy - Asphelt Knight Officer - Zul'jin Horde.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Re: Aldor / Scryer v0.5.2 [Roster 2.0 addon]

Postby tuigii » Sun Oct 28, 2007 5:12 am

Subxero wrote:
tuigii wrote:Line 32+
Code: Select all
$lang['Cenarion_Expedition'] = 'Expédition Cénarienne';
$lang['Shatar'] = 'Des Sha\\\'tar';

$lang['rep_to_en'] = array(
    "Des Sha'tar" => "The Sha'tar",
    "Expédition Cénarienne" => "Cenarion Expedition",
);


Sure don't get error on mysql ? because need the \ before ' on Sha\'tar

You saw an error ? :wink: because that what I use right now.
I have have s simple:
Code: Select all
$lang['Shatar'] = 'Les Sha\'tar';

for that one, the \ is used (one) because its used in a SQL compare.

This is correct:
Code: Select all
$lang['Cenarion_Expedition'] = 'Expédition cénarienne';
$lang['Shatar'] = "Les Sha\'tar";

$lang['rep_to_en'] = array(
    "Les Sha'tar" => "The Sha'tar",
    "Expédition cénarienne" => "Cenarion Expedition",
);


In the 'rep_to_en' array, the fields are used to get file names.
When I leave the \ in, files (images) aren't found.

And thanks for the explanation, I didn't know this.
Last edited by tuigii on Sun Oct 28, 2007 8:37 am, edited 1 time in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: Aldor / Scryer v0.5.2 [Roster 2.0 addon]

Postby tuigii » Mon Nov 05, 2007 10:29 am

Me again :wink:

File inc/faction.php - line 137 and further:
Instead of
Code: Select all
   $content .=($rep[$roster->locale->act['exalted']]);
   $content .=($rep[$roster->locale->act['revered']]);
   $content .=($rep[$roster->locale->act['honored']]);
   $content .=($rep[$roster->locale->act['friendly']]);
Use:
Code: Select all
   if (array_key_exists($roster->locale->act['exalted'],$rep))
      $content .=($rep[$roster->locale->act['exalted']]);
   if (array_key_exists($roster->locale->act['revered'],$rep))
      $content .=($rep[$roster->locale->act['revered']]);
   if (array_key_exists($roster->locale->act['honored'],$rep))
      $content .=($rep[$roster->locale->act['honored']]);
   if (array_key_exists($roster->locale->act['friendly'],$rep))
      $content .=($rep[$roster->locale->act['friendly']]);


Because if a reputation isn't present in the $rep array, you can't index it neither without being punished => a php error will pop up, like :

Notice line 146: Undefined index: Exalté
Notice line 146: Undefined index: Exalté
Notice line 147: Undefined index: Révéré


If you have a column without Exalted and Revered is this case.

Better check if the keys exists, before spitting them out.

[Found this out in my own addon FactReputation :wink: ]
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Aldor / Scryer v0.5.2 [Roster 2.0 addon]

Postby Subxero » Mon Nov 05, 2007 10:57 pm

Thanks Tuigii ;) good catch.
Subxero - Priest 70 Holy - Asphelt Knight Officer - Zul'jin Horde.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Aldor / Scryer v0.5.3 [Roster 2.0 addon]

Postby Subxero » Mon Nov 12, 2007 7:02 am

Hi again! new version ;)

Now SHOW ALL MEMBER INFORMATION with locale that you select on roster from WHATEVER locale use the "member" on upload his information..

Example: Roster locale = spanish
Subject A = upload cp with english wow
Subject B = upload cp with german wow
Rest of people = upload cp with spanish wow

Before these version addon show only the information from "Rest of people", now show ALL information include A&B subjects :)

Comments, sugestions & bugs are welcome!

BR
Subxero - Priest 70 Holy - Asphelt Knight Officer - Zul'jin Horde.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Aldor / Scryer v0.5.3 [Roster 2.0 addon]

Postby AnthonyB » Wed Nov 14, 2007 8:32 am

Just tried installing v0.5.3 on a Roster 2 beta (SVN 1409) and got the following error on install:

Database Error1366: Incorrect integer value: '' for column 'wrnet_id' at row 1
SQL:
INSERT INTO `roster_addon` VALUES (NULL,"Aldor_Scryer","0.5.3",0,"Aldor_Scryer","Compare reputation Aldor/Scryer","a:1:{i:0;a:2:{s:4:\"name\";s:7:\"Titan99\";s:4:\"info\";s:33:\"Compare reputation Aldor / Scryer\";}}","spell_arcane_portalshattrath","");
File: lib\dbal\mysql.php
Line: 203
Backtrace (most recent call last):
lib\functions.lib.php
Line: 240
Function Called: backtrace
lib\dbal\mysql.php
Line: 203
Function Called: die_quietly
Arguments:
1366: Incorrect integer value: '' for column 'wrnet_id' at row 1
Database Error
C:\Inetpub\wwwroot\roster2\lib\dbal\mysql.php
203
INSERT INTO `roster_addon` VALUES (NULL,"Aldor_Scryer","0.5.3",0,"Aldor_Scryer","Compare reputation Aldor/Scryer","a:1:{i:0;a:2:{s:4:\"name\";s:7:\"Titan99\";s:4:\"info\";s:33:\"Compare reputation Aldor / Scryer\";}}","spell_arcane_portalshattrath","");
admin\addon_install.php
Line: 406
Function Called: query
Arguments:
INSERT INTO `roster_addon` VALUES (NULL,"Aldor_Scryer","0.5.3",0,"Aldor_Scryer","Compare reputation Aldor/Scryer","a:1:{i:0;a:2:{s:4:\"name\";s:7:\"Titan99\";s:4:\"info\";s:33:\"Compare reputation Aldor / Scryer\";}}","spell_arcane_portalshattrath","");
admin\addon_install.php
Line: 46
Function Called: processAddon
pages\rostercp.php
Line: 116
Function Called: require_once
Arguments:
C:\Inetpub\wwwroot\roster2\admin\addon_install.php
index.php
Line: 83
Function Called: require
Arguments:
C:\Inetpub\wwwroot\roster2\pages\rostercp.php

Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Re: Aldor / Scryer v0.5.3 [Roster 2.0 addon]

Postby tuigii » Wed Nov 14, 2007 10:58 am

AnthonyB wrote:Just tried installing v0.5.3 on a Roster 2 beta (SVN 1409) and got the following error on install:

Database Error1366: Incorrect integer value: '' for column 'wrnet_id' at row 1
.....


The variable wrnet_id is introduced in roster version 1408, for about two weeks ago....
Each addon should have it in it's inc/install.def.php file - in its class definition.
In this case, add this at line 32:
Code: Select all
   var $wrnet_id = '0';

and all will be well.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Aldor / Scryer v0.5.3 [Roster 2.0 addon]

Postby AnthonyB » Wed Nov 14, 2007 11:27 am

Thanks tuigii - that did the trick :)
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Next

Return to Aldor / Scryer

Who is online

Users browsing this forum: No registered users and 0 guests

cron