Hey - Sorry to sound like I'm jumping the gun, but this addon throws an error with the new Shattered Sun faction. To whit:

Code: Select all

  Notice line 50: Undefined index: Shattered Sun Offensive
  Notice line 298: Undefined variable: faction_local

Is it being worked on? Sorry to sound like a nag

jaffa wrote:

Code: Select all

  Notice line 50: Undefined index: Shattered Sun Offensive
  Notice line 298: Undefined variable: faction_local

Whaaat ??? New factions have being added to WoW ??? When ?? Why ?? Is this 2.4 relaled ??

jaffa wrote:Is it being worked on? Sorry to sound like a nag

Don't worry; it took my Guild half an hours to blow up the roster with the new names, items, faction, problems, bosses, etc etc.

I'm still in the "how to install a WoW addon in the Interface/Addons directory” phase with my Guild, as usual, now-one knows how to copy files any more - and I'm not don't even mentionning de-zipping.

Right after that, I'll collect all the new faction names, in all the 4 languages, and I'll UP this one.

I've visited the new zone.

The related faction is

Shattered Sun Offensive (related to Magisters' Terrace & Sunwell Plateau)

Source :http://www.wowwiki.com/Faction.

I already found the French one : "Opération Soleil brisé".

So, adding four lines in inc/factions_to_en.php will do the job.
Insert in line 79 the English back-reference:
/* NEW

Code: Select all

        */ "Shattered Sun Offensive" => "Shattered Sun Offensive",  

This does the job for English.

I need the German (nothing here yet : http://wow.ingame.de/wiki/index.php/Fraktion) and Spanish one (can't find it neither), and I'll up the reputation addon.[align=left]

by http://eu.wowarmory.com
Español: "Ofensiva Sol Devastado"
Deutsch: "Zerschmetterte Sonne"

Subxero wrote:by http://eu.wowarmory.com
Español: "Ofensiva Sol Devastado"
Deutsch: "Zerschmetterte Sonne"

Great. Not even any accents.
This will be easy.

I'll up it this evening.

Btw, I'll think about some message when an unkown reputation shows up, instead of a stupid PHP error

Were you able to get this upped?

or are we still waiting?

cwpc wrote:Were you able to get this upped?

Still testing - can't just say "this is ok".
I made some other changes also. Need to be sure.

cwpc wrote:or are we still waiting?

Edit the factions_to_en.php as states above, and all is well.
This means, add to each array this string:

Code: Select all

"Shattered Sun Offensive" => "Shattered Sun Offensive", 

(four times, ones for every language)

and you'll be up.

if my entire guild is in English do i have to do all 4 edits?

and if so do they have to be in those languages?

I'm receiving an Install error, "The install definition file for reputation did not contain a correct installation class" when trying to install this AddOn.

Chamdar wrote:I'm receiving an Install error, "The install definition file for reputation did not contain a correct installation class" when trying to install this AddOn.

Sorry, I can not duplicate this error.

Can you give some more details.

I didn't update the ZIP for the last six weeks, and many who downloaded it didn't mention this kind of errror (aka : it's working).

Here are the steps that took place:
(1) Extracted the file
(2) Copied the file into the addons directory
(3) Logged into the Roster as Admin and clicked Managed Addons
(4) At the top of the list of existing addon's there is a red box with the error message mentioned above.

When you remove it, the error goes away.

I'm going to DL the file again and try one more time and see if I still get the same error message.

Just DL'd the file again and after installing it, still receive the same error message in the red box above all the other installed Addons.

delete the folder from your site, then re-upload it - i suspect it isnt overwriting the install.def file, and on your site may be an old copy of the file before the install class changes were made.

As a rule of thumb, one should always overwrite (older) local files with (newer) files from the ZIP.
Otherwise upgrading will never work

I did add the code:

Code: Select all

*/ "Shattered Sun Offensive" => "Shattered Sun Offensive",
 

Looks to be working great so far. I have been trying to beta test most addon modules in the Roster DF. You may take a look at it over at my site.

http://www.bronzedragonlords.com/index.php?name=WowRosterDF&p