After some complains from my guild's forum users about the signatures, I started debugging the problem.
It seemed that some sigs didn't display anymore as soon as they were cached by the browser. I checked the headers and it seemed that the If-Modified-Since header was set to: Wed, 31 Dec 1969 23:59:59 GMT
Obviously this isn't a valid date at all.

After some code digging I found the following bug:
At row 357 from siggen.php the $DTS variable is set to: strtotime($sig_updated.$configData['db_ver'])

First of all why is $configData['db_ver'] appended to the date here!?!?
And second, strtotime expects you to give him a valid date string according to the GNU Date Input Formats syntax. The way the date is stored to the database does not match this syntax so strtotime will return -1 (or FALSE)

Here is my fix:

Code: Select all

188c188
<       $players_str = 'SELECT * FROM `'.ROSTER_PLAYERSTABLE."` WHERE `member_id` = '$member_id';";
---
>       $players_str = 'SELECT *, STR_TO_DATE(`dateupdatedutc`, \'%m/%d/%y %H:%i:%s\') AS `dateupdatedutc` FROM `'.ROSTER_PLAYERSTABLE."` WHERE `member_id` = '$member_id';";
357c357
<               $DTS = strtotime($sig_updated.$configData['db_ver']);
---
>               $DTS = strtotime($sig_updated);


Wow, I haven't looked at this part of the code for over a year now...
I wonder why the db_ver is there too???

You might want to check the beta SigGen too, since it seems to have the wrong headers as well:
Expires: Thu, 19 Nov 1981 08:52:00 GMT
For a new generated image?

I'll be sure to take a look at it before I stamp FINAL on the zip package
I will be making another beta release of SigGen before 0.3.0 final is out

Fixed in v0.3.0.320