[1485] - Memberlist Porblem

Posts from previous Beta sessions

[1485] - Memberlist Porblem

Postby luciver » Tue Nov 27, 2007 4:41 pm

Hey !

I have updatedet to 1485 from 1475, updatet the addons und wehn i click off memberlist come this :

Fatal error: Cannot redeclare class memberslist in /var/www/vhosts/boten-des-zorns.org/subdomains/roster/httpdocs/addons/memberslist/inc/memberslist.php on line 28


Link to the Roster :
http://roster.boten-des-zorns.org
The German Community
wowroster.de
Akecheta of Frostwolf
User avatar
luciver
WR.net Apprentice
WR.net Apprentice
 
Posts: 26
Joined: Wed Jul 05, 2006 12:28 am
Location: Berlin

Re: [1485] - Memberlist Porblem

Postby Keviel » Tue Nov 27, 2007 6:31 pm

Mehe, I already posted that in the thread DIRECTLY under yours ;-)
Keviel
WR.net Apprentice
WR.net Apprentice
 
Posts: 60
Joined: Fri Oct 19, 2007 7:53 pm
Location: Copenhagen, Denmark

[1485] - Memberlist Porblem

Postby wallfw » Tue Nov 27, 2007 6:32 pm

gettting the same error after upgrade
wallfw
WR.net Apprentice
WR.net Apprentice
 
Posts: 15
Joined: Mon Apr 30, 2007 7:52 pm

Re: [1485] - Memberlist Porblem

Postby redwarrior » Tue Nov 27, 2007 6:33 pm

same error
redwarrior
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Thu Dec 14, 2006 5:08 am

[1485] - Memberlist Porblem

Postby bisaz » Tue Nov 27, 2007 6:33 pm

Same here
bisaz
WR.net Apprentice
WR.net Apprentice
 
Posts: 24
Joined: Sun Dec 10, 2006 6:31 am

Re: [1485] - Memberlist Porblem

Postby redwarrior » Tue Nov 27, 2007 6:37 pm

i think all roster 2.0 users have the same problem
redwarrior
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Thu Dec 14, 2006 5:08 am

[1485] - Memberlist Porblem

Postby PleegWat » Tue Nov 27, 2007 7:47 pm

OK, this is likely to be my fault, but I don't really have the time to look at it extensively right now.

Can someone try going back one revision at a time (svn update -r <number>) and tell me what's the last one that worked?

EDIT: OK, I misunderstood the issue. This still worked when I last checked in. I'll yell at zanix tonight.
Last edited by PleegWat on Tue Nov 27, 2007 7:50 pm, edited 1 time in total.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: [1485] - Memberlist Porblem

Postby Keviel » Tue Nov 27, 2007 7:50 pm

1480 definitely worked, and I think 1482 did as well - I'll check with the 83-84 ones as well when I have a spare moment at work.
Keviel
WR.net Apprentice
WR.net Apprentice
 
Posts: 60
Joined: Fri Oct 19, 2007 7:53 pm
Location: Copenhagen, Denmark

Re: [1485] - Memberlist Porblem

Postby luciver » Wed Nov 28, 2007 12:54 am

Hey !

Here is au fix from Nefuh@wowroster.de :) thx !!
Attachments
roster_20b_1485_fix.zip
(15.14 KiB) Downloaded 99 times
The German Community
wowroster.de
Akecheta of Frostwolf
User avatar
luciver
WR.net Apprentice
WR.net Apprentice
 
Posts: 26
Joined: Wed Jul 05, 2006 12:28 am
Location: Berlin

[1485] - Memberlist Porblem

Postby mdeshane » Wed Nov 28, 2007 1:07 am

I believe the culprit is trunk\index.php in SVN[1484]. If you change it to the SVN[1483] version it works just fine again.

[EDIT]:Could it be that when the new code to check versions of addons starts a new instance of an addon's install class, one of those addons creates an instance of the memberslist class?
Last edited by mdeshane on Wed Nov 28, 2007 1:18 am, edited 1 time in total.
Image
Accounts Addon - Roster v2 User Account Addon

PKC Dev Site - http://dev.pkcomp.net
My Roster Dev Site - http://myroster.dontexist.net
User avatar
mdeshane
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 203
Joined: Sun Dec 10, 2006 4:54 am
Location: Grand Rapids, MI USA
Realm: Khadgar (PvE) - US

Re: [1485] - Memberlist Porblem

Postby Keviel » Wed Nov 28, 2007 1:18 am

Yeah, I got the same result mdeshane - tried to post it earlier, when the fora decided to go blooey - Haven't had time to check the differences between 83 and 84 in the file though. :-)
Keviel
WR.net Apprentice
WR.net Apprentice
 
Posts: 60
Joined: Fri Oct 19, 2007 7:53 pm
Location: Copenhagen, Denmark

[1485] - Memberlist Porblem

Postby mdeshane » Wed Nov 28, 2007 1:21 am

The only difference in the files are these lines of code were added around line 113:
Code: Select all
if( $addon['active'] == '1' )
{
    
// Check if this addon is in the process of an upgrade and deny access if it hasn't yet been upgraded
    
$installfile $addon['inc_dir'] . 'install.def.php';

    if( 
file_exists($installfile) )
    {
        include_once(
$installfile);

        if( 
class_exists($addon['basename']) )
        {
            
$addonstuff = new $addon['basename'];

            
// -1 = overwrote newer version
            //  0 = same version
            //  1 = upgrade available

            
if( version_compare($addonstuff->version,$addon['version']) )
            {
                
roster_die(sprintf($roster->locale->act['addon_upgrade_notice'],$addon['basename']) . '<br /><a href="' makelink('rostercp-install') . '">'
                    
sprintf($roster->locale->act['installer_click_upgrade'],$addon['version'],$addonstuff->version) . '</a>',$roster->locale->act['addon_error']);
            }
        }
    } 
Image
Accounts Addon - Roster v2 User Account Addon

PKC Dev Site - http://dev.pkcomp.net
My Roster Dev Site - http://myroster.dontexist.net
User avatar
mdeshane
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 203
Joined: Sun Dec 10, 2006 4:54 am
Location: Grand Rapids, MI USA
Realm: Khadgar (PvE) - US

[1485] - Memberlist Porblem

Postby zanix » Wed Nov 28, 2007 1:31 am

I personally think this change is a good idea since a not completely upgraded addon could have issues if someone tries to access it before the upgrade is complete

I'm willing to listen to suggestions
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

[1485] - Memberlist Porblem

Postby zanix » Wed Nov 28, 2007 1:32 am

I have one already

Make the installer class be named addonnameInstall
Last edited by zanix on Wed Nov 28, 2007 1:33 am, edited 1 time in total.
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

[1485] - Memberlist Porblem

Postby mdeshane » Wed Nov 28, 2007 1:38 am

I agree Zanix! I think this is a wonderful and useful addition! We just have a few bugs to work out... lol

So, for the install.def.php instead of:
Code: Select all
class addonname


it should now be:
Code: Select all
class addonnameInstall


Correct?
Image
Accounts Addon - Roster v2 User Account Addon

PKC Dev Site - http://dev.pkcomp.net
My Roster Dev Site - http://myroster.dontexist.net
User avatar
mdeshane
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 203
Joined: Sun Dec 10, 2006 4:54 am
Location: Grand Rapids, MI USA
Realm: Khadgar (PvE) - US

Next

Return to Archived

Who is online

Users browsing this forum: No registered users and 0 guests

cron