Header Change in svn[1488]

Posts from previous Beta sessions

Header Change in svn[1488]

Postby Timothy003 » Sat Dec 15, 2007 3:58 pm

- Removed SEO check in header template file, its safe to have baseurl in there


This header change was not safe and was not compatible with my site which used a custom port number. I noticed after this change that the stylesheet was missing (making the page background white and without proper content formatting), and after clicking "Upgrade" it would redirect my browser to the roster's base URL without the custom port number (:81), making me unable to upgrade the other changes in revision 1488.
Timothy003
WR.net Apprentice
WR.net Apprentice
 
Posts: 1
Joined: Wed Sep 05, 2007 10:09 pm

Header Change in svn[1488]

Postby zanix » Sat Dec 15, 2007 4:14 pm

Ok, I tried to test it on my personal server
I will reverse this change in the next commit

In the mean time, you can reverse this by editing templates/default/header.html
Find
Code: Select all
<base href="{ROSTER_URL}" />

And Replace with
Code: Select all
<!-- IF S_SEO_URL --><base href="{ROSTER_URL}" /><!-- ENDIF -->
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Header Change in svn[1488]

Postby PleegWat » Sat Dec 15, 2007 8:25 pm

Fixed ROSTER_URL to include the server port number (if it is not 80).
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Header Change in svn[1488]

Postby zanix » Sat Dec 15, 2007 8:36 pm

PleegWat wrote:Fixed ROSTER_URL to include the server port number (if it is not 80).
Even better
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US


Return to Archived

Who is online

Users browsing this forum: No registered users and 0 guests

cron