Roster 1.9.9.xxx - Minor Char info problem

Posts from previous Beta sessions

Roster 1.9.9.xxx - Minor Char info problem

Postby tuigii » Thu Dec 27, 2007 7:58 pm

Look at this image : the Defence value is 370.

Image
(Click on image to see the char info completely)

Normal, because the number is been taken out of the skills table, line 1536 - function printDefense() - in addons/info/inc/char.lib.php.

I think this is wrong.

This value should be the stat_def_c value in the players table and not the max. (or current) defence value of a player.

Anyway, the shown value isn't corresponding avec the IG value.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Roster 1.9.9.xxx - Minor Char info problem

Postby PleegWat » Thu Dec 27, 2007 9:07 pm

It's showing correctly, but it's not colored correctly.

As a rule, we show the current value in the panel, and base (-debuff) (+buff) in the tooltip. Then the current value is colored:
- Green when buffed
- Red when debuffed
- Purple when both buffs and debuffs are active on this stat.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: Roster 1.9.9.xxx - Minor Char info problem

Postby tuigii » Thu Dec 27, 2007 10:54 pm

Thanks for clearing up.

Have a look a my defence capabilities at wowamroy :

Image
http://eu.wowarmory.com/character-sheet ... &n=Nowwhat

So, my base defence value is 370, buffed by quipment with 102 points (armory) / 103 (roster) : making a total of ‘green’ 472 value.
Tgis value is shown IG also, and I think it's this value that should be showed in the roster also.

I my fellow raid members would base my defence rating on what’s being shown in the roster right now (without doing the addition manually), I wouldn’t earn my place in a group as a MT1 or even MT2.

Or, am I still missing the point ? (possible - Christmas in France always introduces some brain damage :wink: )
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Roster 1.9.9.xxx - Minor Char info problem

Postby PleegWat » Thu Dec 27, 2007 11:24 pm

Hm, I'm misreading stuff. Sorry.

The Defense line shows defense skill. This is capped at 375. You've got a base of 370. Skill bonuses from items/buffs are not stored separately by CP, and since we haven't been parsing item tooltips properly for very long we're not adding it manually.

The second stat in the tooltip is defense rating. Not sure why there's base and buff there though then, since rating is all buff.

I'm confused, I'll get back to you after I've looked at the code.

EDIT:
Yup, that's what it is. Main number is defense skill, but doesn't show buffs cause we don't have the buff to that handy anywhere. Tooltip shows base, buff, and debuff for defense rating.

Armory probably shows current defense skill, rather than base.
Last edited by PleegWat on Thu Dec 27, 2007 11:30 pm, edited 1 time in total.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: Roster 1.9.9.xxx - Minor Char info problem

Postby tuigii » Fri Dec 28, 2007 5:03 pm

PleegWat wrote:Armory probably shows current defense skill, rather than base.

Make that "Blizzard WoW In Game" also :wink:

My IG defense value :
Image
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Roster 1.9.9.xxx - Minor Char info problem

Postby PleegWat » Fri Dec 28, 2007 5:36 pm

And I've looked at a CP file, and we actually do have the defense skill with bonuses in the CP data. We just never used it because 'it's the same as the one in the skill table anyway' and we forgot about buffs.

When I have time I'll add the data to the table and fix info.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Roster 1.9.9.xxx - Minor Char info problem

Postby reoc » Thu Mar 06, 2008 4:28 am

Is there a fix for this issue at all as I have searched high and low on the forum and not came across one yet.

Please can you help
User avatar
reoc
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Tue Feb 05, 2008 3:33 pm
Location: Scotland

Re: Roster 1.9.9.xxx - Minor Char info problem

Postby reoc » Mon Mar 17, 2008 7:41 pm

Does anyone have the fix for this issue.

Please can someone help me. or even respond to my post ?
Image
Image
User avatar
reoc
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Tue Feb 05, 2008 3:33 pm
Location: Scotland

Re: Roster 1.9.9.xxx - Minor Char info problem

Postby tuigii » Mon Mar 17, 2008 8:30 pm

reoc wrote:Please can someone help me. or even respond to my post ?
Of cours, replying is easy, but the ones with the answers are still looking.... :wink:

reoc wrote:Does anyone have the fix for this issue.

You should have found by now the post that states that WoWRoster is importing the ChacacterProfiler.lua file, and that this file is made by the WoW in-game addon with the same name.
So, this might be CharacaterProfiler issue, because the WoWRoster just shows this "defense value".
The auteur (named : Calvin - you already know his site & forum :wink: ) should be able to say if the data recovered from / exposed by the game engine could be modified so that WoWRoster can show the defense value 'correctly'.

These are my thoughts, and I'm not even sure that I get the whole picture.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Roster 1.9.9.xxx - Minor Char info problem

Postby zanix » Tue May 27, 2008 8:01 am

Bumping this back up so this can be fixed
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US


Return to Archived

Who is online

Users browsing this forum: No registered users and 0 guests

cron