Buff tooltips not imported correctly

Sync Blizzards' Armory data with WoWRoster (addon depreciated no longer works see ApiSync)

Moderators: Ulminia, poetter

Buff tooltips not imported correctly

Postby zanix » Mon Feb 25, 2008 6:52 am

Buff tooltips are not imported correctly as compared to CharacterProfiler uploads

A buff on the armory shows the name and the description
CharacterProfiler imports this correctly

http://svnroster.homeip.net/roster/trun ... a=c:2.html - A CP uploaded character

http://www.wowarmory.com/character-shee ... &n=Nelmart - Same character on the armory

The only thing the armory is missing, is the buff type


http://svnroster.homeip.net/roster/trun ... c:378.html - an armory uploaded character

http://www.wowarmory.com/character-shee ... r&n=Kaziel - Same character on the armory

Here, the name of the buff is missing in Roster


The tooltip is not built with the buff name in AS
armorysync/inc/armorysync.class.php
Code: Select all
<?php
            
if ( $this->_checkContent$tab, array( 'buffs''spell' ) ) ) {
                if ( 
is_array($tab->buffs->spell) ) {
                    foreach ( 
$tab->buffs->spell as $spell ) {
                        
$buffName $spell->name;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $spell->effect;
                    }
                } else {
                    
$spell $tab->buffs->spell;
                    
$buffName $spell->name;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $spell->effect;
                }
            }

            if ( 
$this->_checkContent$tab, array( 'debuffs''spell' ) ) ) {
                if ( 
is_array($tab->debuffs->spell) ) {
                    foreach ( 
$tab->debuffs->spell as $spell ) {
                        
$buffName $spell->name;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $spell->effect;
                    }
                } else {
                    
$spell $tab->debuffs->spell;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $spell->effect;
                }
            } 


This probably should be
Code: Select all
<?php
            
if ( $this->_checkContent$tab, array( 'buffs''spell' ) ) ) {
                if ( 
is_array($tab->buffs->spell) ) {
                    foreach ( 
$tab->buffs->spell as $spell ) {
                        
$buffName $spell->name;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $buffName '<br>' $spell->effect;
                    }
                } else {
                    
$spell $tab->buffs->spell;
                    
$buffName $spell->name;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $buffName '<br>' $spell->effect;
                }
            }

            if ( 
$this->_checkContent$tab, array( 'debuffs''spell' ) ) ) {
                if ( 
is_array($tab->debuffs->spell) ) {
                    foreach ( 
$tab->debuffs->spell as $spell ) {
                        
$buffName $spell->name;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                        
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $buffName '<br>' $spell->effect;
                    }
                } else {
                    
$spell $tab->debuffs->spell;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Name"] = $buffName;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Icon"] = $spell->icon;
                    
$this->data["Attributes"]["Buffs"][$buffName]["Tooltip"] = $buffName '<br>' $spell->effect;
                }
            } 


I haven't tested this yet as the armory is being slow
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Buff tooltips not imported correctly

Postby poetter » Mon Feb 25, 2008 7:42 am

Fixed svn[374]
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg


Return to ArmorySync - Depreciated

Who is online

Users browsing this forum: No registered users and 0 guests

cron