svn[1735] icon link for empty bag and bank slots broken

Posts from previous Beta sessions

svn[1735] icon link for empty bag and bank slots broken

Postby AnthonyB » Thu Mar 20, 2008 5:32 pm

Looks like somewhere around [1732]-[1735] the empty bag/bank slot icon got broke for me.

Bags:
http://anthonyb.dyndns.org/roster2/inde ... ags&a=c:70

Bank:
http://anthonyb.dyndns.org/roster2/inde ... ank&a=c:70

Anyone else seeing the same?
Last edited by AnthonyB on Thu Mar 20, 2008 5:36 pm, edited 1 time in total.
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

svn[1735] icon link for empty bag and bank slots broken

Postby zanix » Fri Mar 21, 2008 4:19 am

Looks just fine to me
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: svn[1735] icon link for empty bag and bank slots broken

Postby Movix » Fri Mar 21, 2008 4:55 am

the URL of your image file is
Code: Select all
http://anthonyb.dyndns.org/roster2/%7BIMG_URL%7Dpixel.gif


seems that a template has been edited with something like dreamwaever and the {and } were be replaced by the codes %7B and %7D
Last edited by Movix on Fri Mar 21, 2008 4:56 am, edited 1 time in total.
Image
DF 9.2.1 - RosterDF 1.7.3.0 (patched) - Roster 2.0 beta
User avatar
Movix
WR.net Apprentice
WR.net Apprentice
 
Posts: 59
Joined: Fri Dec 22, 2006 1:27 pm

svn[1735] icon link for empty bag and bank slots broken

Postby AnthonyB » Fri Mar 21, 2008 8:09 am

Hmmmm... Thanks Movix, I think you've got us looking in the right direction...

It's not so much that it's been edited, as that the blank icons seems to be the only image link using {IMG_URL} and that is what is failing and only in the bank/bag slots.

Code: Select all
<img src="{IMG_URL}pixel.gif" class="noicon" alt="" />


Other parts of the page using pixel.gif are doing so in a different fashion:

Code: Select all
<img src="img/pixel.gif" width="1" height="1" alt="" />


What makes this more confusing is that use of {IMG_URL} is working in other parts of Roster just fine as best as I can tell, just not in bank and bag slots.
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

svn[1735] icon link for empty bag and bank slots broken

Postby zanix » Fri Mar 21, 2008 8:59 am

Ah, FF doesn't show broken images
addons/info/inc/bag.php
Line 114
Code: Select all
                $roster->tpl->assign_block_vars('bag.item',array(
                    
'ICON' => '<div class="item"><img src="{IMG_URL}pixel.gif" class="noicon" alt="" /></div>'
                    
)
                ); 


Should be
Code: Select all
                $roster->tpl->assign_block_vars('bag.item',array(
                    
'ICON' => '<div class="item"><img src="' $roster->config['img_url'] . 'pixel.gif" class="noicon" alt="" /></div>'
                    
)
                ); 
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

svn[1735] icon link for empty bag and bank slots broken

Postby zanix » Fri Mar 21, 2008 9:00 am

Fixed svn 1737
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

svn[1735] icon link for empty bag and bank slots broken

Postby AnthonyB » Fri Mar 21, 2008 10:43 am

Excellent! Thanks!

>> FF doesn't show broken images

Huh? So how on earth are you supposed to check your web development work?
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

svn[1735] icon link for empty bag and bank slots broken

Postby zanix » Fri Mar 21, 2008 8:46 pm

I dunno...
I guess I could turn "show broken images" on
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US


Return to Archived

Who is online

Users browsing this forum: No registered users and 0 guests

cron