French locale and small patch

Quest History log AddOn

Moderator: Nefuh

French locale and small patch

Postby niac » Fri Apr 25, 2008 10:12 pm

Here a small patch :
- add a frFR locale ;
- add a new string 'datesep' ;
- change "recorrect_date" function to use 'datesep'.

I added 'datesep' cause all language can use a different character to separate date items : the dot (.) for enUS and slash (/) for frFR.

It's juste a very small change in "recorrect_date" function and an add of $lang['datesep'] in locale files.

If you refuse this patch, you have a french translation with a "datesep", just remove the last line :P
Attachments
questhistory-1.9.9.1702_frfr.patch.txt
Patch frFR for QuestHistory 1.9.9.1702
(10.16 KiB) Downloaded 84 times
User avatar
niac
WR.net Apprentice
WR.net Apprentice
 
Posts: 28
Joined: Tue Apr 22, 2008 2:35 pm

French locale and small patch

Postby zanix » Fri Apr 25, 2008 10:15 pm

There are strings for time format in the localization files

Code: Select all
$roster->locale->act['timeformat'];    // MySQL Time format string
$roster->locale->act['phptimeformat']; // PHP date() Time format string 
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: French locale and small patch

Postby niac » Sat Apr 26, 2008 3:53 am

I'm not the author of the addon. The author not using them and use his function to format the date. I juste change 2 lines. I'm not good enough to do a complete patch to using them.
User avatar
niac
WR.net Apprentice
WR.net Apprentice
 
Posts: 28
Joined: Tue Apr 22, 2008 2:35 pm

French locale and small patch

Postby zanix » Sat Apr 26, 2008 4:56 am

Ah, I see
Well, make this a note to the author then :)
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: French locale and small patch

Postby niac » Mon Apr 28, 2008 4:11 pm

Well... this WE I read some php.net doc and it's easier than i think. I'm not think it the better way to do, but it's better than nothing :)

Here the patch to use the phptimeformat locale and the last french locale.
Attachments
questhistory-1.9.9.1702.patch.txt
Patch to use phptimeformat locale.
(11.13 KiB) Downloaded 93 times
Last edited by niac on Mon Apr 28, 2008 4:12 pm, edited 1 time in total.
User avatar
niac
WR.net Apprentice
WR.net Apprentice
 
Posts: 28
Joined: Tue Apr 22, 2008 2:35 pm


Return to Quest History

Who is online

Users browsing this forum: No registered users and 0 guests

cron