GuildBank not showing Bank contents, only bags

Posts from previous Beta sessions

GuildBank not showing Bank contents, only bags

Postby AnthonyB » Sat May 03, 2008 11:16 am

I could've sworn that in days gone by that the GuildBank showed the Bag AND Bank contents of chars flagged as Bank, however, as it stands today it is only showing the Bags and NOT the Bank contents of these chars.

Did this change somewhere along the way? I can't seem to find a config option for the GuildBank addon to alter this behaviour so I'm wondering if this was a conscious decision to NOT show bank contents of Bank chars or a bug?
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

GuildBank not showing Bank contents, only bags

Postby zanix » Sat May 03, 2008 1:07 pm

It looks like its getting some items from the bank
Weird, guess I'm gonna have to look at the code some
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

GuildBank not showing Bank contents, only bags

Postby zanix » Sat May 03, 2008 1:28 pm

After nearly minutes of debugging, I found that I left in and additional fetch() in the loop that gathers items when I converted guildbank to use templates

Open addons/guildbank/guild/index.php
Around line 188, remove
Code: Select all
$itemRow $roster->db->fetch($itemsOnMule); 
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

GuildBank not showing Bank contents, only bags

Postby AnthonyB » Sun May 04, 2008 6:11 am

he he he.. Thanks Zanix :)

OK, so I've updated to SVN [1768] and there's still one more bug I can see - the amount of gold being tallied up for GuildBank toons is wrong.

Looking at my guild example:

Ransinmule - 107g 76s 94c
Ransinmuleto - 197g 61s 3c

Yet on my GuildBank page it has the following amounts listed:

Ransinmule - 94g 76s 107c
Ransinmuleto - 3g 61s 197c
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

GuildBank not showing Bank contents, only bags

Postby zanix » Sun May 04, 2008 10:31 am

LoL
Look at the amounts, they are backwards :lol:
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

GuildBank not showing Bank contents, only bags

Postby AnthonyB » Sun May 04, 2008 12:47 pm

HA HA HA!

Cheers :)
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

GuildBank not showing Bank contents, only bags

Postby AnthonyB » Sun May 04, 2008 1:11 pm

So, this then leads on to the question of what is the future of the built-in GuildBank feature?

I personally find that it provides only the most basic requirement of presenting a semi-consolidated Inventory view of one or more tagged chars (I say semi-consolidated as the functionality of the Roster1 GuildBank to show a single combined inventory view is no longer available).

Doing some additional trawling around the forums there seems to be a lot of people that also rely on the Categorized Guild Bank add-on for Roster1 who are going to be pretty miffed.

Are there any thoughts about giving the built-in GuildBank feature a face-lift or is the current view to leave it to the add-on community?
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

GuildBank not showing Bank contents, only bags

Postby zanix » Sun May 04, 2008 2:23 pm

I think this is where it is going to stay

To provide basic functionality with minimal up-keep
With Cat. GuildBank, there is a list that needs to be maintained for each WoW patch
Every locale string change and new items have to be entered and Cat. GB needs to be updated on each WoW patch

So I think it is safe to say that we (the dev team) will not make a Cat. GB for Roster 2.0, unless one of us gets a wild hair and decides to go for it
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: GuildBank not showing Bank contents, only bags

Postby tuigii » Mon May 05, 2008 1:43 pm

Thank god this thread exists.

I just discovered that the bank mules had a rather low-item count in the roster.
I was always thinking : the automatic stacking that's used (in the SQL code) makes it look like this.

Then, I discovered that on a per-character Bank and sac view (looking at the mule a sa single member) some items were present as they should be, but not in the Banker addon.

Took me also a couple of minutes to find out that exactly HALF of the items were missing.

I went to the forum, with a nice thought about a post concerning a 'bug' :)

Right away, I found this very recent thread that handles the case already.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France


Return to Archived

Who is online

Users browsing this forum: No registered users and 0 guests

cron