PvPLog 3.0.0

Forum Dedicated to PvPLog, (The WoW PvP data collector addon), and PvPLog related topics

Moderator: bsmorgan

PvPLog 3.0.0

Postby bsmorgan » Tue May 20, 2008 3:04 am

PvPLog 3.0.0 for WoW 2.4.2 has been released.

Enjoy,

Brad
Last edited by bsmorgan on Sat Jul 05, 2008 10:56 pm, edited 2 times in total.
User avatar
bsmorgan
WoW Interface Developer
WoW Interface Developer
 
Posts: 160
Joined: Tue Nov 28, 2006 10:17 pm
Location: Colorado Springs, Colorado

PvPLog 3.0.0

Postby zanix » Tue May 20, 2008 3:20 am

Nice work bsmorgan
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: PvPLog 3.0.0

Postby Grektar » Tue May 20, 2008 2:59 pm

Awesome! I'll go try it out. :-)
ImageImageImageImage
User avatar
Grektar
WR.net Apprentice
WR.net Apprentice
 
Posts: 22
Joined: Sun Jul 23, 2006 3:23 pm

Re: PvPLog 3.0.0

Postby tuigii » Tue May 20, 2008 10:39 pm

I've got 4 no-live-PVP gamers in my Guild who actually gona take a break, and drink a beer in a local pub on jour health, bsmorgan.

I'll try this one out - it will eat data rapidly.

Thank :)
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: PvPLog 3.0.0

Postby tuigii » Wed Jun 04, 2008 7:35 pm

tuigii wrote:I've got 4 no-live-PVP gamers in my Guild ....


Ok, it didn't took long to make me understand that there is a minor flaw in the actual way of roster uploading.

One of my "18 hours a day go BG" 7/7 asked me why the uploading goes wrong every time.
A small reseach showed me that HIS pvp upload aborts with an out of memory error.
WTF, I said, I just moved my entire Guild site to a full fledged $$ server - with plenty of memory (32 Mb for apache/php uploadeable files).

This guys had a whopping 13 Mb pvplog.lua file :shock:
The upload takes time, that one thing.
But the lua parser explodes the file in a memory based array that eats up all memory.
I'm NOT gona pay me a 100 $ / month server for those PVP guys ^^

I called the next pvp player in line to check his file size. Couldn't reach him, he was in BG, of course [ confirmed : 7 Mb ]

Question : nothing can be done here, I understand, except for making the LUA parser a little bit 'intelligent' and have it breaking up these files that can be huge in smaller parts ?
If this becomes a 'real issue', then let it be a 2.0.1 WoWRoster issue :wink:
Question : instaed of flushing the entire pvplog.lua file, is there a way to say : keep the latest x thousand entries - scratch the older ones on startup ?

Let it be clear that pvplog can't handle the size of these growing lua anyway, some kind of smart-purging should be build in.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

PvPLog 3.0.0

Postby zanix » Wed Jun 04, 2008 10:35 pm

PHP sets limits on uploads and consumes a lot of memory when converting a lua file to a php array.

The parser in 2.0 is less memory intensive and is faster than in 1.7.3, but it still uses more resources than we would like it to.
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

PvPLog 3.0.0

Postby PleegWat » Wed Jun 04, 2008 10:36 pm

The PHP array is about 5 times as large as the source file. There are potential solutions, but they need a lot of work to be implemented.

Pruning the old logs won't affect the site - existing pvplog data is not removed before loading the new.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: PvPLog 3.0.0

Postby tuigii » Wed Jun 04, 2008 11:25 pm

PleegWat wrote:...
Pruning the old logs won't affect the site - existing pvplog data is not removed before loading the new.

That's good news :D

Have to admin that I didn't look at the roster code to see if the players pvplog details are purged before injection.

Anyway, it seems that many WoW users blow away their WTF directory anyway ones in a while (go figure why :wink: ).
A nice side effect is that it 'solves' these kind of issues.

Still, limiting the LUA file size is an WoW Addon thing. Not a WoWRoster question.
Last edited by tuigii on Wed Jun 04, 2008 11:26 pm, edited 1 time in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: PvPLog 3.0.0

Postby bsmorgan » Sat Jun 07, 2008 10:06 pm

In the PvPLog too big topic, the problem with the size of the PvPLog.lua savedvariables file was discussed. In that topic I said:
I've modified the code to copy some data from PurgeLogData into PvPLogData so that old PurgeLogData can be removed with minimal adverse effect.

I've added a command (/pl keep N) that will delete old records in PurgeLogData so that only the most recent N remain.


I can look into making N a saved value and executing the "keep" command somewhere.

Brad
User avatar
bsmorgan
WoW Interface Developer
WoW Interface Developer
 
Posts: 160
Joined: Tue Nov 28, 2006 10:17 pm
Location: Colorado Springs, Colorado


Return to PvPLog

Who is online

Users browsing this forum: No registered users and 0 guests

cron