Item parsing - head enchant not detected

Posts from previous Beta sessions

Item parsing - head enchant not detected

Postby Diska » Mon Jun 09, 2008 4:26 pm

Heya,

I'm not sure what the current goals are for the item parsing, but I have several characters uploaded using CP but the head enchants on them do not get detected, yet the item is parsed full.

Elwick: http://blazeofglory.game-host.org/roste ... nfo&a=c:27
Diska: http://blazeofglory.game-host.org/roste ... fo&a=c:202
Eredian: http://blazeofglory.game-host.org/roste ... fo&a=c:290

From what I can see it appears that headpieces socketed with a meta gem fail to parse the head enchant.

On the following 2 characters the parsing of the headpiece falls back to simple parsing:
Faiv: http://blazeofglory.game-host.org/roste ... fo&a=c:291
Wobbel: http://blazeofglory.game-host.org/roste ... fo&a=c:272
User avatar
Diska
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 179
Joined: Tue Jul 04, 2006 2:05 pm

Item parsing - head enchant not detected

Postby zanix » Mon Jun 09, 2008 10:36 pm

We will try to fix this error

As a side note, our item parsing specialist has been away for some time now
I hope he comes back
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Item parsing - head enchant not detected

Postby Diska » Tue Jun 10, 2008 4:56 am

I digged into this, and it turns out that it is caused by 1 of the lines in the item tooltip being prefixed with some spaces, which causes that line to not get left out in the $tooltipWithoutColoredLines variable.
I tested this by removing the spaces in my characterprofiler.lua and reuploading, and then it works :)

Line 948 of lib\item.php should have the regex adapted to account for leading spaces, or maybe you would want to go further and check all lines for em.

edit:
the custom upload breaks the meta gem requirement checking, but if the regex would be adapted that shouldn't affect it
Last edited by Diska on Tue Jun 10, 2008 5:01 am, edited 1 time in total.
User avatar
Diska
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 179
Joined: Tue Jul 04, 2006 2:05 pm


Return to Archived

Who is online

Users browsing this forum: Yahoo [Bot] and 0 guests

cron