If you find any bug in the Missing Recipes addon, please post them here.

Describe the bug, what you did to get the bug and the version of the addon you are using.

Regards,

Teta

We are running the DE-Version or better the AddOn on a Webpage with DE as the selected language. The list of missing receipes lists also receipes the Char already knows. The output is not trustable at this point. Maybe there is a problem in parsing the Information? However. The Roster-Date (Name and Title of the receipe) is similar to what Allkehezan shows so there is no different spelling.

What might be the reason?
Thanks for any hint

We are using Roster 2.0.

Here an example:

From allrecipes:

Code: Select all

		88 =>  Array(
			'icon' => '<a href="http://wow.allakhazam.com/db/item.html?witem=21023"><img alt="" src="http://www.die-illuminaten-azeroths.de/roster/img/Interface/Icons/inv_misc_food_65.jpg" alt="" height="32" width="32" border="0" /></a>',
			'name' => 'Dirges abgefahrene Chimearokkoteletts',
			'i_link' => '/db/spell.html?wspell=25659&source=live&locale=deDE',
			'skill' => '<span class="orangename">300</span> <span class="yellowname">325</span> <span class="greenname">337</span> <span class="greyname">350</span>',
			'r_link' => '/db/spell.html?wspell=25659&source=live&locale=deDE',
			'pat_link' => '/db/item.html?witem=21025&locale=deDE',
			'pat_name' => 'Rezept: Dirges abgefahrene Chimaerokkoteletts'
			),

From knownrecipes

Code: Select all

	19 =>  recipe object(
		'data' =>  Array(
			0 => 32
			'member_id' => 32,
			1 => 25659,
			'recipe_id' => 25659,
			2 => '21023:0:0:0:0:0:0:0',
			'item_id' => '21023:0:0:0:0:0:0:0',
			3 => 'Dirges abgefahrene Chimaerokkoteletts',
			'recipe_name' => 'Dirges abgefahrene Chimaerokkoteletts',
			4 => 'Essen & Trinken',
			'recipe_type' => 'Essen & Trinken',
			5 => 'Kochkunst',
			'skill_name' => 'Kochkunst',
			6 => 1,
			'difficulty' => 1,
			7 => 'ffffff',
			'item_color' => 'ffffff',
			8 => 'Scharfe Gewürze [x1]<br>Goblinraketentreibstoff [x1]<br>Tiefsteinsalz [x1]<br>Chimaeroklenden [x1]',
			'reagents' => 'Scharfe Gewürze [x1]<br>Goblinraketentreibstoff [x1]<br>Tiefsteinsalz [x1]<br>Chimaeroklenden [x1]',
			9 => 'inv_misc_food_65',
			'recipe_texture' => 'inv_misc_food_65',
			10 => 'Dirges abgefahrene Chimaerokkoteletts
Benötigt Stufe 55
Benutzen: Stellt im Verlauf von 30 Sek. insgesamt 4320 Gesundheit wieder her. Ihr müsst beim Essen sitzen bleiben. Wenn Ihr mindestens 10 Sekunden lang mit Essen verbringt, werdet Ihr satt und erhaltet 15 Min. lang 25 Punkte Ausdauer.',
			'recipe_tooltip' => 'Dirges abgefahrene Chimaerokkoteletts
Benötigt Stufe 55
Benutzen: Stellt im Verlauf von 30 Sek. insgesamt 4320 Gesundheit wieder her. Ihr müsst beim Essen sitzen bleiben. Wenn Ihr mindestens 10 Sekunden lang mit Essen verbringt, werdet Ihr satt und erhaltet 15 Min. lang 25 Punkte Ausdauer.',
			11 => Null,
			'level' => Null,
			12 => Null,
			'item_level' => Null
			)
		),

As listed the fields 'name' and 'recipe_name' are equal but the array_diff comes back with an similar entry.

Hi,

This is very strange indeed...

Could you go into the index.php file in the "/roster/addon/missingrecipes/char" directory and uncomment lines 171, 172 and 175? It should look something like this:

Code: Select all

aprint($allrecipenames);
aprint($knownrecipenames);

//aprint($skill_level);
aprint($diffrecipenames);

Then access the same page again and copy paste the contents here in the forum.

Also, could you tell me for which character you are having this problem, or if it is for multiple characters...

Regards,

Teta

Hi Teta,
thats what I did and where the entries from. To show you the full entries of the arrays I will add a text-file since the output would be too large to be posted on the page. Thanks for looking into this!!
Btw its a problem of a lot of characters in our Roster
Holgi

Hi Teta,
did you have the time to look into this issue?
Would be nice to have some feedback.
Holgi

I found that the way I'm doing the array_diff is not the most efficient way, and I have a version running on my site that does it better. Although I do not think that this is going to do anything for your problem, I would like you to check it. I'll put the new version on the download page.

Regards,

Teta

Did the update help you?

Teta

No, sorry, same result.
I now have even several Receipes which were empty. They do not have any description, only an icon and some figures for the Skillportion but no Topic and no name.

The Dirges-Recipe for example is still listed, but the char already know this receipe.

btw. Here the german version of deDE.php:

Code: Select all

<?php
/**
 * WoWRoster.net WoWRoster
 *
 * LICENSE: Licensed under the Creative Commons
 *          "Attribution-NonCommercial-ShareAlike 2.5" license
 *
 * enUS Locale
 *
 * @copyright  2002-2007 WoWRoster.net
 * @license    http://creativecommons.org/licenses/by-nc-sa/2.5   Creative Commons "Attribution-NonCommercial-ShareAlike 2.5"
 * @version    SVN: $Id: enUS.php 1312 2007-09-07 00:32:51Z Zanix $
 * @link       http://www.wowroster.net
 * @package    Forum
 * @subpackage Locale
*/

$lang['missing_recipe'] = 'Fehlende Rezepte';
$lang['missing_recipe_desc'] = 'Zeigt die Rezepte, die dem Char noch fehlen.';
$lang['missing_recipe_button'] = 'Fehlende Rezepte|Welches Rezept fehlt mir noch?';

$lang['skill_level'] = 'Skill Level';

Holgiranemsi wrote:No, sorry, same result.
I now have even several Receipes which were empty. They do not have any description, only an icon and some figures for the Skillportion but no Topic and no name.

The Dirges-Recipe for example is still listed, but the char already know this receipe.

I know about the missing descriptions: They are missing in Allakhazam, so that's why they are missing in the addon. Nothing I can do about it in the current form of the addon

Teta

Holgiranemsi wrote:btw. Here the german version of deDE.php:

Code: Select all

<?php
/**
 * WoWRoster.net WoWRoster
 *
 * LICENSE: Licensed under the Creative Commons
 *          "Attribution-NonCommercial-ShareAlike 2.5" license
 *
 * enUS Locale
 *
 * @copyright  2002-2007 WoWRoster.net
 * @license    http://creativecommons.org/licenses/by-nc-sa/2.5   Creative Commons "Attribution-NonCommercial-ShareAlike 2.5"
 * @version    SVN: $Id: enUS.php 1312 2007-09-07 00:32:51Z Zanix $
 * @link       http://www.wowroster.net
 * @package    Forum
 * @subpackage Locale
*/

$lang['missing_recipe'] = 'Fehlende Rezepte';
$lang['missing_recipe_desc'] = 'Zeigt die Rezepte, die dem Char noch fehlen.';
$lang['missing_recipe_button'] = 'Fehlende Rezepte|Welches Rezept fehlt mir noch?';

$lang['skill_level'] = 'Skill Level';

Thanks! Will be added in the next release, with credits

Teta

np ;-)
Back to our/my problem. I'm not so familar with PHP just currently digging into it a little bit. I did a var_dump to both arrays (known-/all-recipes) but this point looks ok, all fields are strings so the comparison should work.
After surfing a little bit I found several hints which I tried: I splitted the 2nd array from the index and moved the instance (1) where my char has the problem (cooking-recipes) into a non indexed array or let me say an array with only one index. The diff_array gave the same results. I also added a hash-index to both and then I did the diff_array but also, same result. Normally this can't be, as the data in the arrays is clean and consitentially stored and should be comparable so that duplicates should be found and removed in the target array...but there are still duplicates.

My PHP is not good enough to rework your script to use the Item-ID instead of the name-field but I would be very courious if this might help. Collect the Item-ID from all available recipes, collect them also from the Roster for the dedicated Char and compare them to each other trying to find the missing recipes. Then, when displaying the result (if the comparison gives the correct result) translate them using the webwite into the names and data.

Normally the current script should work, YES. But I have no clue why it does not cooperate. That there are some reipes out there on Allakhazam where no name/description exists is one thing. But that the PHP-function seems to be not able to compare two same values makes me nuts.

Is somebody out there who would be able to try the comparison by Item-ID? Might this be a problem of DE-Values when the script compares Strings (low-/Upercases, DE-Char-Sets)? But, the fields are really equal to each other without those viewable differences.

Holgi

I've removed the array_diff function and used a foreach loop with in_array.
Download the index.php file below (it's the one for the 2.0.1.0 version of the addon, so make sure you upgrade if needed) overwrite the index.php file with this one and see if it fixes the problem.

Regards,

Teta

No, sorry, almost same result. But the Tooltips are now in english.

Here the Link