Error with spells

A detailed character information viewer
Includes character stats, item bonuses, talents, spell book, mail, inventory, quests, and recipes.

Error with spells

Postby Ernor » Wed Aug 06, 2008 2:25 pm

Hi,

I just reinstall the new roster and it works well fine ! Good job !

The only problem I have (for now) is in Spell Book
It generates an SQL Error with spell type [Magie de l'ombre]
The quote in type name breaks the sql syntax

My roster is in french and the game too

This is the link to my roster : http://www.hordeuxsf.com/roster2/
If you want to try, use Vobor (holy priest)

Image
Last edited by Ernor on Wed Aug 06, 2008 3:46 pm, edited 4 times in total.
User avatar
Ernor
WR.net Apprentice
WR.net Apprentice
 
Posts: 3
Joined: Thu Jul 20, 2006 6:14 pm
Location: Belgium

Error with spells

Postby zanix » Thu Aug 07, 2008 11:44 am

Open addons/info/inc/char.lib.php
Line 587

Find
Code: Select all
$query2 "SELECT * FROM `" $roster->db->table('spellbook') . "` WHERE `member_id` = '" $this->data['member_id'] . "' AND `spell_type` = '$spell_type' ORDER BY `spell_name`;"


Replace with
Code: Select all
$query2 "SELECT * FROM `" $roster->db->table('spellbook') . "` WHERE `member_id` = '" $this->data['member_id'] . "' AND `spell_type` = '" $roster->db->escape($spell_type) . "' ORDER BY `spell_name`;"
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Error with spells

Postby zanix » Thu Aug 07, 2008 11:45 am

Oh, and moved to the correct forum
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Error with spells

Postby Ernor » Thu Aug 07, 2008 4:51 pm

Works perfectly, thanks

And sorry for the wrong section :oops:
User avatar
Ernor
WR.net Apprentice
WR.net Apprentice
 
Posts: 3
Joined: Thu Jul 20, 2006 6:14 pm
Location: Belgium

Re: Error with spells

Postby tuigii » Wed Jan 21, 2009 2:58 pm

Humm, this still isn't right, I think the modification didn't make it the last releases.

Code in addons/info/inc/char.lib.phpright now, line 587
Code: Select all

$query2 
"SELECT * FROM `" $roster->db->table('spellbook') . "` WHERE `member_id` = '" $this->data['member_id'] . "' AND `spell_type` = '$spell_type' ORDER BY `spell_name`;"


The error I saw :
SELECT * FROM `XXroster_spellbook` WHERE `member_id` = '735' AND `spell_type` = 'Magie de l'ombre' ORDER BY `spell_name`;

Normal, this part => 'Magie de l'ombre' is quoted and has quotes in it :eek:

The proposed $roster->db->escape($spell_type) is lost /removed again ?

But very needed :o
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Error with spells

Postby zanix » Thu Jan 22, 2009 12:05 am

It was probably forgotten :(
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US


Return to CharacterInfo

Who is online

Users browsing this forum: No registered users and 0 guests

cron