Searching the Guild Vault is possible now

Displays items, money, and logs from the Guild Vault

Searching the Guild Vault is possible now

Postby tuigii » Mon Oct 06, 2008 4:49 am

I said to myself : why can't we search into vault, the WoWRoster core addon ?
Because a file is missing.

Here it is (included as a zip).

Just put the file included file search.inc.php in the addons/vault/inc directory.
Be carefull, the directory structure of the zip file is already vault/inc/search.inc.php

Nothing more to do, it will be integrated right away in the search engine.

Geeh, the AddonSDK is a great thing : http://www.wowroster.net/MediaWiki/AddonSDK :thumleft:
Please, Zanix, look it over, stamp it, and bring it to the SVN. It's ok for me, if it's ok for the Dev's.

Test drive it over here : http://www.papy-team.fr/roster/index.php?p=search&a=g:1 and use a word like Libram (be careful now, French roster :eek: )
Attachments
vault.zip
The search.inc.php file for the core addons/vault addon.
Put the file into the addons/vault/inc directory.
(1.68 KiB) Downloaded 111 times
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: Searching the Guild Vault is possible now

Postby zanix » Mon Oct 06, 2008 9:37 am

tuigii wrote:I said to myself : why can't we search into vault, the WoWRoster core addon ?
Because a file is missing.

And because we just never gotten around to it

tuigii wrote:Geeh, the AddonSDK is a great thing : http://www.wowroster.net/MediaWiki/AddonSDK :thumleft:

It is, isn't it?

tuigii wrote:Please, Zanix, look it over, stamp it, and bring it to the SVN. It's ok for me, if it's ok for the Dev's.

Will do
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Searching the Guild Vault is possible now

Postby Wyren » Wed Oct 08, 2008 1:26 pm

Is it supposed to search thru all guilds/vaults on a multi-guild roster?
Wyren
WR.net Journeyman
WR.net Journeyman
 
Posts: 81
Joined: Wed Jul 26, 2006 3:07 pm

Searching the Guild Vault is possible now

Postby zanix » Thu Oct 09, 2008 7:28 am

Looks like it does
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Searching the Guild Vault is possible now

Postby tuigii » Thu Oct 09, 2008 9:07 pm

Well, good question: I didn’t even check that.

The items are taken from the table without taken into account from which Guild they came from. Worse: even items pages that should be accessible only when entering the Guild, Officer or Admin password are shown.
This is a design flaw: I’ll correct that.

Note that searching for items with the search button in the main menu WILL not stop when characters do not want to show their sacs and bags. All items will be shown. This is also true for vault-searching, even if you protected your Vault-view access with password for the 3 levels.

A real bug will show up when having multiple Guildes – the colon “pages”’ will not show the correct page names. (but it won't fault, and shown items are really present "in one of the multiples vaults ^^))

Every Guild can have 1 to 6 pages (name stored in the field item_name), numbers Tab1 to Tab6 (stored in the field item_slot). Pages identification is indicates by the field item_parent being named ‘vault’.
For two or more guilds with a Vault, there will be more then one record (field item_slot) that’s being named “Tab1”.
The guild_id has to be taken in account to discriminate between different Guilds and there different pages.

This implies that objects also have to be related to the ‘owner’ guild_id, so that the correct page will be named (and: the owner Guild).

I thinks I’ve got something to do ;-)
I’ll be back with an update.

Btw : thanks for bringing up the issue :thumleft: I'll finish the job
If someone thinks sthat still something is missing, please stand up and speak.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Searching the Guild Vault is possible now

Postby zanix » Fri Oct 10, 2008 2:51 am

I added this to the SVN, modified a bit though

tuigii, check it out first before making changes to yours

However, it does not take into account the current user in Roster
This is something I have not thought about and in fact, the other search files need to be fixed for user auth as well
Last edited by zanix on Fri Oct 10, 2008 2:52 am, edited 1 time in total.
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Searching the Guild Vault is possible now

Postby tuigii » Fri Oct 10, 2008 5:07 am

zanix wrote:tuigii, check it out first before making changes to yours

Ok, I saw it.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France


Return to GuildVault

Who is online

Users browsing this forum: No registered users and 0 guests

cron