Glyphs Display

Based on GemDisplay, this will display the glyph your Roster characters can craft.

Moderator: emilise

Re: Glyphs Display

Postby Calystos » Tue Nov 18, 2008 5:03 am

emilise wrote:Well I know why it doesn't sort in english, it is a problem in the localization file.
The two lines
$lang['GDmajor']=" major";
$lang['GDminor']=" minor";

should be :

$lang['GDmajor']="Major ";
$lang['GDminor']="Minor ";

These two lines are used to detect if this is a major or minor glyph and the words are not in the same order in French and English.

Gotta love it when a simply case glitch screws things up, lol. Or rather the space (just noticed that space hiding there at the start, then moved to the end, lol. (I just woke up, am not seeing clearly yet, haha)
Last edited by Calystos on Tue Nov 18, 2008 5:19 am, edited 1 time in total.
User avatar
Calystos
UA/UU Developer
UA/UU Developer
 
Posts: 140
Joined: Tue Mar 04, 2008 10:57 am
Location: Earth

Glyphs Display

Postby PleegWat » Tue Nov 18, 2008 6:14 am

Casing in filenames:

On a windows server, this will not matter. Mismatched case will still include the right file.

On a linux server, it does matter. An include call to 'enUS.php' will not include an actual file called 'enus.php'.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: Glyphs Display

Postby emilise » Tue Nov 18, 2008 4:16 pm

Calystos wrote:Gotta love it when a simply case glitch screws things up, lol. Or rather the space (just noticed that space hiding there at the start, then moved to the end, lol. (I just woke up, am not seeing clearly yet, haha)

Yes, in English you read "Major glyph", while in French you read "Glyphe majeur", that's why the case changes and the space too.
Moskow @ Ivresse - EU-Khaz'Modan
User avatar
emilise
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 18
Joined: Thu Aug 09, 2007 11:36 pm

Re: Glyphs Display

Postby Calystos » Wed Nov 19, 2008 8:25 am

Also just noticed another possible glitch in the enUS.php file.

Code: Select all
//color
$lang['GDclass']['demo']="Warlock";
$lang['GDclass']['chaman']="Shaman";
$lang['GDclass']['chasseur']="Hunter";
$lang['GDclass']['war']="Warrior";
$lang['GDclass']['pretre']="Priest";
$lang['GDclass']['mage']="Mage";
$lang['GDclass']['druide']="Druid";
$lang['GDclass']['dk']="Death Knight";
$lang['GDclass']['paladin']="Paladin";
$lang['GDclass']['voleur']="Rogue";


Should be:

Code: Select all
//color
$lang['GDclass']['warlock']="Warlock";
$lang['GDclass']['shaman']="Shaman";
$lang['GDclass']['hunter']="Hunter";
$lang['GDclass']['warrior']="Warrior";
$lang['GDclass']['priest']="Priest";
$lang['GDclass']['mage']="Mage";
$lang['GDclass']['druid']="Druid";
$lang['GDclass']['dk']="Death Knight";
$lang['GDclass']['paladin']="Paladin";
$lang['GDclass']['rogue']="Rogue";


Shouldn't it?

EDIT: Slight additional change, added missing "var $wrnet_id = 0;" to the install php file. And re-archived and uploaded the lot.
Attachments
glyphsdisplay.zip
Appended version, with above changes along with missing "var $wrnet_id = 0;" in the install file. Version number incremented to .1 instead of .0.
(7.05 KiB) Downloaded 115 times
Last edited by Calystos on Wed Nov 19, 2008 5:00 pm, edited 3 times in total.
User avatar
Calystos
UA/UU Developer
UA/UU Developer
 
Posts: 140
Joined: Tue Mar 04, 2008 10:57 am
Location: Earth

Glyphs Display

Postby emilise » Wed Nov 19, 2008 3:33 pm

Hi there,

Fot the $lang['GDclass'] array, it doesn't have any importance. We could use
$lang['GDclass'][] = 'Warlock", it would work as well. I think I will do that!

For the == or ===, it is important to keep the 3 =. See the warning in http://fr2.php.net/manual/fr/function.strpos.php for the reason why.
Last edited by emilise on Wed Nov 19, 2008 3:37 pm, edited 2 times in total.
Moskow @ Ivresse - EU-Khaz'Modan
User avatar
emilise
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 18
Joined: Thu Aug 09, 2007 11:36 pm

Re: Glyphs Display

Postby Calystos » Wed Nov 19, 2008 4:57 pm

emilise wrote:Hi there,

Fot the $lang['GDclass'] array, it doesn't have any importance. We could use
$lang['GDclass'][] = 'Warlock", it would work as well. I think I will do that!

For the == or ===, it is important to keep the 3 =. See the warning in http://fr2.php.net/manual/fr/function.strpos.php for the reason why.

Heh, a quick trip to the EN version an yeah I see.

I'm so used to programming in C not PHP, and there is no === option. So at first I thought it was a typo, lol.
User avatar
Calystos
UA/UU Developer
UA/UU Developer
 
Posts: 140
Joined: Tue Mar 04, 2008 10:57 am
Location: Earth

Re: Glyphs Display

Postby Wyren » Thu Nov 27, 2008 2:35 pm

Slight oversight on my behalf there on the spacing in "Major " and "Minor " :)

Anyhow, installed the latest version, and for some reason I don't get the "menu" on top where you have the links to the various glyph types, or the icon to collapse each box.
http://roster.treehuggery.org/index.php ... play&a=g:1
Wyren
WR.net Journeyman
WR.net Journeyman
 
Posts: 81
Joined: Wed Jul 26, 2006 3:07 pm

Glyphs Display

Postby Grektar » Thu Nov 27, 2008 4:14 pm

A quick german (deDE) localisation.

Code: Select all
<?php
/**
 * WoWRoster.net WoWRoster
 *
 * LICENSE: Licensed under the Creative Commons
 *          "Attribution-NonCommercial-ShareAlike 2.5" license
 *
 * @copyright  2002-2007 WoWRoster.net
 * @license    http://creativecommons.org/licenses/by-nc-sa/2.5   Creative Commons "Attribution-NonCommercial-ShareAlike 2.5"
 * @link       http://www.wowroster.net
 * @package    GlyphsDisplay
 * @subpackage Installer
*/

$lang['GlyphDisplay_menu'] = 'Glyphen|Zeigt Glyphen an die von Gildenmitgliedern hergestellt werden können.';
$lang['glyph_title_addon'] = 'Glyphen';

$lang['Glyph_title']="Glyphe";
$lang['Objet']='Objekt';
$lang['Name']='Name';
$lang['level']='Level';
$lang['compo']='Materialien';
$lang['crafter']='Kann hergestellt werden von';
$lang['Filter']='Filter';
$lang['NoFilter']='Kein Filter';

//Craft Name
$lang['Glyph']="Glyphe";
$lang['sill']="Inschriftenkunde";

//slot name
$lang['slot']="Glyphe";
$lang['GDmajor']="Erhebliche ";
$lang['GDminor']="Geringe ";

//color
$lang['GDclass'][]="Hexenmeister";
$lang['GDclass'][]="Schamane";
$lang['GDclass'][]="Jäger";
$lang['GDclass'][]="Krieger";
$lang['GDclass'][]="Priester";
$lang['GDclass'][]="Magier";
$lang['GDclass'][]="Druide";
$lang['GDclass'][]="Todesritter";
$lang['GDclass'][]="Paladin";
$lang['GDclass'][]="Schurke";

$lang['admin']['gld_main_conf'] = 'Allgemeine Einstellungen';
$lang['admin']['gld_expand'] = 'Ansicht standardmäßig erweitern / reduzieren ?|Anzeige der Glyphen standardmäßig geschlossen / geöffnet anzeigen.';
$lang['admin']['gld_order'] = 'Standard Sortierung|Kategorie Sortierung nach erheblich / gering umschalten.';

?>
Last edited by Grektar on Thu Nov 27, 2008 4:15 pm, edited 1 time in total.
ImageImageImageImage
User avatar
Grektar
WR.net Apprentice
WR.net Apprentice
 
Posts: 22
Joined: Sun Jul 23, 2006 3:23 pm

Glyphs Display

Postby PleegWat » Thu Nov 27, 2008 4:32 pm

Can't you use one of the global class arrays (like id_to_class) to get a list of class names?
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Glyphs Display

Postby emilise » Thu Nov 27, 2008 7:30 pm

Wyren I suspect you took your version from this forum, and not in the download section.

Thanks Grektar for the localization ! I will include it soon.

PleegWat : I didn't know that exists. I'm very new to addon development. Thanks for the advice.
Moskow @ Ivresse - EU-Khaz'Modan
User avatar
emilise
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 18
Joined: Thu Aug 09, 2007 11:36 pm

Re: Glyphs Display

Postby DoubleTap » Sat Nov 29, 2008 11:42 pm

Greetings,

Where can we get the icons/graphics for this ?
DoubleTap
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Fri Nov 02, 2007 8:59 am

Glyphs Display

Postby emilise » Mon Dec 01, 2008 6:17 pm

Hi,

I think that the icons are committed on SVN, you can just update them from here

http://svn.wowroster.net/interface/40x40/Icons/
Moskow @ Ivresse - EU-Khaz'Modan
User avatar
emilise
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 18
Joined: Thu Aug 09, 2007 11:36 pm

Re: Glyphs Display

Postby ScratchMonkey » Tue Dec 02, 2008 10:55 pm

emilise wrote:Hi,

I think that the icons are committed on SVN, you can just update them from here

http://svn.wowroster.net/interface/40x40/Icons/


Handy to know. With that clue, I added the svn:externals property to the Interface directory of my working copy with this content:

Code: Select all
Icons   http://svn.wowroster.net/interface/40x40/Icons
ItemSocketingFrame      http://svn.wowroster.net/interface/40x40/ItemSocketingFrame
PvPRankBadges   http://svn.wowroster.net/interface/40x40/PvPRankBadges
Spellbook       http://svn.wowroster.net/interface/64x64/Spellbook
TalentFrame     http://svn.wowroster.net/interface/40x40/TalentFrame
Image
User avatar
ScratchMonkey
WR.net Expert
WR.net Expert
 
Posts: 212
Joined: Wed Jul 05, 2006 4:32 pm
Location: San Pablo, CA

Glyphs Display

Postby Djuwal » Wed Dec 24, 2008 10:21 pm

I'm trying to find it now in the code, but maybe someone can answer it before I mess up the file too badly. When I click on the links at the top where it says Death Knight - Minor (any of those links) it takes me to my home page. I suspect it may have something to do with this line in the template.inc.php file:

Code: Select all
$tmp[] = '<a href="'.$url.'#'.$id.'" title="'.$type.'" onclick="javascript:show(\'table'.$id.'\');">'.$type.'</a>'


but not entirely sure what to do with it.

Thanks for any and all help.

EDIT:
Oh, my roster is located at http://guildofhardknocks.com/roster
Last edited by Djuwal on Wed Dec 24, 2008 10:22 pm, edited 1 time in total.
User avatar
Djuwal
WR.net Apprentice
WR.net Apprentice
 
Posts: 13
Joined: Fri Jul 14, 2006 8:51 pm

Re: Glyphs Display

Postby emilise » Mon Dec 29, 2008 5:07 pm

Hi Djuwal,

The line that doesn't work is in fact this one :
Code: Select all
$url 'http://'.$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI']; 

It seems that the $_SERVER['REQUEST_URI'] is null on your server. Could you please add this line
Code: Select all
var_dump($_SERVER); 
just below the one I quoted here, upload the modified file to your server and copy here what it shows on your roster.

You can see on your roster that the links are wrong since they show i.e. http://guildofhardknocks.com/#DeathKnight-Major instead of http://guildofhardknocks.com/roster/ind ... ight-Major
Moskow @ Ivresse - EU-Khaz'Modan
User avatar
emilise
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 18
Joined: Thu Aug 09, 2007 11:36 pm

PreviousNext

Return to Glyphs Display

Who is online

Users browsing this forum: No registered users and 0 guests

cron