Guildvault Log

Displays items, money, and logs from the Guild Vault

Guildvault Log

Postby Magicdealer » Thu Apr 09, 2009 1:43 am

We've recently started using the Guild Vault addon to keep track of our vault inventories and item movements as additional security.

The problem is that the guild vault log is only displaying the item number, not the name itself.

Is this working as intended? Or is there some way I can get it to display the item name?
Attachments
Magicdealer
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Thu Apr 09, 2009 1:17 am

Re: Guildvault Log

Postby zanix » Thu Apr 09, 2009 2:03 am

Intended, no
The way it currently works, yes

The vault addon only know what items it has "seen" meaning it has to have existed in the vault
The log will display the item number for items it hasn't "seen" yet
We eventually want to get item data from the armory, that may show up in Roster 2.1
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Guildvault Log

Postby Magicdealer » Thu Apr 09, 2009 4:10 am

Ok, thank you :rabbit:
Magicdealer
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Thu Apr 09, 2009 1:17 am

Re: Guildvault Log

Postby tuigii » Thu Apr 09, 2009 8:23 pm

Wait.

Open /roster/addons/vault/guild/index.php - goto line 127
You'll find this as a code fragment :

Code: Select all
            }
         }
      }
   }

   return $item_id;
}

Make it look like this (replace the statement return $item_id;):
Code: Select all
   // These lines are new
   switch($roster->config['locale']):
   case "frFR":
      $wowhead_language = "fr";
      break;
   case "deDE":
      $wowhead_language = "de";
      break;
   case "esES":
      $wowhead_language = "es";
      break;
   default:
      $wowhead_language = "www";
      endswitch;               
      
   return '<a href="http://'.$wowhead_language.'.wowhead.com/?item='.$id.'" target="_blank">'.$id.'</a>';


What does this do for you ?
It still show the item ID's - correct - but they became links to a site that actually works great the last couple of months : wowhead.com
They have the enUS, frFR, deDE and esES languages item details - even the Russians could use it.
wowhead is fast & good (using it even in own forum ).

I'm not taking out / parsing the item ID - that would be a WoWRoster 2.1 solution. A local cache system should be used.
Pulling in all the item details from the ID's every time you watch these Vault log pages would really hit the wowhead server - they (wowhead.com) wouldn't like that.
You could say : why not converting when uploading the Vault info ? Answer : then the Items names would be hard coded in your the database, and again, when you have 6 pages and many items that left your Vault, wowhead.com would be smacked again with requests. Updating would also be more error-prone.

What you have now is a "click" solution : click on the ID, and you will be brought to the item description page in your roster language.

See it in action here : http://www.papy-team.fr/roster/index.ph ... ault&a=g:1 (switch to your own language if you want to :D )
This is of course a nifty patch - this kind of handling should be surfaced - maybe it's even better to use the armory for it.
Local caching of item ID's, Tooltip and other related info should be stored on YOUR site - note that these items do not necessarily belong to you or one of your mates, they might have left your Guild already. - This database table will grow to the size of all know items in WoW (WoW !!).
I use this for a couple of month now - it's ok as a simple patch.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: Guildvault Log

Postby tuigii » Wed Apr 15, 2009 9:57 am

Some one else manged to implement this ?
Works ? To difficult ? Comments ?
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France


Return to GuildVault

Who is online

Users browsing this forum: No registered users and 0 guests

cron