Icon showing blank[solved]

Sync Blizzards' Armory data with WoWRoster (addon depreciated no longer works see ApiSync)

Moderators: Ulminia, poetter

Icon showing blank[solved]

Postby Lorkam » Wed May 13, 2009 7:25 am

Ok AS is working as it is supposed to be the only problem I have is the icon images they are not displaying,the buttons are working fine just the buttons are blank. I tried looking into the code and all the buttons are installing good just no image inside the buttons. I'm running AS 2.7.1 and roster 2.0.2. If you need any more information I will gladly post it. I have a few more like this too like gems addon and glyphs too so don't know whats up.

Image
Image

Alright gonna edit this I did check the locale files to make sure they didn't get renamed when I uploaded them. So check that off on what it could possibly be.
Last edited by Lorkam on Wed May 20, 2009 12:57 am, edited 1 time in total.
Roster Version 2.0.2
Roster Guild Deathbringershttp://deathbringer.us/(a)roster/
Roster Guild Deathbringer(new roster template) http://deathbringer.us/(h)roster/
Guild site hosted and templated by WoWGuilds.ca (highly recommend) http://deathbringers.us/
Image
User avatar
Lorkam
WR.net Apprentice
WR.net Apprentice
 
Posts: 37
Joined: Mon Jul 10, 2006 12:21 pm

Re: Icon showing blank

Postby Lorkam » Tue May 19, 2009 9:34 pm

Hello Ulminia I know you are probably really busy. But was wondering if you could help me with this. Or atleast point me in the right direction on what it could possibly be. I checked the forums and couldn't find an answer. I have two rosters as you can see here and both icons are not showing the path to my alliance roster is /(a)roster and my horde roster path is /(h)roster. If you need my admin password info let me know I can pm ya it. I normally don't give it out to anyone except devs that are helping me out.

http://deathbringer.us/(a)roster/
http://deathbringer.us/(h)roster/

I checked AS image directory to make sure the images where infact there and from what I see they are here is a list of images in the AS image directory:

poetter_avatar.png
as_char.jpg
as_guild_add.jpg
as_memberlist.jpg
Thumbs.db
as_logo.png
as_pic1.png
as_pic2.png
as_pic3.png
Roster Version 2.0.2
Roster Guild Deathbringershttp://deathbringer.us/(a)roster/
Roster Guild Deathbringer(new roster template) http://deathbringer.us/(h)roster/
Guild site hosted and templated by WoWGuilds.ca (highly recommend) http://deathbringers.us/
Image
User avatar
Lorkam
WR.net Apprentice
WR.net Apprentice
 
Posts: 37
Joined: Mon Jul 10, 2006 12:21 pm

Re: Icon showing blank

Postby PleegWat » Tue May 19, 2009 10:54 pm

Probably CSS syntax errors due to the () brackets in your pathname. Seems that for some reason the other icons are put in with relative URLs, but the armorysync icons, which are in the AS image dir, are linked with absolute URLs (relative to the site root).

I'll take a look into the php code involved, but the easiest option may be to change the directory name.

EDIT: lib/menu.php, around line 700, find:

Code: Select all
$button['icon'] = ROSTER_PATH . 'addons/' . $button['basename'] . '/images/' . $button['icon'];


Replace with:

Code: Select all
$button['icon'] = 'addons/' . $button['basename'] . '/images/' . $button['icon'];


untested.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: Icon showing blank[Solved]

Postby Lorkam » Wed May 20, 2009 12:48 am

That fixed it thanks again Pleegwat. I renamed the directories to h_roster and a_roster and the icons are now showing for AS. :glad:
Roster Version 2.0.2
Roster Guild Deathbringershttp://deathbringer.us/(a)roster/
Roster Guild Deathbringer(new roster template) http://deathbringer.us/(h)roster/
Guild site hosted and templated by WoWGuilds.ca (highly recommend) http://deathbringers.us/
Image
User avatar
Lorkam
WR.net Apprentice
WR.net Apprentice
 
Posts: 37
Joined: Mon Jul 10, 2006 12:21 pm

Re: Icon showing blank[solved]

Postby AnthonyB » Wed May 20, 2009 11:40 am

Yeah, brackets in a URL is a big no, no. I'm sure there's an RFC that contains recommendations for accepted characters but I'd suggest hypens would be the safest with underscores (as you've done) being next.
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Re: Icon showing blank[solved]

Postby zanix » Wed May 20, 2009 3:47 pm

The menu buttons are css backgrounds, it probably doesn't have quotes or ticks around the url

Code: Select all
background-image:url(http://some.url.com/(a)roster/images/img.png)

vs
Code: Select all
background-image:url('http://some.url.com/(a)roster/images/img.png')


The quotes around the url to the image would fix this
I'll try to remember to fix this for Roster
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Icon showing blank[solved]

Postby AnthonyB » Thu May 21, 2009 11:40 am

Shouldn't have to fix something, or allow for something, which is an absolute no no.

RFC1738 - Uniform Resource Locators (URL)
http://www.faqs.org/rfcs/rfc1738.html

A URL contains the name of the scheme being used (<scheme>) followed
by a colon and then a string (the <scheme-specific-part>) whose
interpretation depends on the scheme.

Scheme names consist of a sequence of characters. The lower case
letters "a"--"z", digits, and the characters plus ("+"), period
("."), and hyphen ("-") are allowed. For resiliency, programs
interpreting URLs should treat upper case letters as equivalent to
lower case in scheme names (e.g., allow "HTTP" as well as "http").
Roster 2.0.2 svn [latest] latest trunk SVN svn [latest] running on IIS7/Windows Server 2008 SP2 | MySQL 5.0.85 | PHP 5.2.10 | Yes, Roster and PHP rocks on IIS! Even run as FastCGI extension!
User avatar
AnthonyB
Gimpy Developer
Gimpy Developer
 
Posts: 346
Joined: Tue Jul 04, 2006 2:44 pm
Location: Sydney, Australia

Re: Icon showing blank[solved]

Postby zanix » Fri May 22, 2009 2:08 am

It seems like ( and ) are allowed in urls
Thus, only alphanumerics, the special characters "$-_.+!*'(),", and
reserved characters used for their reserved purposes may be used
unencoded within a URL.



Here is the full section

2.2. URL Character Encoding Issues
URLs are sequences of characters, i.e., letters, digits, and special
characters. A URLs may be represented in a variety of ways: e.g., ink
on paper, or a sequence of octets in a coded character set. The
interpretation of a URL depends only on the identity of the
characters used.

In most URL schemes, the sequences of characters in different parts
of a URL are used to represent sequences of octets used in Internet
protocols. For example, in the ftp scheme, the host name, directory
name and file names are such sequences of octets, represented by
parts of the URL. Within those parts, an octet may be represented by

the chararacter which has that octet as its code within the US-ASCII
[20] coded character set.

In addition, octets may be encoded by a character triplet consisting
of the character "%" followed by the two hexadecimal digits (from
"0123456789ABCDEF") which forming the hexadecimal value of the octet.
(The characters "abcdef" may also be used in hexadecimal encodings.)

Octets must be encoded if they have no corresponding graphic
character within the US-ASCII coded character set, if the use of the
corresponding character is unsafe, or if the corresponding character
is reserved for some other interpretation within the particular URL
scheme.

No corresponding graphic US-ASCII:

URLs are written only with the graphic printable characters of the
US-ASCII coded character set. The octets 80-FF hexadecimal are not
used in US-ASCII, and the octets 00-1F and 7F hexadecimal represent
control characters; these must be encoded.

Unsafe:

Characters can be unsafe for a number of reasons. The space
character is unsafe because significant spaces may disappear and
insignificant spaces may be introduced when URLs are transcribed or
typeset or subjected to the treatment of word-processing programs.
The characters "<" and ">" are unsafe because they are used as the
delimiters around URLs in free text; the quote mark (""") is used to
delimit URLs in some systems. The character "#" is unsafe and should
always be encoded because it is used in World Wide Web and in other
systems to delimit a URL from a fragment/anchor identifier that might
follow it. The character "%" is unsafe because it is used for
encodings of other characters. Other characters are unsafe because
gateways and other transport agents are known to sometimes modify
such characters. These characters are "{", "}", "|", "\", "^", "~",
"[", "]", and "`".

All unsafe characters must always be encoded within a URL. For
example, the character "#" must be encoded within URLs even in
systems that do not normally deal with fragment or anchor
identifiers, so that if the URL is copied into another system that
does use them, it will not be necessary to change the URL encoding.

Reserved:

Many URL schemes reserve certain characters for a special meaning:
their appearance in the scheme-specific part of the URL has a
designated semantics. If the character corresponding to an octet is
reserved in a scheme, the octet must be encoded. The characters ";",
"/", "?", ":", "@", "=" and "&" are the characters which may be
reserved for special meaning within a scheme. No other characters may
be reserved within a scheme.

Usually a URL has the same interpretation when an octet is
represented by a character and when it encoded. However, this is not
true for reserved characters: encoding a character reserved for a
particular scheme may change the semantics of a URL.

Thus, only alphanumerics, the special characters "$-_.+!*'(),", and
reserved characters used for their reserved purposes may be used
unencoded within a URL.

On the other hand, characters that are not required to be encoded
(including alphanumerics) may be encoded within the scheme-specific
part of a URL, as long as they are not being used for a reserved
purpose.
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US


Return to ArmorySync - Depreciated

Who is online

Users browsing this forum: No registered users and 0 guests

cron