Wowroster bug fixes

Posts from previous Beta sessions

Wowroster bug fixes

Postby trelis » Sat Dec 04, 2010 11:19 am

Some more wowroster bug fixes:

Error description: I don't have the error message for this one anymore, but I believe it was an "S_RESPONSE" doesn't exist PHP warning message on the following page:

page: /roster/index.php?p=rostercp-armory_data&a=g:1

Suggestions:
Code: Select all
Index: admin/armory_data.php
===================================================================
--- admin/armory_data.php   (revision 2215)
+++ admin/armory_data.php   (working copy)
@@ -157,6 +157,10 @@
       )
    );
 }
+else
+{
+   $roster->tpl->assign_var('S_RESPONSE',false);
+}
 
 $roster->output['title'] .= 'Armory Data';


Error description: Some armory requests don't work if you don't have a trailing / on your armory url in configuration.

Suggestion:

The way it is written now it manually adds the / for each URL, but for example, even the three right below where it is defined are missing it so that method fixes some URLs and not others. The better solution is to just add it in the initial definition.

Code: Select all
Index: lib/armory.class.php
===================================================================
--- lib/armory.class.php   (revision 2215)
+++ lib/armory.class.php   (working copy)
@@ -165,7 +165,7 @@
       global $roster;
 
       $this->base_url                  = ROSTER_URL;//see if this works..$roster->config['website_address'].'/'; // gotta have a trailing slash here..... allways....
-      $this->url_prefix_armory      = isset($roster->data['armoryurl']) ? $roster->data['armoryurl'] : $this->url_prefix_armory;
+      $this->url_prefix_armory          = isset($roster->data['armoryurl']) ? $roster->data['armoryurl'].'/' : $this->url_prefix_armory;
       $this->url_prefix_char         = $this->url_prefix_armory . $this->url_prefix_char;
       $this->url_prefix_itemtooltip   = $this->url_prefix_armory . $this->url_prefix_itemtooltip;
       $this->url_prefix_talents      = $this->url_prefix_armory . $this->url_prefix_talents;
@@ -186,17 +186,17 @@
    if( $query === 'roster' )
    {
       $filename_type = 'guild-info';
-      $url = $this->url_prefix_armory.'/'.$filename_type.'.xml?r=' . urlencode( $server ) . '&gn=' . urlencode( $guild );
+      $url = $this->url_prefix_armory.$filename_type.'.xml?r=' . urlencode( $server ) . '&gn=' . urlencode( $guild );
    }
    elseif( $query === 'character' )
    {
       $filename_type = 'character-sheet';
-      $url = $this->url_prefix_armory.'/'.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie);
+      $url = $this->url_prefix_armory.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie );
    }
    elseif( $query === 'achievement' )
    {
       $filename_type = 'character-achievements';
-      $url = $this->url_prefix_armory.'/'.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie);
+      $url = $this->url_prefix_armory.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie );
    }
    //$url_prefix_itemtooltip
    elseif( $query === 'itemtooltip' )


I also have a bugfix to memberlist, I posted that separately under that addon:

topic6231.html
trelis
WR.net Apprentice
WR.net Apprentice
 
Posts: 19
Joined: Fri Nov 26, 2010 1:14 pm

Re: Wowroster bug fixes

Postby zanix » Sat Dec 04, 2010 8:33 pm

Thanks for the fixes, we will look them over.
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: Wowroster bug fixes

Postby Ulminia » Sun Dec 05, 2010 12:11 am

fixes are in referance to armory sync now armory data for roster armory data has a hard coded url it uses 'S_RESPONSE' is referance to errors thrown back from syncing will check in to it
Ulminia of Zangarmarsh
Zonous of Zangarmarsh
Author of Roster Gallery
WoWRoster-Profiler Redesigner
User avatar
Ulminia
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 1223
Joined: Tue Jul 04, 2006 4:41 pm
Location: New Brunswick, Canada
Realm: Zangarmarsh (PvE) - US
gmail/gtalk: ulminia@gmail.com


Return to Archived

Who is online

Users browsing this forum: No registered users and 1 guest

cron