The bank of the guildbank (french local)

Categorizes items in your guildbank(s)

Moderator: Mathos

The bank of the guildbank (french local)

Postby ethyde » Sat Aug 19, 2006 1:30 pm

Hi,

I used a wowroster with a french translation, but i don't know why ... it's impossible to watch the bank of the guildbank :

exemple :

CGB : http://www.guild-auryn.org/roster/addon ... =guildbank

bags of a guildbank : http://www.guild-auryn.org/roster/char. ... ction=bags thats ok

bank of guildbank http://www.guild-auryn.org/roster/char. ... ction=bank

thx for all and sorry for ma bad english
ethyde
WR.net Apprentice
WR.net Apprentice
 
Posts: 6
Joined: Tue Jul 11, 2006 4:53 pm

The bank of the guildbank (french local)

Postby zanix » Sun Aug 20, 2006 4:15 am

Looks ok to me
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Re: The bank of the guildbank (french local)

Postby lesablier » Sun Aug 20, 2006 2:03 pm

Me too (moi aussi :) )
lesablier
WR.net Journeyman
WR.net Journeyman
 
Posts: 77
Joined: Sat Jul 15, 2006 4:01 pm

Re: The bank of the guildbank (french local)

Postby sturmy » Tue Aug 29, 2006 12:27 pm

I'm upping this, as I have a similar problem (I guess).

GuildBank as included with Roster 1.7.0 displays the bank content of my bank characters and the bag contents.

However Categorized guild bank (the addon), only displays the contents of the bags of the bank character.

I haven't looked at the SQL requests to check if there is any difference between the addon & the core, but help is appreciated!

*Edit* actually it only displays on-character bag contents and the bank main slots, but not the bank bag slots. Dunno if that's clear enough a description.
Last edited by sturmy on Tue Aug 29, 2006 12:36 pm, edited 1 time in total.
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

Re: The bank of the guildbank (french local)

Postby sturmy » Thu Sep 07, 2006 10:22 pm

Right. With my newly-found php & mysql skills, I checked, and the query against the DB performed returns all the contents. Yet for some reason, items disappear and do not display (they're not in the generated page).

There's a trend for recipes (especially tailoring recipes) not to show up. I suspect some funny-strange localization problem, but can't put my finger on it ATM.

Here's the file I use for frFR in case that helps someone.
Attachments
localization.zip
loc file with more frFR bits in it
(9.87 KiB) Downloaded 156 times
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

Re: The bank of the guildbank (french local)

Postby brouette » Fri Sep 08, 2006 5:24 am

It seems it comes from the SQL query in gbank.php. When you extract data from DB you check if the object is Soulbound :

Code: Select all
$itemQuery = "SELECT member.name as member_name,
 member.member_id as member_id, item.*,
LEFT(item.item_id, (LOCATE(':',item.item_id)-1)) as real_itemid
FROM `".ROSTER_ITEMSTABLE."`
as item LEFT JOIN `".ROSTER_MEMBERSTABLE."`
as member ON item.member_id=member.member_id
WHERE member.".$roster_conf['banker_fieldname']."
LIKE '%".$roster_conf['banker_rankname']."%'
AND item.item_parent!='bags'
AND item.item_parent!='equip'".$filterItemQuery.$lvlItemQuery." 
ORDER BY item.item_name";


Important part is the last test :
Code: Select all
AND item.item_tooltip NOT LIKE '%".$wordings[$roster_conf['roster_lang']]['tooltip_soulbound']."%'


However, frFR translation for 'Soulbound' is 'Lié' and all item has the mention 'Lié quand équipé' for 'Equiped' : so all item which have to be Equiped are also not valid for your querry. I think if you check, all the objects that miss have the mention 'Lié' : the problem comes from french language :)

The ugly solution could be, if your bank don't have any soulbound item, just deleting the last test of the query.
Sure it must be a better way, but it's 2Am here and I have to sleep :)

Best regards,
Last edited by brouette on Fri Sep 08, 2006 5:37 am, edited 6 times in total.
brouette
WR.net Apprentice
WR.net Apprentice
 
Posts: 1
Joined: Wed Jul 05, 2006 3:53 pm

Re: The bank of the guildbank (french local)

Postby sturmy » Fri Sep 08, 2006 7:37 am

Thanks I'll give it a shot, but the query against the sql DB itself does return all the items... (when sqldebug is activated, the generated php contains the exact query performed as an HTML comment and I ran this directly in phpmyadmin) so I rather suspected processing of the result list...
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

Re: The bank of the guildbank (french local)

Postby Badsnake » Mon Sep 11, 2006 4:16 am

I wait with lot of to hope your solution because i have four mule in my guild and to look item inside is too hard with classic guild bank

But i can look when i do "inventory" in config of roster "bank guild" items "lié quand équipé" not show without "Categorized Guild Bank"

http://guilde.legiodraconis.free.fr/Ros ... ldbank.php

http://guilde.legiodraconis.free.fr/Ros ... dbank2.php
Badsnake
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Mon Jul 24, 2006 11:47 pm

The bank of the guildbank (french local)

Postby sturmy » Mon Sep 11, 2006 10:44 am

OK. I was probably dizzy when I read brouette's post (sorrryyyyyy)... For a reason.

The why guild bank (included with Roster) is giving away ALL bank char items is because "Soulbound" is NOT using the translation scheme in guildbank.php. The pattern IS identical to the one of guildbank beyond that. And it's the one I had used for phpmyadmin queries.

This being said, the fundamental issue is indeed that "Binds when equipped" and "soulbound" are using the same word in the FR locale: "Lié quand equipé" vs "Lié". Therefore the NOT LIKE %soulbound% in french not only strips out the BOUND items but also those that will be bound when equipped.

The not so nice fix is indeed to strip out the AND items ... NOT LIKE %soulbound% (in gbank.php). This brings back all items with the soulbound or binds when equipped line in the tooltip. However it means when do have bound items in there, kinda stupid for bank chars as those items can't be traded.

An SQL magician is needed so that we modify the query to exclude only the items with "%Soulbound%" and not those that are "%Binds when equipped%" (requires new localization string). And we can afterwards modify the "native" guildbank to be localized.

*Edit* Second thoughts: the quickest way to do it is probably to make a union of the existing request (all items minus "bind on equip" AND "bound") with another SQL request (all items with "bind on equip" only). That would give the expected output I assume, without any duplicate. My SQL is far past me, so I would appreciate assistance in making the final query!
Last edited by sturmy on Mon Sep 11, 2006 2:05 pm, edited 1 time in total.
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

The bank of the guildbank (french local)

Postby PleegWat » Mon Sep 11, 2006 4:12 pm

Try AND (items NOT LIKE %soulbound% OR items LIKE %BoE%)
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

The bank of the guildbank (french local)

Postby sturmy » Mon Sep 11, 2006 9:33 pm

/bow pleegwat

Here is the change I applied in gbank.php:

Code: Select all
$itemQuery "SELECT member.name as member_name, member.member_id as member_id, item.*, LEFT(item.item_id, (LOCATE(':',item.item_id)-1)) as real_itemid FROM `".ROSTER_ITEMSTABLE."` as item LEFT JOIN `".ROSTER_MEMBERSTABLE."` as member ON item.member_id=member.member_id WHERE member.".$roster_conf['banker_fieldname']." LIKE '%".$roster_conf['banker_rankname']."%' AND item.item_parent!='bags' AND item.item_parent!='equip'".$filterItemQuery.$lvlItemQuery." AND (item.item_tooltip NOT LIKE '%".$wordings[$roster_conf['roster_lang']]['tooltip_soulbound']."%' OR item.item_tooltip LIKE '%".$wordings[$roster_conf['roster_lang']]['tooltip_boe']."%') ORDER BY item.item_name"


and add

Code: Select all
    $wordings['frFR']['tooltip_boe']='Lié quand Ã©quipé'


to the global frFR.php file
(to maintain multilinguism, maybe someone should add
Code: Select all
    $wordings['enUS']['tooltip_boe']='Soulbound'
to the enUS file and something for german?)

Similarly, for the sake of internationalization, in the core guildbank.php here are the modifications:

Code: Select all
$query1"SELECT m.member_id, m.name as member_name, m.note as member_note, m.officer_note as member_officer_note, i.*, sum(i.item_quantity) as total_quantity
 FROM `"
.ROSTER_ITEMSTABLE."` as i, `".ROSTER_MEMBERSTABLE."` as m
 WHERE i.member_id=m.member_id
 AND m."
.$roster_conf['banker_fieldname']." LIKE '%".$roster_conf['banker_rankname']."%'
 AND i.item_parent!='bags'
 AND i.item_parent!='equip'
 AND (i.item_tooltip
 NOT LIKE '%"
.$wordings[$roster_conf['roster_lang']]['tooltip_soulbound']."%' 
 OR i.item_tooltip 
 LIKE '%"
.$wordings[$roster_conf['roster_lang']]['tooltip_boe']."%')
 GROUP BY i.item_name"
;

$query2"SELECT m.member_id, m.name as member_name, m.note as member_note, m.officer_note as member_officer_note, i.*
 FROM `"
.ROSTER_ITEMSTABLE."` as i, `".ROSTER_MEMBERSTABLE."` as m
 WHERE i.member_id=m.member_id
 AND m."
.$roster_conf['banker_fieldname']." LIKE '%".$roster_conf['banker_rankname']."%'
 AND i.item_parent!='bags'
 AND i.item_parent!='equip'
 AND (i.item_tooltip
 NOT LIKE '%"
.$wordings[$roster_conf['roster_lang']]['tooltip_soulbound']."%' 
 OR i.item_tooltip 
 LIKE '%"
.$wordings[$roster_conf['roster_lang']]['tooltip_boe']."%')
 ORDER BY i.item_name"


Right...

Now let's sort out this Max.Resist thingy ;-)
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

The bank of the guildbank (french local)

Postby Corwin_Whitehorn » Sat Sep 30, 2006 12:43 pm

For some obscure reason, I cannot put the "Rubis étoilé" in the gems category.

It's supposed to be there already
Code: Select all
$wordings['gems']['frFR'] =
array(
"Malachite""Oeil de tigre""Enorme émeraude""Grande opale",
"Cristal de puissance vert""Cristal de puissance jaune""Cristal de puissance bleu",
"Cristal de puissance rouge""Aigue-Marine""Perle noire"


"Rubis étoilé",


"Perle bleue""Perle dorée""Perle iridescente",  "Vitriol noir",
"Pierre de lune inférieure""Saphir bleu""Diamant d'Azeroth""Diamant noir",
"Diamant noir parfait""Sang de la montagne""Agate""Agate enchantée"
"Citrine""Jade""Cristal des arcanes""Pierre de gardien""Oeil ténébreux"); 


But it stays in the "Objets divers" category (I checked the way it's supposed to be written...)
Last edited by Corwin_Whitehorn on Sat Sep 30, 2006 12:44 pm, edited 1 time in total.
Image
User avatar
Corwin_Whitehorn
WR.net Apprentice
WR.net Apprentice
 
Posts: 10
Joined: Fri Aug 18, 2006 6:18 pm

The bank of the guildbank (french local)

Postby zanix » Tue Nov 21, 2006 8:14 am

sturmy, your fix was overlooked for 1.7.1 but I did get it in 1.7.2
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

The bank of the guildbank (french local)

Postby sturmy » Tue Nov 21, 2006 11:42 pm

/bow zanix
/thank zanix
/cheer zanix

Just keep up what you're doing in the same way. You're doing fantastic work.
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm


Return to Categorized Guild Bank

Who is online

Users browsing this forum: No registered users and 0 guests

cron