Riding skill Icon

Requests, feedback, and general discussion about WoWRoster
DO NOT post topics about WoWRoster AddOns here!

Re: Riding skill Icon

Postby Harshmage » Tue Oct 03, 2006 12:33 am

Luckygirl wrote:Friend's roster site has the icons showing up with multiple mount icons per character where applicable. I asked him about it and he said he downloaded some extra icons??

http://guildpraetorian.com/roster/


Okay, from my guess, not everyone has updated their profiles. Before the new "fix" for riding, everyone could get training in riding for the different mounts. The "fix" set it where it dosen't matter where you train your riding skill, it just matters that you have A riding skill.
The Praetorian guild roster will need to be updated with vgjunkie's code (see above), to actually work right, and everyone will have to upload their stats again to make things work.
Ho, Haha, Guard, Turn, Parry, Dodge, Spin, Ha, Thrust!
Image
User avatar
Harshmage
WR.net Apprentice
WR.net Apprentice
 
Posts: 43
Joined: Fri Sep 08, 2006 10:11 am
Location: Arizona, USA

Re: Riding skill Icon

Postby Luckygirl » Tue Oct 03, 2006 6:54 am

Thankyou for the clarifacation. You guys rock for supporting this support forum!
Luckygirl
WR.net Apprentice
WR.net Apprentice
 
Posts: 17
Joined: Sun Oct 01, 2006 4:22 am

Re: Riding skill Icon

Postby IslandStyle » Wed Oct 11, 2006 9:58 am

vgjunkie wrote:
sileed wrote:1. Check for Riding Skill
2. then grab player Race
3. Display "default" icon for riding by Race (Horse for Human, Cat for NE, Ram for Dwarves etc...)

Possibly making it an array:

If Riding Skill exist
Race = Human, icon=horse
Race= NE, icon=Cat
etc..

You coders will work it out, I just make up the ideas :)


I added local/enUS.php file:

Code: Select all
// Riding Skill Icons-Array
$wordings['enUS']['Riding'] = array(
                'Night Elf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Dwarf'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Undead'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);



Then in memberslist.php (in the "Main Query") add:

Code: Select all
'`players`.`race`, '.

(I put it above  '`players`.`RankName`, '.)


Then! in the function tradeskill_icons below:
Code: Select all
Below the $skill_image variable I added:

if($r_prof['skill_name'] == "Riding")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];



It's a good amount of work, and will probably get fixed soon, so depending on how desperate you are to get it working, you can just ignore my madness :)


Ok now I feel stupid... i changed the files like you said, or at least though that I did, but I don't get any riding icons showing up for the new riding skills of 75 or 150. Are both the last 2 changes made in the memberlist.php, or is the function tradeskill_icons in a different file?

Thanks in advance for your help
Image
Image
User avatar
IslandStyle
WR.net Apprentice
WR.net Apprentice
 
Posts: 41
Joined: Tue Jul 11, 2006 8:57 am

Re: Riding skill Icon

Postby wacoede » Fri Oct 13, 2006 2:38 am

vgjunkie wrote:
sileed wrote:1. Check for Riding Skill
2. then grab player Race
3. Display "default" icon for riding by Race (Horse for Human, Cat for NE, Ram for Dwarves etc...)

Possibly making it an array:

If Riding Skill exist
Race = Human, icon=horse
Race= NE, icon=Cat
etc..

You coders will work it out, I just make up the ideas :)


I added local/enUS.php file:

Code: Select all
// Riding Skill Icons-Array
$wordings['enUS']['Riding'] = array(
                'Night Elf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Dwarf'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Undead'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);



Then in memberslist.php (in the "Main Query") add:

Code: Select all
'`players`.`race`, '.

(I put it above  '`players`.`RankName`, '.)


Then! in the function tradeskill_icons below:
Code: Select all
Below the $skill_image variable I added:

if($r_prof['skill_name'] == "Riding")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];



It's a good amount of work, and will probably get fixed soon, so depending on how desperate you are to get it working, you can just ignore my madness :)


this fix works and my guild members like me again (*phew* almost got lynched when i told the everyone was gonna have the Horse for riding)

of note if you run AltMonitor make sure you do the Memberlist.php changes to altlist.php aswell
User avatar
wacoede
WR.net Apprentice
WR.net Apprentice
 
Posts: 49
Joined: Sat Sep 02, 2006 2:07 am

Riding skill Icon

Postby RainRider » Tue Oct 17, 2006 7:31 pm

This won't work on a german or french roster, will it?

It would be really nice if someone would post a localised version of the fix.

Thank you in advance
Rain
RainRider
WR.net Apprentice
WR.net Apprentice
 
Posts: 50
Joined: Thu Jul 20, 2006 11:47 pm

Re: Riding skill Icon

Postby ahnernoch » Tue Oct 17, 2006 8:18 pm

also for a german roster pls! :rabbit2:
ahnernoch
WR.net Apprentice
WR.net Apprentice
 
Posts: 31
Joined: Sat Sep 02, 2006 12:33 am

Re: Riding skill Icon

Postby wacoede » Wed Oct 18, 2006 1:28 am

ok French and german translations Thank the Siggen Author for this i just used his translations

French frFR.php
Code: Select all
// Riding Skill Icons-Array
$wordings['frFR']['Riding'] = array(
                'Elfe de la nuit'=>'Ability_Mount_WhiteTiger',
                'Humain'=>'Ability_Mount_RidingHorse',
                'Nain'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Mort-Vivant'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);

function tradeskill_icons
Code: Select all
if($r_prof['skill_name'] == "Monte")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];


German deDE.php
Code: Select all
// Riding Skill Icons-Array
$wordings['deDE']['Riding'] = array(
                'Nachtelf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Zwerg'=>'Ability_Mount_MountainRam',
                'Gnom'=>'Ability_Mount_MechaStrider',
                'Untoter'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);

function tradeskill_icons
Code: Select all
if($r_prof['skill_name'] == "Reiten")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];


the
Code: Select all
'`players`.`race`, '.
should work on all due it refeering to the database
User avatar
wacoede
WR.net Apprentice
WR.net Apprentice
 
Posts: 49
Joined: Sat Sep 02, 2006 2:07 am

Riding skill Icon

Postby zanix » Wed Oct 18, 2006 7:18 am

wacoede wrote:Thank the Siggen Author for this i just used his translations

You are welcome :)
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Riding skill Icon

Postby Romish » Wed Oct 18, 2006 2:39 pm

Hello all,

I have implemented this fix but I have changed a little bit the code so that you don't have a specific language to use in the if condition. I have also added the special cases of Warlock and Paladin.

Here is what I have done for french:
- In frFR.php (just after the line
Code: Select all
$wordings['frFR']['PvPRankNone']=... 
) add the line:
Code: Select all
$wordings['frFR']['Riding'] = 'Monte'


- in frFR.php, add the array:
Code: Select all
// Riding Skill Icons-Array
$wordings['frFR']['riding_iconArray'] = array(
                
'Elfe de la nuit'=>'Ability_Mount_WhiteTiger',
                
'Humain'=>'Ability_Mount_RidingHorse',
                
'Nain'=>'Ability_Mount_MountainRam',
                
'Gnome'=>'Ability_Mount_MechaStrider',
                
'Mort-Vivant'=>'Ability_Mount_Undeadhorse',
                
'Troll'=>'Ability_Mount_Raptor',
                
'Tauren'=>'Ability_Mount_Kodo_03',
                
'Orc'=>'Ability_Mount_BlackDireWolf',
                
'Paladin'=>'Ability_Mount_Dreadsteed',
                
'Démoniste'=>'Ability_Mount_NightmareHorse'
); 


- in memberlist.php in the main query, just before
Code: Select all
'`players`.`RankName`, '
, add the line:
Code: Select all
'`players`.`race`, '


- in memberlist.php, in the function tradeskill_icons, change the line:
Code: Select all
$skill_image 'Interface/Icons/'.$wordings[$row['clientLocale']]['ts_iconArray'][$r_prof['skill_name']]; 

with:
Code: Select all
        if($r_prof['skill_name'] == $wordings[$row['clientLocale']]['Riding'])
            if(
$row['class']==$wordings[$row['clientLocale']]['Paladin'] || $row['class']==$wordings[$row['clientLocale']]['Warlock'])
                
$skill_image 'Interface/Icons/'.$wordings[$row['clientLocale']]['riding_iconArray'][$row['class']];
            else
                
$skill_image 'Interface/Icons/'.$wordings[$row['clientLocale']]['riding_iconArray'][$row['race']];
        else
            
$skill_image 'Interface/Icons/'.$wordings[$row['clientLocale']]['ts_iconArray'][$r_prof['skill_name']]; 


Then if you want it for us or de or whatever language, only the localization file needs to be changed.

For enUS:
- In enUS.php (just after the line
Code: Select all
$wordings['enUS']['PvPRankNone']=... 
) add the line:
Code: Select all
$wordings['enUS']['Riding'] = 'Riding'


- in enUS.php, add the array:
Code: Select all
// Riding Skill Icons-Array
$wordings['enUS']['riding_iconArray'] = array(
                
'Night Elf'=>'Ability_Mount_WhiteTiger',
                
'Human'=>'Ability_Mount_RidingHorse',
                
'Dwarf'=>'Ability_Mount_MountainRam',
                
'Gnome'=>'Ability_Mount_MechaStrider',
                
'Undead'=>'Ability_Mount_Undeadhorse',
                
'Troll'=>'Ability_Mount_Raptor',
                
'Tauren'=>'Ability_Mount_Kodo_03',
                
'Orc'=>'Ability_Mount_BlackDireWolf',
                
'Paladin'=>'Ability_Mount_Dreadsteed',
                
'Warlock'=>'Ability_Mount_NightmareHorse'
); 


For deDE:
- In deDE.php (just after the line
Code: Select all
$wordings['deDE']['PvPRankNone']=... 
) add the line:
Code: Select all
$wordings['deDE']['Riding'] = 'Reiten'


- In deDE.php, add the array:
Code: Select all
$wordings['deDE']['Riding'] = array(
                
'Nachtelf'=>'Ability_Mount_WhiteTiger',
                
'Human'=>'Ability_Mount_RidingHorse',
                
'Zwerg'=>'Ability_Mount_MountainRam',
                
'Gnom'=>'Ability_Mount_MechaStrider',
                
'Untoter'=>'Ability_Mount_Undeadhorse',
                
'Troll'=>'Ability_Mount_Raptor',
                
'Tauren'=>'Ability_Mount_Kodo_03',
                
'Orc'=>'Ability_Mount_BlackDireWolf',
                
'Paladin'=>'Ability_Mount_Dreadsteed',
                
'Hexenmeister'=>'Ability_Mount_NightmareHorse'
); 


Hopes it will be integrated in the main branch.

Regards.
Romish
Attachments
riding_icon_code.zip
To unzip in root of your roster.
It contains the fix for the riding icon:
- my frFR.php
- deDE.php
- usUS.php
- memberlist.php
(46.15 KiB) Downloaded 59 times
Romish
WR.net Apprentice
WR.net Apprentice
 
Posts: 3
Joined: Mon Oct 16, 2006 8:54 pm

Riding skill Icon

Postby zanix » Wed Oct 18, 2006 2:44 pm

Romish wrote:Hopes it will be integrated in the main branch.

It is
Read the Forum Rules, the WiKi, and Search before posting!
WoWRoster v2.1 - SigGen v0.3.3.523 - WoWRosterDF
User avatar
zanix
Admin
Admin
WoWRoster.net Dev Team
WoWRoster.net Dev Team
UA/UU Developer
UA/UU Developer
 
Posts: 5543
Joined: Mon Jul 03, 2006 8:29 am
Location: Idaho Falls, Idaho
Realm: Doomhammer (PvE) - US

Riding skill Icon

Postby SethDeBlade » Wed Oct 18, 2006 11:11 pm

i just thought about this thing a while. what about dwarfs riding tigers, humans riding mechanos, elfs ....

you dont have to ride your "race-mount". I have no char which is riding a different mount then his racemount but can the code sort it out??

btw: i have problems with german clients and dwarfs. in all my dwarf-chars there is no riding icon shown even if they can ride rams. is it a bug in the german version or only in my roster?? other german chars dont have this problem :(
User avatar
SethDeBlade
WR.net Expert
WR.net Expert
 
Posts: 192
Joined: Thu Jul 06, 2006 1:02 am
Location: Germany

Re: Riding skill Icon

Postby Harshmage » Wed Oct 18, 2006 11:55 pm

SethDeBlade wrote:you dont have to ride your "race-mount". I have no char which is riding a different mount then his racemount but can the code sort it out??


As far as that logic goes, no. It specifies the racial mount only. I did suggest the idea of the roster checking the inventory of the character, and displaying accordingly, but that's a TON more work.
The skill "Riding" is a universal skill now, and it's just easier to list the racial mount than to include lines and lines more of code to sort out the inventory, and display whichever mount is there.
Ho, Haha, Guard, Turn, Parry, Dodge, Spin, Ha, Thrust!
Image
User avatar
Harshmage
WR.net Apprentice
WR.net Apprentice
 
Posts: 43
Joined: Fri Sep 08, 2006 10:11 am
Location: Arizona, USA

Riding skill Icon

Postby RainRider » Thu Oct 19, 2006 1:02 am

@Romish
Thank you very much, you did a wonderful job. Now we have nice riding skill icons back again :)

@SethDeBlade
Dwarfs mounts are displayed for me, pre and post riding skill fix.
RainRider
WR.net Apprentice
WR.net Apprentice
 
Posts: 50
Joined: Thu Jul 20, 2006 11:47 pm

Riding skill Icon

Postby PleegWat » Thu Oct 19, 2006 1:25 am

Seth: Yes, you can adapt the code to show all mounts posessed by that character. This would require scanning the tooltip for all items that character has. Doing that for all chars is slow, so we're not gonna do it.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Riding skill Icon

Postby SethDeBlade » Thu Oct 19, 2006 9:46 pm

@rainrider in my char-page it is not shown :(

@pleegwat np, just an idea. as i said i dont need it for my guild.
User avatar
SethDeBlade
WR.net Expert
WR.net Expert
 
Posts: 192
Joined: Thu Jul 06, 2006 1:02 am
Location: Germany

PreviousNext

Return to General Support & Feedback

Who is online

Users browsing this forum: No registered users and 0 guests

cron