Wild growth shoulders are not handled ok

by **Striper** » Thu Nov 02, 2006 7:21 pm

the +62 heal of the shoulders are getting calculated as Fire Resistence...

see: http://www.metagilde.de/LA_roster/addon ... Widerstand

any hint on how to fix it?

(the item ist the Wilde Wachstums-Schiftung in german)

by **Striper** » Sat Nov 11, 2006 6:27 am

is this error being ignored on purpose? I mean according to the roster Druids now have fantastic fire resistences...

Is the developer by chance a druid? ^^

by **Anaxent** » Sat Nov 11, 2006 7:56 am

haha my main is a druid..... but haven't came across this one yet.

by **Striper** » Sat Nov 11, 2006 9:31 pm

is this reproduceable on the english version?

by **Exerladan** » Mon Nov 13, 2006 7:26 pm

May be an explanation in maxres.php :

Code: Select all: $Fire_Resistance." +', item_tooltip, LOCATE('".$tooltip_soulbound."', item_tooltip))-1),0)+17,2),'+',''),

The value "17" was here in order to cut the "item_tooltip" string 17 characters after the start of "Fire Resistance" but it works only for the enUS string "Fire Resistance", so we have to change it by

Code: Select all: $Fire_Resistance." +', item_tooltip, LOCATE('".$tooltip_soulbound."', item_tooltip))-1),0)+LENGTH('".$Fire_Resistance." +'),2),'+',''),

I will post this evening a version that will solve many localization problems (especially frFR localization and this problem too).

by **Striper** » Mon Nov 13, 2006 7:39 pm

edited all 4 occurences of that line, no improvement

would you like me to test the changed version before you releaase it?

by **Exerladan** » Mon Nov 13, 2006 8:14 pm

I'm not the official developper, and the version I will post will only contains many suggestions, and will be provided "as is" (I've not enough time to maintain addons).

However, if you want to test my humble modifications, I agree

by **Striper** » Mon Nov 13, 2006 8:15 pm

as long as it's not killing my database (yes, i will make backups

)

by **Exerladan** » Tue Nov 14, 2006 5:34 pm

After looking your example, if I remember my german lessons, your "Wild growth shoulders" have only a +5 fire resist (Argent Dawn enchant) with no base fire resist. So we have to change the SQL query that search enchant.

To sum up :
in enUS : no difference between enchant string and basic resist string
in deDE : the + xx is at the end of the enchant string and at the start of the basic resist string
in frFR : the enchant string doesn't match with the basic resist string

Give me one more day to integrate these specificities.

by **Striper** » Tue Nov 14, 2006 5:45 pm

sweet!

by **Exerladan** » Tue Nov 14, 2006 8:06 pm

Ok let's go, this is an improved version.

I've tested it with enUS and frFR data.

Before using it, I suggest waiting the end of Striper's tests.

I'm aware that some bugs can be found (like all resist enchant on a specific piece of armor, or like set bonus bonuses, especially with T0.5) but this version is only a step.

If you want to refresh all database stored resistances, just call the URL
http ://your.domain.org/path/to/roster/addon.php?roster_addon_name=maxres&refreshDatabase=true
(it may take a few minutes)

by **Striper** » Tue Nov 14, 2006 8:47 pm

no, still not...

the Wild Growth Shoulders are still being taken instead of my Fireguard Shoulders...

This profile should be shown as my fire resistance gear...

Another error i've noticed is that he recomends an offhand item together with a 2handed Weapon:
Finkle's Lava Dredger + Skull of Burning Shadows

by **Exerladan** » Tue Nov 14, 2006 8:55 pm

Can you give me your deDE CharacterProfiler.lua file ?

So I can do test myself.

by **Striper** » Tue Nov 14, 2006 8:57 pm

Exerladan wrote:Can you give me your deDE CharacterProfiler.lua file ?

So I can do test myself.

here you go

by **Exerladan** » Tue Nov 14, 2006 9:35 pm

Your profile on my roster

Your resistances on my roster

So I can't reproduce the bug...

I see on your roster that you don't replace the files I post ? Do you replace with the new one ? Otherwise it may caused by MySQL query, can I have your PHP and MySQL version ?