Addon: Missing Recipies: Jewelcrafting Fixes

Quick and easy way to see what recipes your character is missing

Moderators: zeryl, Teta68

Addon: Missing Recipies: Jewelcrafting Fixes

Postby Rihlsul » Fri Feb 02, 2007 12:00 pm

(Hopefully our version's current, but this should work nearly regardless).

Open index.php.

Change:
Code: Select all
$professions = array(
"Alchemy" => $wordings[$roster_conf['roster_lang']]['Alchemy'],
"Blacksmithing" => $wordings[$roster_conf['roster_lang']]['Blacksmithing'],
"Cooking" => $wordings[$roster_conf['roster_lang']]['Cooking'],
"Enchanting" => $wordings[$roster_conf['roster_lang']]['Enchanting'],
"Engineering" => $wordings[$roster_conf['roster_lang']]['Engineering'],
"Firstaid" => $wordings[$roster_conf['roster_lang']]['First Aid'],
"Leatherworking" => $wordings[$roster_conf['roster_lang']]['Leatherworking'],
"Tailoring" => $wordings[$roster_conf['roster_lang']]['Tailoring']);

to:
Code: Select all
$professions = array(
"Alchemy" => $wordings[$roster_conf['roster_lang']]['Alchemy'],
"Blacksmithing" => $wordings[$roster_conf['roster_lang']]['Blacksmithing'],
"Cooking" => $wordings[$roster_conf['roster_lang']]['Cooking'],
"Enchanting" => $wordings[$roster_conf['roster_lang']]['Enchanting'],
"Engineering" => $wordings[$roster_conf['roster_lang']]['Engineering'],
"Firstaid" => $wordings[$roster_conf['roster_lang']]['First Aid'],
"Jewelcrafting" => $wordings[$roster_conf['roster_lang']]['Jewelcrafting'],
"Leatherworking" => $wordings[$roster_conf['roster_lang']]['Leatherworking'],
"Tailoring" => $wordings[$roster_conf['roster_lang']]['Tailoring']);


Then open missing.php.

BEFORE:
Code: Select all
      case 'Leatherworking':
         $url = 'http://wow.allakhazam.com/db/skill.html?line=165';
         break;

insert:
Code: Select all
      case 'Jewelcrafting':
         $url = 'http://wow.allakhazam.com/db/skill.html?line=755';
         break;


That seemed to do it for me. Don't forget that your system will take a while to parse the data for the first time, so it'll be slow to load at first, then work at the same speed as the rest of the MR add-on.
Last edited by Rihlsul on Sun Feb 04, 2007 12:20 pm, edited 1 time in total.
Rihlsul,
Guild Leader of The Dirty Hordes
User avatar
Rihlsul
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 125
Joined: Tue Jul 04, 2006 8:27 pm

Re: Easy Update: Jewelcrafting

Postby seleleth » Fri Feb 02, 2007 5:57 pm

Hi there Rihlsul.

I don't wish to discourage you from independently finding and posting fixes in anyway, but I need to mention to things:

1. There is an official fix for this already posted, and it includes several items which you did not address. Here's the link:

http://www.wowroster.net/Forums/viewtopic/t=2439.html

2. What is missing.php? Is this part of some AddOn? I'm not familiar with it.

Thanks.
User avatar
seleleth
Gimpy Developer
Gimpy Developer
 
Posts: 59
Joined: Thu Jul 06, 2006 10:26 pm
Location: Salt Lake City, UT

Easy Update: Jewelcrafting

Postby sturmy » Sat Feb 03, 2007 6:18 am

Actually, that fix does work for the Missing Recipes addon (the rest is indeed fixed by the referenced patch of Roster itself).

The proposed changes however are pointing to the non localized missing recipes, I'll attach those same changes adapted to the localized version.
Attachments
missingrecipe.zip
Missing Recipes with Jewelcrafting, non-US languages support enabled
(7.85 KiB) Downloaded 208 times
Last edited by sturmy on Sat Feb 03, 2007 6:20 am, edited 1 time in total.
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

Re: Easy Update: Jewelcrafting

Postby Rihlsul » Sun Feb 04, 2007 12:15 pm

seleleth wrote:1. There is an official fix for this already posted, and it includes several items which you did not address. Here's the link:

2. What is missing.php? Is this part of some AddOn? I'm not familiar with it.


This fix was a fix to this 3rd party addon, Missing Recipies (...hence the location of the post), not to the core of WoWRoster, which you linked (and I appreciated when it was posted, fixed my Roster right up.)

Thanks sturmy for the localization friendly version! I only speak English and Bad English, so I hadn't installed the localized version of MR. Danke and gracias.
Rihlsul,
Guild Leader of The Dirty Hordes
User avatar
Rihlsul
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 125
Joined: Tue Jul 04, 2006 8:27 pm

Addon: Missing Recipies: Jewelcrafting Fixes

Postby Rihlsul » Sun Feb 04, 2007 12:21 pm

I've changed the title of the thread so it's not going to cause any further confusion when referenced on the front page under "Recent Posts".
Rihlsul,
Guild Leader of The Dirty Hordes
User avatar
Rihlsul
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 125
Joined: Tue Jul 04, 2006 8:27 pm

Re: Addon: Missing Recipies: Jewelcrafting Fixes

Postby blackbat » Mon Feb 12, 2007 12:40 am

has anyone else used the zipped file and had leatherworking poof from the drop down box?
blackbat
WR.net Apprentice
WR.net Apprentice
 
Posts: 1
Joined: Wed Jan 10, 2007 3:25 pm

Re: Addon: Missing Recipies: Jewelcrafting Fixes

Postby Munazz » Mon Feb 12, 2007 4:34 pm

blackbat wrote:has anyone else used the zipped file and had leatherworking poof from the drop down box?


I looked at the code and the author of that zip file has "LeatherWorking" instead of "Leatherworking" which I think is what is causing your error. So edit the index.php file and fix line 30 to say "$wordings[$roster_conf['roster_lang']]['Leatherworking'],"

I think this stems from an issue with the french localization. I don't know where the main problem is, but if you don't have the french version you need to make it a lowercase 'W'.
User avatar
Munazz
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 36
Joined: Mon Jul 31, 2006 7:50 am
Location: Fairfax, VA

Addon: Missing Recipies: Jewelcrafting Fixes

Postby sturmy » Mon Feb 12, 2007 5:53 pm

yep. Sorry 'bout that. I covered this as part of my normal enUS.php file, I have both LeatherWorking and Leatherworking covered in there. And since I zipped my addon only you don't get that.

I run a frFR Roster with clients in enUS and frFR, FYI.
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

Re: Addon: Missing Recipies: Jewelcrafting Fixes

Postby seleleth » Mon Feb 12, 2007 6:26 pm

Rihlsul wrote:I've changed the title of the thread so it's not going to cause any further confusion when referenced on the front page under "Recent Posts".

Thanks, Rihlsul. I did pull the topic right off the recent posts view and somehow missed the forum entirely. :thumright:
User avatar
seleleth
Gimpy Developer
Gimpy Developer
 
Posts: 59
Joined: Thu Jul 06, 2006 10:26 pm
Location: Salt Lake City, UT


Return to Missing Recipes

Who is online

Users browsing this forum: No registered users and 0 guests

cron